Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake warnings support #132

Merged
merged 12 commits into from
Mar 31, 2019
Merged

CMake warnings support #132

merged 12 commits into from
Mar 31, 2019

Conversation

wunderabt
Copy link
Contributor

@wunderabt wunderabt commented Mar 26, 2019 •
edited
Loading

I didn't find a parser that can parse warnings from CMake. So I took a shot at it.

uhafner
uhafner requested changes Mar 28, 2019
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/main/java/edu/hm/hafner/analysis/parser/CMakeParser.java Outdated Show resolved Hide resolved
src/main/java/edu/hm/hafner/analysis/parser/CMakeParser.java Outdated Show resolved Hide resolved
src/main/java/edu/hm/hafner/analysis/parser/CMakeParser.java Outdated Show resolved Hide resolved
src/test/java/edu/hm/hafner/analysis/parser/CMakeParserTest.java Show resolved Hide resolved
src/test/java/edu/hm/hafner/analysis/parser/CMakeParserTest.java Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 28, 2019 •
edited
Loading

Codecov Report

Merging #132 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
+ Coverage     87.85%   87.89%   +0.04%     
- Complexity     1207     1211       +4     
============================================
  Files           156      157       +1     
  Lines          3852     3865      +13     
  Branches        424      424              
============================================
+ Hits           3384     3397      +13     
  Misses          311      311              
  Partials        157      157
Impacted Files Coverage Δ Complexity Δ
...ava/edu/hm/hafner/analysis/parser/CMakeParser.java 100% <100%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6d655...817f77e. Read the comment docs.

@uhafner uhafner merged commit 2958e8b into jenkinsci:master Mar 31, 2019
@uhafner
Copy link
Member

uhafner commented Mar 31, 2019

Thanks! I'll make a snapshot then we can register it in warnings-ng.

@wunderabt
Copy link
Contributor Author

Thanks @uhafner for the review and maintaing this project!!

@uhafner
Copy link
Member

uhafner commented Apr 26, 2019 •
edited
Loading

If you want to change something or add icon, help, etc, please file a PR to warning-ng:

jenkinsci/warnings-ng-plugin@fcf33e4

uhafner added a commit that referenced this pull request Apr 16, 2022
@uhafner
Delete markdown check until there is a fix for #132.
b51227f 
See gaurav-nelson/github-action-markdown-link-check#132
uhafner added a commit that referenced this pull request Apr 22, 2022
@uhafner
Revert "Delete markdown check until there is a fix for #132."
90c4816 
This reverts commit b51227f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhafner uhafner uhafner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wunderabt @uhafner