Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Improve docs for jax.numpy: square, sqrt and modf #23834

Merged
merged 1 commit into from
Sep 23, 2024
Merged

DOC: Improve docs for jax.numpy: square, sqrt and modf #23834

merged 1 commit into from
Sep 23, 2024

Conversation

rajasekharporeddy
Copy link
Contributor

Part of #21461

jakevdp
jakevdp approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakevdp jakevdp self-assigned this Sep 23, 2024
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Sep 23, 2024
@jakevdp
Copy link
Collaborator

jakevdp commented Sep 23, 2024

It looks like there are some doctest errors.

@rajasekharporeddy
Copy link
Contributor Author

Thanks! Updated the code example to fix the doctest errors. Could you please trigger the tests again?

@copybara-service copybara-service bot merged commit 63a890f into jax-ml:main Sep 23, 2024
10 checks passed
@rajasekharporeddy rajasekharporeddy deleted the testbranch2 branch September 24, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajasekharporeddy @jakevdp