Add Unique ID to all mock handlers?

[jakerella]

I'm wondering if we should assign a proper ID to each mock handler. Currently this is just the index in the array of handlers, but that seems fragile. Having proper IDs would still allow clearing individual requests or all handlers, but would eliminate the possibility of the calling code holding onto that index past when it should, then trying to use it and clearing a mock handler that it did not intend to.

Any thoughts @dcneiner or @jcreamer898 (or anyone else)?

[dcneiner]

Possibly – but I wonder if a more traditional approach could be used. For instance, each mock would get a lightweight instance wrapper that is returned instead of a number when $.mockjax is called. Then we could have a destroy method. It also opens the possibility to have more functionality like disable and enable. This would allow someone to create a mock that they can disable and only enable when they need it, or vice versa. Not sure. Just an idea.

[jakerella]

Ooooooooh, yes. I like that idea. Returning a wrapper with a couple helper methods. Let me think on this and I'll suggest a format in here.

[jcreamer898]

What all could be included here?

var mock = $.mockjax({
   url: '/foo'
});

mock.id; // 12345
mock.options; // { /* ... */ }
mock.destroy(); 

[jakerella]

I would argue that we make it mostly functions versus properties, that way we can change implementations later. But what you have so far is a good start:

var mock = $.mockjax({ ... });
mock.getId();
mock.getSettings();
mock.clear(); // versus "destroy", this keeps it in line with $.mockjax.clear()
mock.callCount(); // we already have this info sorta... just have to access it

That's all i can think of right now.

[piuccio]

returning a wrapper would be really handy 😁

[piuccio]

I realise my message was too concise, the wrapper should also include a mockedAjaxCalls() which returns the same thing as $.mockjax.mockedAjaxCalls() but filtered by that single mock.

[jakerella]

Great idea! I'm super busy on other things right now, but I'd like to implement this at some point. It needs to be done carefully, however, so that it doesn't break existing code (if possible).

[piuccio]

changing the return value of $. mockjax is not trivial. One backward compatible option would be to call

var wrap = $.wrapperFor($.mockjax(...));

a bit ugly 😁