Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of strings.ToLower comparison with EqualFold #181

Closed
objectiser opened this issue Jan 25, 2019 · 0 comments
Closed

Replace use of strings.ToLower comparison with EqualFold #181

objectiser opened this issue Jan 25, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@objectiser
Copy link
Contributor

For example,

if strings.ToLower(jaeger.Spec.Strategy) == "streaming" {

should be replaced by

if strings.EqualFold(c.jaeger.Spec.Strategy, "streaming") {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @objectiser