MESH-1743 Merge pull request istio-ecosystem#134 from services-mesh/M…

…ESH-1743-DR-bk MESH-1743 Fix missed vs delete
itsLucario · Jun 27, 2022 · 6f665b4 · 6f665b4
2 parents 47c0dab + 8313a3e
commit 6f665b4
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/admiral/pkg/clusters/handler.go b/admiral/pkg/clusters/handler.go
@@ -471,12 +471,10 @@ func handleVirtualServiceEvent(obj *v1alpha3.VirtualService, vh *VirtualServiceH
 				log.Infof(LogFormat, "Event", "VirtualService", obj.Name, clusterId, "Processing")
 
 				if event == common.Delete {
-					log.Infof(LogFormat, "Delete", "VirtualService", obj.Name, clusterId, "Success")
-					err := rc.VirtualServiceController.IstioClient.NetworkingV1alpha3().VirtualServices(syncNamespace).Delete(obj.Name, &v12.DeleteOptions{})
-					if err != nil {
+					err:= deleteVirtualServicePostStateCheck(rc,syncNamespace,obj.Name,clusterId,r.AdmiralState)
+					if nil!= err {
 						return err
 					}
-
 				} else {
 
 					exist, _ := rc.VirtualServiceController.IstioClient.NetworkingV1alpha3().VirtualServices(syncNamespace).Get(obj.Name, v12.GetOptions{})