Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the sidecar controller #86

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

vrushalijoshi
Copy link
Collaborator

No description provided.

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
@codecov-io
Copy link

Codecov Report

Merging #86 into master will decrease coverage by 0.33%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   50.81%   50.48%   -0.34%     
==========================================
  Files          23       23              
  Lines        1777     1765      -12     
==========================================
- Hits          903      891      -12     
  Misses        799      799              
  Partials       75       75              
Impacted Files Coverage Δ
admiral/pkg/controller/istio/sidecar.go 40.90% <50.00%> (ø)
admiral/pkg/controller/common/config.go 64.28% <0.00%> (-10.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e6d5f...a3c8bed. Read the comment docs.

@vrushalijoshi vrushalijoshi merged commit d9a3258 into master Mar 25, 2020
@vrushalijoshi vrushalijoshi deleted the update-sidecar-controller branch March 25, 2020 06:41
Mengying-Li pushed a commit that referenced this pull request Apr 20, 2020
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com>
Signed-off-by: Madeline <madeline_li@intuit.com>
itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants