Support long identities #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephpeacock
force-pushed
the
support-long-identities
branch
from
64139db
to
2c1b993
Compare
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 48.2% 49.03% +0.82%
==========================================
Files 18 20 +2
Lines 1394 1452 +58
==========================================
+ Hits 672 712 +40
- Misses 667 685 +18
Partials 55 55
Continue to review full report at Codecov.
|
added 8 commits
February 26, 2020 13:52
…esent Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
…nd to enforce singleton-ness Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
josephpeacock
force-pushed
the
support-long-identities
branch
from
2c1b993
to
89836c1
Compare
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
josephpeacock
force-pushed
the
support-long-identities
branch
from
89836c1
to
124d017
Compare
aattuluri
approved these changes
Feb 26, 2020
josephpeacock
added a commit
that referenced
this pull request
Feb 29, 2020
* formalizing the behavior to fall back to annotation if label isn't present Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Removing the hardcoded references to a default identity label Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Nil check Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Refactoring to add the rest of the admiral params to the singleton (and to enforce singleton-ness Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Another test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * coverage bump Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Whoops broke a test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Adding warning for config re-initialization Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Fixed rebase-related issues Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Mengying-Li
pushed a commit
that referenced
this pull request
Apr 20, 2020
* formalizing the behavior to fall back to annotation if label isn't present Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Removing the hardcoded references to a default identity label Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Nil check Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Refactoring to add the rest of the admiral params to the singleton (and to enforce singleton-ness Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Another test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * coverage bump Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Whoops broke a test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Adding warning for config re-initialization Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Fixed rebase-related issues Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
Co-authored-by: root <root@test-q0rrm-3tns9>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-openeing this PR