Fix local SE generation. Fix related bugs. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
This reverts commit a9fa409.
josephpeacock
approved these changes
Jan 22, 2020
| @@ -66,6 +64,18 @@ func GetCname(deployment *k8sAppsV1.Deployment, identifier string, nameSuffix st | |||
| return environment + Sep + alias + Sep + nameSuffix | |||
| } | |||
|
|
|||
| func GetEnv(deployment *k8sAppsV1.Deployment) string { | |||
| var environment = deployment.Spec.Template.Labels[Env] | |||
There was a problem hiding this comment.
Do we want to also check annotations before falling back on ns splitting?
There was a problem hiding this comment.
Done. Good suggestion, keeping it consistent with identifier. At some point we will move to selector which will be based of labels, so we should still encourage labels over annotations.
Mengying-Li
pushed a commit
that referenced
this pull request
Apr 20, 2020
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.