Added secret update function #55

gaopan233 · 2020-01-13T19:09:56Z

Added secret update function
Modified logic when secret exists: secrets will always be reloaded

Added process logic for secret update Signed-off-by: Gao Pan <gao_pan@intuit.com>

admiral/pkg/controller/secret/secretcontroller.go

… for review, fixed some typos and 404 link for helm install

* Tests for creating controllers Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Additional pod test - found/fixed a bug Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * One more test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Madeline <madeline_li@intuit.com>

Added process logic for secret update Signed-off-by: Gao Pan <gao_pan@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Madeline <madeline_li@intuit.com>

Fixes #56 Fixes #53 Signed-off-by: Madeline <madeline_li@intuit.com>

Fixes #28 Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Madeline <madeline_li@intuit.com>

* Fixing rbac issues reported in #64 Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * improving logging for SE address generation Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

#68) * formalizing the behavior to fall back to annotation if label isn't present Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Removing the hardcoded references to a default identity label Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Nil check Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Refactoring to add the rest of the admiral params to the singleton (and to enforce singleton-ness Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Another test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * coverage bump Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Whoops broke a test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

* Bootstrapping admiral * Add circle ci config * Fix the working directory for builds * Bootstrapping admiral Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add circle ci config Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Fix the working directory for builds Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add build status badge. Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Revert "Add build status badge." This reverts commit a9fa409. * Publish images: i) latest from master, ii) TAG if its set and iii) commit sha if neither i) or ii) * Revert "Formalizing the behavior to fall back to annotation if label isn't pr… (#68)" This reverts commit 802de17. Signed-off-by: Madeline <madeline_li@intuit.com>

* Overriding defaults for basic example Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

* Bootstrapping admiral * Add circle ci config * Fix the working directory for builds * Bootstrapping admiral Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add circle ci config Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Fix the working directory for builds Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add build status badge. Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Revert "Add build status badge." This reverts commit a9fa409. * Working version after major refactor. * Fix test files. * Use global traffic policy to update destination rule. * Minor fixes. * Update image for admiral * Add outlier detection for locality load balancing to work * Undo tag change * Sample files for demo * Remove/comment some tests * Add the needed method * Commenting out few more tests. * Remove unwanted files. * Adding back missing tests. * Create an alias for logrus. * Fixing tests. Signed-off-by: Madeline <madeline_li@intuit.com>

* formalizing the behavior to fall back to annotation if label isn't present Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Removing the hardcoded references to a default identity label Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Nil check Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Refactoring to add the rest of the admiral params to the singleton (and to enforce singleton-ness Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Another test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * coverage bump Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Whoops broke a test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Adding warning for config re-initialization Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Fixed rebase-related issues Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Martin Baillie <martin@baillie.email> Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Madeline <madeline_li@intuit.com>

* Update sidecar resource in workload namespace Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com> * Updating review comments Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com> * Adding tests for sidecar update code Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com> * updating tests for sidecar update code Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com> Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com> Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Fixes #87 Signed-off-by: Madeline <madeline_li@intuit.com>

* Added tests for destination rule creation Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Uncommented/fixed a bunch of SE tests Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Uncommented/fixed more se tests Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Co-authored-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Madeline <madeline_li@intuit.com>

… for review, fixed some typos and 404 link for helm install Signed-off-by: Madeline <madeline_li@intuit.com>

* finished first draft for recognizing admiral ignore annotation, ready for review, fixed some typos and 404 link for helm install Signed-off-by: Madeline <madeline_li@intuit.com> * added new fake client to pass CI Signed-off-by: Madeline <madeline_li@intuit.com> * added two tests for testing new annotation restriction Signed-off-by: Madeline <madeline_li@intuit.com> Co-authored-by: Madeline <madeline_li@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

…rvice instance (#91) * Route traffic to cluster local service instance from ingress-gateway * Override kustomize admiral image tag for releases with the release tag * Minor documentation edits Fixes #90 Fixes #62 Fixes #39 Signed-off-by: Madeline <madeline_li@intuit.com>

Signed-off-by: Madeline <madeline_li@intuit.com>

codecov-io · 2020-04-20T23:54:00Z

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   69.86%   69.86%           
=======================================
  Files          23       23           
  Lines        1782     1782           
=======================================
  Hits         1245     1245           
  Misses        434      434           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e007e...a1e007e. Read the comment docs.

Signed-off-by: Madeline <madeline_li@intuit.com>

…SH-376

Signed-off-by: Madeline <madeline_li@intuit.com>

…SH-376

aattuluri

LGTM. One minor comment.

aattuluri · 2020-04-21T16:55:18Z

admiral/pkg/controller/secret/secretcontroller.go

@@ -139,6 +145,13 @@ func NewController(
 				queue.Add(key)
 			}
 		},
+		UpdateFunc: func(oldObj interface{}, newObj interface{}) {
+			key, err := cache.MetaNamespaceKeyFunc(newObj)
+			log.Infof("Processing update: %s", key)


Change the log line to "Processing secret update for cluster: %s" for better readability.

Signed-off-by: sa <sushanth_a@intuit.com>

MESH-000 Upgrade argo rollouts version

gaopan233 requested review from aattuluri and josephpeacock January 13, 2020 19:09

gaopan233 self-assigned this Jan 13, 2020

Added secret update function

91243aa

Added process logic for secret update Signed-off-by: Gao Pan <gao_pan@intuit.com>

gaopan233 force-pushed the MESH-376 branch from fd1a48c to 91243aa Compare January 13, 2020 19:11

aattuluri requested changes Jan 15, 2020

View reviewed changes

admiral/pkg/controller/secret/secretcontroller.go Outdated Show resolved Hide resolved

Mengying-intuit and others added 24 commits April 14, 2020 14:38

finished first draft for recognizing admiral ignore annotation, ready…

af43510

… for review, fixed some typos and 404 link for helm install

Merge branch 'master' of github.com:istio-ecosystem/admiral

a06c1e7

merged master

7c65dfc

changed test

bcf6f84

local test passed, need to double check in cluyster

2e05ff1

finish adding call back function for update

56553a8

Add Istio blog post link for Admiral blog post

4d7e468

Signed-off-by: Madeline <madeline_li@intuit.com>

Added secret update function

9a2d73c

Added process logic for secret update Signed-off-by: Gao Pan <gao_pan@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Add slack channel

25ebf4c

Signed-off-by: Madeline <madeline_li@intuit.com>

Add slack channel (updates)

638bcef

Signed-off-by: Madeline <madeline_li@intuit.com>

Fix local SE generation. Fix related bugs. (#59)

264da18

Fixes #56 Fixes #53 Signed-off-by: Madeline <madeline_li@intuit.com>

Add multicluster example and bug fixes (#54)

af1a953

Fixes #28 Signed-off-by: Madeline <madeline_li@intuit.com>

Fix docker image publish (#61)

935301f

Signed-off-by: Madeline <madeline_li@intuit.com>

Update slack channel

f146041

Signed-off-by: Madeline <madeline_li@intuit.com>

Fix configmap roles (#67)

902768f

* Fixing rbac issues reported in #64 Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * improving logging for SE address generation Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Fix init (#70)

5d47585

* Overriding defaults for basic example Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Stop publishing tags for PRs (#74)

9248d8c

Signed-off-by: Madeline <madeline_li@intuit.com>

Stability fixes (#75)

540ac87

Signed-off-by: Madeline <madeline_li@intuit.com>

Skip service instances that were not matched with deployments (#73)

ee1ccb3

Signed-off-by: Martin Baillie <martin@baillie.email> Signed-off-by: Madeline <madeline_li@intuit.com>

aattuluri and others added 16 commits April 20, 2020 16:46

Rename index.md to Index.md

e2f2918

Signed-off-by: Madeline <madeline_li@intuit.com>

Update Compatibility.md

e96577b

Signed-off-by: Madeline <madeline_li@intuit.com>

Use exportTo field to filter resources for syncing across clusters (#81)

37e3740

Signed-off-by: Madeline <madeline_li@intuit.com>

Fix helm commands for newer versions of helm.

dac2450

Signed-off-by: Madeline <madeline_li@intuit.com>

updating the sidecar controller (#86)

0e70426

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com> Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>

Handle dependency update event, optimize sidecar egress update (#88)

30b245c

Fixes #87 Signed-off-by: Madeline <madeline_li@intuit.com>

Update CONTRIBUTING.md

f2ced63

Signed-off-by: Madeline <madeline_li@intuit.com>

finished first draft for recognizing admiral ignore annotation, ready…

a73acd1

… for review, fixed some typos and 404 link for helm install Signed-off-by: Madeline <madeline_li@intuit.com>

changed test

b521a99

Signed-off-by: Madeline <madeline_li@intuit.com>

local test passed, need to double check in cluyster

6d93dee

Signed-off-by: Madeline <madeline_li@intuit.com>

finish adding call back function for update

c3f534b

Signed-off-by: Madeline <madeline_li@intuit.com>

trying to solve merge conflict during rebase

a1e007e

Mengying-intuit added 4 commits April 20, 2020 17:02

trying to solve merge conflict during rebase

38ec69f

Signed-off-by: Madeline <madeline_li@intuit.com>

Merge branch 'MESH-376' of github.com:istio-ecosystem/admiral into ME…

76d0b2c

…SH-376

finish adding call back function for update

177b5c1

Signed-off-by: Madeline <madeline_li@intuit.com>

Merge branch 'MESH-376' of github.com:istio-ecosystem/admiral into ME…

1eb4d7c

…SH-376

Mengying-Li requested a review from aattuluri April 21, 2020 16:48

aattuluri approved these changes Apr 21, 2020

View reviewed changes

aattuluri added do not merge and removed do not merge labels Apr 21, 2020

aattuluri merged commit 6aa6d69 into master Apr 27, 2020

aattuluri deleted the MESH-376 branch April 27, 2020 17:13

aattuluri assigned Mengying-Li Apr 27, 2020

asushanthk pushed a commit to asushanthk/admiral that referenced this pull request Apr 28, 2020

Added cluster secret update function (istio-ecosystem#55)

df9eca5

Signed-off-by: sa <sushanth_a@intuit.com>

itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022

Merge pull request istio-ecosystem#55 from services-mesh/Rollout-fix

c60fb61

MESH-000 Upgrade argo rollouts version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added secret update function #55

Added secret update function #55

gaopan233 commented Jan 13, 2020

codecov-io commented Apr 20, 2020

aattuluri left a comment

aattuluri Apr 21, 2020

Added secret update function #55

Added secret update function #55

Conversation

gaopan233 commented Jan 13, 2020

codecov-io commented Apr 20, 2020

Codecov Report

aattuluri left a comment

Choose a reason for hiding this comment

aattuluri Apr 21, 2020

Choose a reason for hiding this comment