Tests for creating controllers #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2020 15:50
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
========================================
+ Coverage 53% 61.6% +8.6%
========================================
Files 17 17
Lines 1266 1271 +5
========================================
+ Hits 671 783 +112
+ Misses 534 416 -118
- Partials 61 72 +11
Continue to review full report at Codecov.
|
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
aattuluri
approved these changes
Jan 4, 2020
Mengying-Li
pushed a commit
that referenced
this pull request
Apr 20, 2020
* Tests for creating controllers Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * Additional pod test - found/fixed a bug Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * One more test Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
…llFromArtifactory IBP-10892 Pull Docker Images only from Intuit Docker Artifactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the create___Controller methods for controllers in the pkg/controller/admiral directory
Signed-off-by: Joe Peacock joe_peacock@intuit.com