Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locality lb settings support on destination rules #41

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
d457913
Bootstrapping admiral
aattuluri Sep 19, 2019
7b9a2ff
Add circle ci config
aattuluri Sep 19, 2019
c9e80a5
Fix the working directory for builds
aattuluri Sep 19, 2019
76b9561
Bootstrapping admiral
aattuluri Sep 19, 2019
85aeeaa
Add circle ci config
aattuluri Sep 19, 2019
fe313cc
Fix the working directory for builds
aattuluri Sep 19, 2019
306ad93
Merge branch 'master' of https://github.com/aattuluri/admiral
aattuluri Sep 19, 2019
a9fa409
Add build status badge.
aattuluri Sep 19, 2019
4ae717d
Revert "Add build status badge."
aattuluri Sep 19, 2019
ff09cfb
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 19, 2019
eb51849
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 20, 2019
928c0d2
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 20, 2019
2fb3364
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 23, 2019
ea3ed61
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 23, 2019
15e7845
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 24, 2019
3b34036
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 29, 2019
656bf71
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 29, 2019
0245314
Merge remote-tracking branch 'upstream/master'
aattuluri Sep 29, 2019
111c3de
Merge remote-tracking branch 'upstream/master'
aattuluri Oct 4, 2019
e39651c
Merge remote-tracking branch 'upstream/master'
aattuluri Oct 4, 2019
b280c0b
Merge remote-tracking branch 'upstream/master'
aattuluri Oct 6, 2019
4b74679
Merge remote-tracking branch 'upstream/master'
aattuluri Oct 16, 2019
09b8a5b
Merge remote-tracking branch 'upstream/master'
aattuluri Oct 30, 2019
6546170
Merge remote-tracking branch 'upstream/master'
aattuluri Dec 27, 2019
1b0dfeb
Merge remote-tracking branch 'upstream/master'
aattuluri Jan 2, 2020
5239539
Working version after major refactor.
aattuluri Nov 11, 2019
f9f4be7
Fix test files.
aattuluri Nov 11, 2019
fd8075a
Use global traffic policy to update destination rule.
aattuluri Nov 12, 2019
717a271
Minor fixes.
aattuluri Nov 13, 2019
c1240fc
Update image for admiral
aattuluri Nov 13, 2019
db68448
Add outlier detection for locality load balancing to work
aattuluri Nov 14, 2019
2e94efd
Undo tag change
aattuluri Nov 14, 2019
408c9c8
Sample files for demo
aattuluri Dec 27, 2019
d23cc13
Finally..rebase done
aattuluri Feb 19, 2020
043affa
Remove/comment some tests
aattuluri Feb 19, 2020
6a7b9e4
Add the needed method
aattuluri Feb 19, 2020
b17c8a3
Commenting out few more tests.
aattuluri Feb 21, 2020
59995bd
Remove unwanted files.
aattuluri Feb 24, 2020
92de95f
Adding back missing tests.
aattuluri Feb 25, 2020
7efca96
Create an alias for logrus.
aattuluri Feb 25, 2020
e98821f
Fixing tests.
aattuluri Feb 25, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ PROTOC_ZIP=protoc-$(PROTOC_VER)-osx-x86_64.zip


# ROOT_PACKAGE :: the package (relative to $GOPATH/src) that is the target for code generation
ROOT_PACKAGE=github.com/admiral/admiral
ROOT_PACKAGE=github.com/istio-ecosystem/admiral/admiral
# CUSTOM_RESOURCE_NAME :: the name of the custom resource that we're generating client code for
CUSTOM_RESOURCE_NAME=admiral
# CUSTOM_RESOURCE_VERSION :: the version of the resource
Expand Down Expand Up @@ -66,12 +66,11 @@ api-gen:
go install github.com/golang/protobuf/protoc-gen-go
$(GOCMD) generate ./...
go install k8s.io/code-generator/cmd/deepcopy-gen
$(GOBIN)/deepcopy-gen --input-dirs ./admiral/pkg/apis/admiral/model --bounding-dirs ./admiral/pkg/apis/admiral/model -O zz_generated.deepcopy -o $(GOPATH)/src

crd-gen:
#go get -d -u -fix k8s.io/code-generator
#go get -d -u -fix k8s.io/apimachinery
#go get -d -u -fix k8s.io/gengo
go get -d -u -fix k8s.io/code-generator
go get -d -u -fix k8s.io/apimachinery
go get -d -u -fix k8s.io/gengo
$(GOPATH)/src/k8s.io/code-generator/generate-groups.sh all "$(ROOT_PACKAGE)/pkg/client" "$(ROOT_PACKAGE)/pkg/apis" "$(CUSTOM_RESOURCE_NAME):$(CUSTOM_RESOURCE_VERSION)"

# Cross compilation
Expand Down
7 changes: 2 additions & 5 deletions admiral/cmd/admiral/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"flag"
"fmt"
"github.com/istio-ecosystem/admiral/admiral/pkg/clusters"
"github.com/prometheus/common/log"
"github.com/istio-ecosystem/admiral/admiral/pkg/controller/common"
"istio.io/istio/pkg/log"
"os"
"os/signal"
"syscall"
Expand All @@ -16,7 +16,6 @@ import (
)

var (
loggingOptions = log.DefaultOptions()
ctx, cancel = context.WithCancel(context.Background())
)

Expand All @@ -36,8 +35,7 @@ func GetRootCmd(args []string) *cobra.Command {
if len(args) > 0 {
return fmt.Errorf("%q is an invalid argument", args[0])
}
err := log.Configure(loggingOptions)
return err
return nil
},
Run: func(cmd *cobra.Command, args []string) {
log.Info("Starting Admiral")
Expand Down Expand Up @@ -86,7 +84,6 @@ func GetRootCmd(args []string) *cobra.Command {
"The hostname suffix to customize the cname generated by admiral. Default suffix value will be \"global\"")
rootCmd.PersistentFlags().StringVar(&params.LabelSet.WorkloadIdentityLabel, "workload_identity_label", "identity",
"The workload identity label key, on deployment which holds identity value used to generate cname by admiral. Default label key will be \"identity\"")
loggingOptions.AttachCobraFlags(rootCmd)

return rootCmd
}
Expand Down
21 changes: 12 additions & 9 deletions admiral/pkg/apis/admiral/model/dependency.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion admiral/pkg/apis/admiral/model/dependency.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package admiral.global.v1alpha;
option go_package = "model";

// ```
// apiVersion: admiral.global.traffic/v1alpha
// apiVersion: admiral.io/v1alpha1
// kind: Dependency
// metadata:
// name: my-dependency
Expand Down
53 changes: 30 additions & 23 deletions admiral/pkg/apis/admiral/model/globalrouting.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion admiral/pkg/apis/admiral/model/globalrouting.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ option go_package = "model";


// ```
// apiVersion: navarch.global.traffic/v1alpha
// apiVersion: admiral.io/v1alpha1
// kind: GlobalTrafficPolicy
// metadata:
// name: my-routing
Expand Down
4 changes: 2 additions & 2 deletions admiral/pkg/apis/admiral/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading