Add locality lb settings support on destination rules #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
This reverts commit a9fa409.
aattuluri
force-pushed
the
Add-locality-lb-settings-support-on-destination-rules
branch
from
373c5bc
to
408c9c8
Compare
josephpeacock
suggested changes
Feb 25, 2020
| @@ -19,6 +19,7 @@ import ( | |||
| "errors" | |||
| "fmt" | |||
| "github.com/istio-ecosystem/admiral/admiral/pkg/controller/secret/resolver" | |||
| "github.com/sirupsen/logrus" | |||
There was a problem hiding this comment.
Nothing I think we need to change, but for future reference you can save yourself the trouble of renaming every reference from log -> logrus by importing this as log: log "github.com/sirupsen/logrus"
There was a problem hiding this comment.
Changed this to log.
| @@ -30,7 +30,7 @@ spec: | |||
| - $(secret_resolver) | |||
| - --secret_resolver_config_path | |||
| - /etc/admiral/config.yaml | |||
| image: docker.io/admiralproj/admiral:v0.1-alpha | |||
| image: docker.io/admiralproj/admiral:kubecon | |||
There was a problem hiding this comment.
This should be a version or sha, right?
There was a problem hiding this comment.
Changed it to the current stable release.
| @@ -2,16 +2,12 @@ package clusters | |||
|
|
|||
There was a problem hiding this comment.
Seems like you deleted these tests but moved the methods they are testing - let's make sure they are re-added in the right places
josephpeacock
approved these changes
Feb 25, 2020
josephpeacock
pushed a commit
that referenced
this pull request
Feb 29, 2020
* Bootstrapping admiral * Add circle ci config * Fix the working directory for builds * Bootstrapping admiral Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add circle ci config Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Fix the working directory for builds Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add build status badge. Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Revert "Add build status badge." This reverts commit a9fa409. * Working version after major refactor. * Fix test files. * Use global traffic policy to update destination rule. * Minor fixes. * Update image for admiral * Add outlier detection for locality load balancing to work * Undo tag change * Sample files for demo * Remove/comment some tests * Add the needed method * Commenting out few more tests. * Remove unwanted files. * Adding back missing tests. * Create an alias for logrus. * Fixing tests. Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Mengying-Li
pushed a commit
that referenced
this pull request
Apr 20, 2020
* Bootstrapping admiral * Add circle ci config * Fix the working directory for builds * Bootstrapping admiral Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add circle ci config Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Fix the working directory for builds Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add build status badge. Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Revert "Add build status badge." This reverts commit a9fa409. * Working version after major refactor. * Fix test files. * Use global traffic policy to update destination rule. * Minor fixes. * Update image for admiral * Add outlier detection for locality load balancing to work * Undo tag change * Sample files for demo * Remove/comment some tests * Add the needed method * Commenting out few more tests. * Remove unwanted files. * Adding back missing tests. * Create an alias for logrus. * Fixing tests. Signed-off-by: Madeline <madeline_li@intuit.com>
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.