Import admiral generated hosts on Istio Sidecar egress for dependent workloads #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
This reverts commit a9fa409.
…mmit sha if neither i) or ii)
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
* MESH-1026 - Trigger pipeline * Fix gtp key construction (istio-ecosystem#212) Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a user creates a VirtualService with the admiral generated CNAME in the host, its not imported by dependent workloads if Sidecar resource is present. This change will update Sidecar resource to also import admiral generated CNAME which will allow VirtualService configuration to be applied to dependent workloads istio proxies.