Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with 0 weight locality in destination rule. Fix destination rule backward compatibility with Istio 1.4 #111

Conversation

aattuluri
Copy link
Contributor

Context: #102 (comment)

Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Copy link
Collaborator

@josephpeacock josephpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aattuluri aattuluri merged commit 6143f04 into istio-ecosystem:master May 27, 2020
itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022
* Tune default outlier detection parameters for remote endpoints (istio-ecosystem#207)

* [bug] prevent panic when finding out rollout strategy (istio-ecosystem#210)

* prevent panic when finding out rollout strategy
Co-authored-by: Anubhav Aeron <anubhav_aeron@intuit.com>

* Optimize GlobalTrafficPolicy fetching and endpoint generation time (istio-ecosystem#206)

Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Co-authored-by: Anubhav <anubhavaeron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants