Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Infer ServiceEntry ports from destination service #76

Closed
josephpeacock opened this issue Feb 29, 2020 · 1 comment
Closed

[BUG] Infer ServiceEntry ports from destination service #76

josephpeacock opened this issue Feb 29, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@josephpeacock
Copy link
Collaborator

The serviceEntry should add ports based on those present in the service it will be pointing to. Currently it is hardcoded to default http ports (and named http).

Thanks to Martin Baillie for the report!

for those at Intuit more familiar with the code, I was thinking these lines should not be hardcoded and should instead be inferred from the respective Service ports and port names?
https://github.com/istio-ecosystem/admiral/blob/master/admiral/pkg/clusters/serviceentry.go#L84-L85
since my Service ports are named grpc I am being bitten by: https://istio.io/docs/reference/config/networking/service-entry/#ServiceEntry-Endpoint

@josephpeacock josephpeacock added the bug Something isn't working label Feb 29, 2020
@aattuluri aattuluri added this to the v0.9 milestone Mar 12, 2020
@aattuluri aattuluri modified the milestones: v0.9, v1.0 Apr 6, 2020
@aattuluri aattuluri modified the milestones: v1.0, v1.1 Aug 26, 2020
@aattuluri aattuluri modified the milestones: v1.1, v1.2 Sep 2, 2020
@aattuluri aattuluri modified the milestones: v1.2, v1.1 Nov 3, 2020
@aattuluri
Copy link
Contributor

Fixed with #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants