-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] demo deploy RBAC role is incomplete #64
Comments
@LaysDragon Great feedback, will fix this. |
josephpeacock
pushed a commit
that referenced
this issue
Feb 12, 2020
josephpeacock
pushed a commit
that referenced
this issue
Feb 12, 2020
Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
josephpeacock
added a commit
that referenced
this issue
Feb 12, 2020
* Fixing rbac issues reported in #64 Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * improving logging for SE address generation Signed-off-by: Joe Peacock <joe_peacock@intuit.com>
Having a play with Admiral and hit this using latest. Should these roles and bindings not be in whatever is the sync namespace? |
@martinbaillie Thanks for keeping me honest. We should have been overriding that namespace in Kustomize for the example. I fixed that and validated that the out of the box example starts up. |
Mengying-Li
pushed a commit
that referenced
this issue
Apr 20, 2020
* Fixing rbac issues reported in #64 Signed-off-by: Joe Peacock <joe_peacock@intuit.com> * improving logging for SE address generation Signed-off-by: Joe Peacock <joe_peacock@intuit.com> Signed-off-by: Madeline <madeline_li@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Flow the instruction from README via the admiral-install-v0.1-beta.tar.gz to deploy single cluster demo on kubernetes 1.16.6 and istio 1.4.3(deployed via rancher),the admiral will keep report about the error.
Steps To Reproduce
Simply flow instruction in README
Expected behavior
Admiral should success generate ServiceEntry.
Note
I fix it via add RBAC role myself,not sure what is the best practice to set it so I give admiral full permission to configmaps in admiral-sync.
This problem might come from this PR which lost the RBAC part
#42
and here is another problem here
admiral/admiral/pkg/clusters/serviceentry.go
Lines 47 to 50 in 7b4e5fd
It ignore the source err and only report cannot not get unique address,and make it harder to find out what happen. It should log the source error to point out the real problem.
The text was updated successfully, but these errors were encountered: