diff --git a/admiral/pkg/controller/admiral/configmap_test.go b/admiral/pkg/controller/admiral/configmap_test.go index b10fb141..5d2d5ca2 100644 --- a/admiral/pkg/controller/admiral/configmap_test.go +++ b/admiral/pkg/controller/admiral/configmap_test.go @@ -29,7 +29,7 @@ func init() { p.LabelSet.WorkloadIdentityKey = "identity" p.LabelSet.GlobalTrafficDeploymentLabel = "identity" - //p.LabelSet.EnvKey = "admiral.io/env" + p.LabelSet.EnvKey = "admiral.io/env" common.InitializeConfig(p) } diff --git a/admiral/pkg/controller/admiral/globaltraffic_test.go b/admiral/pkg/controller/admiral/globaltraffic_test.go index b3b3b5e0..3380e21d 100644 --- a/admiral/pkg/controller/admiral/globaltraffic_test.go +++ b/admiral/pkg/controller/admiral/globaltraffic_test.go @@ -207,28 +207,28 @@ func TestGlobalTrafficController_Added(t *testing.T) { }{ { name: "Gtp should be added to the cache", - gtpKey: "default.id", + gtpKey: "stage.id", namespace: "namespace1", gtp: []*v1.GlobalTrafficPolicy{>p}, expectedGtps: []*v1.GlobalTrafficPolicy{>p}, }, { name: "Gtp with ignore annotation should not be added to the cache", - gtpKey: "default.id2", + gtpKey: "stage.id2", namespace: "namespace2", gtp: []*v1.GlobalTrafficPolicy{>pWithIgnoreLabels}, expectedGtps: []*v1.GlobalTrafficPolicy{}, }, { name: "Should cache multiple gtps in a namespace", - gtpKey: "default.id", + gtpKey: "stage.id", namespace: "namespace1", gtp: []*v1.GlobalTrafficPolicy{>p, >p2}, expectedGtps: []*v1.GlobalTrafficPolicy{>p, >p2}, }, { name: "Should cache gtps in from multiple namespaces", - gtpKey: "default.id", + gtpKey: "stage.id", namespace: "namespace3", gtp: []*v1.GlobalTrafficPolicy{>p, >p3}, expectedGtps: []*v1.GlobalTrafficPolicy{>p3}, diff --git a/admiral/pkg/controller/admiral/rollouts.go b/admiral/pkg/controller/admiral/rollouts.go index d57b7a2d..ca927270 100644 --- a/admiral/pkg/controller/admiral/rollouts.go +++ b/admiral/pkg/controller/admiral/rollouts.go @@ -101,18 +101,6 @@ func (p *rolloutCache) DeleteFromRolloutToClusterCache(key string, rollout *argo } func (d *RolloutController) shouldIgnoreBasedOnLabelsForRollout(rollout *argo.Rollout) bool { - if rollout == nil { - log.Warn("rollout is nil") - return true - } - if rollout.Spec.Template.Labels == nil { - log.Warnf("rollout labels is nil %s", rollout.Namespace) - return true - } - if d.labelSet == nil { - log.Warn("labelset is nil") - return true - } if rollout.Spec.Template.Labels[d.labelSet.AdmiralIgnoreLabel] == "true" { //if we should ignore, do that and who cares what else is there return true }