Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency warnings with Rollup #279

Closed
brc-dd opened this issue Jun 17, 2023 · 1 comment
Closed

Circular dependency warnings with Rollup #279

brc-dd opened this issue Jun 17, 2023 · 1 comment

Comments

@brc-dd
Copy link

brc-dd commented Jun 17, 2023

Hi, when trying to bundle rimraf using Rollup or similar tools, there are warnings like these:

(!) Circular dependency
node_modules/.pnpm/rimraf@5.0.1/node_modules/rimraf/dist/mjs/index.js -> node_modules/.pnpm/rimraf@5.0.1/node_modules/rimraf/dist/mjs/opt-arg.js -> node_modules/.pnpm/rimraf@5.0.1/node_modules/rimraf/dist/mjs/index.js

This happens because of these imports (opt-arg imports things from index and index imports opt-args):

rimraf/src/opt-arg.ts

Lines 2 to 7 in bfda548

import {
assertRimrafOptions,
RimrafAsyncOptions,
RimrafOptions,
RimrafSyncOptions,
} from './index.js'

Haven't got any issue with this so far, but I wonder if it would be better to move the common stuff to other file?

@AngeloCore
Copy link

Bump

@isaacs isaacs closed this as completed in 92a4e2c Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants