Disable green merge button for a specific repository

[isaacs]

On joyent/node and isaacs/npm, we have a strict rule about not merging pull requests using the green "merge" button, because it creates excessive merge commits. (See additional discussion in #2.)

But the button is large, and inviting. It'd be nice to conditionally disable it per repository.

[silverjam]

+1 -- We've adopted the same rule on our team

[gnarf]

👍 from jQuery also. https://twitter.com/gnarf/status/378211055932936192

[patcon]

Related: #88 "Allow pull requests to be rebased from the UI"

[jvennix-r7]

👍

[aheckmann]

+1

[tellnes]

👍

[vpv-gd]

👍

[ivantretyakov]

👍

[Rorick]

👍

[iaon]

+1

[akatyshev]

+1

[donavon]

👍 What if we say pretty please?

[patcon]

Definitely overkill, but I wonder if it would be possible to use a service to create a webhook (new webhook implementation WHOOP!) so that whenever a PR is merged, it reverts by updating the head ref. I'm not 100% on git internals and whether this is how head references work. Also not sure how github would treat the PR anyhow

[juliemr]

+1 would also use this

[sfitts]

+1

[btford]

+1

[rodyhaddad]

+1

[petebacondarwin]

+1

[matsko]

+1

[matsko]

That button is pure evil.

[caitp]

(づ￣ ³￣)づ:+1:

[pkozlowski-opensource]

+1 The other alternative is to have a setting per-repository where we could specify that the green-button would be only available for the fast-forward merges and pressing it would not create a merge commit. Still in projects with high traffic PRs fast-forward merges are rare...

[jimconner]

I just trained Adblock that the 'Confirm & Merge' button should not be displayed - This nicely solves the problem for me and stops me accidentally clicking it... and I can always disable adblock if I want the merge button to return - Hope this idea comes in useful to others.

[DVGeoffrey]

Almost the 3rd anniversary of this issue. +1!!!!!

[onlyhavecans]

+1

[tagrudev]

+1

[shahp00ja]

+1 we do want it to have a hook kind of mechanism which can be switched on/off on demand to say enable or disable as per need.
Use Case 1: PR should be able to be merged only if the commit changes are approved which means dev peer review is done and its good to be candidate of release
Use Case 2 code-freeze for release testing is important and so we want to disable the Merge button for a particular repository -> particular branch let say master for certain period (off-course- few folks only should be able to do it may be by disabling the hook)
It looks doable using Status API but looking for a more straight forward solution

[davesmith00000]

+!

[btcdrak]

+1

[kilpatrick]

👍

[pancetta]

+1

[p00j4]

Its easily doable now. Here is the solution
With latest release of github, it works out of the box now for this case

[rayalan]

+1

[JakeShirley]

+1 we strictly use a rebase work flow with out any merge nodes, so this would be great

[jfirebaugh]

For those that are +1'ing the issue and may not have seen this, the "Options" page in repository settings now has the following options:

I believe disallowing merge commits in favor of rebasing and fast-forward merges was the original reason for opening this issue, and it can be closed now that that's possible.

[purpleidea]

@jfirebaugh While this is great, it won't let you "uncheck" all three boxes, which would be great for preventing "yolo-style" click merging, and instead getting users to actually use the cli and/or test the patch themselves first :)

[Frikki]

Amazing this cannot be disabled completely!

[Tremelune]

Still an issue. I very much want to prevent anyone from using GitHub to merge, ever.

[sahellebusch]

Is this ever going to be addressed? Or should I start writing a chrome extension to remove it?

[MarkSRobinson]

I've found one way to remove the green merge button.

I've setup Bors-NG as a commit queue. I then set the bors merge job as required/blocking in the Github config. The job doesn't run until a user types bors r+ and in the mean time they cannot use the green merge button because a required build is missing.

It works quite well to prevent people from hitting the big green button

[vdh]

This wouldn't be a problem if GitHub didn't hardcode --no-ff into this button's default behaviour. If the --no-ff flag had an opt-out option in the repo settings, then at least the button would fast forward when a new commit isn't required, just like the default Git merge behaviour.

[martin-morin]

For our team, we would need to disable the merge button. Here is our process:

1. Get the pull request approved
2. Run the pull request on the build server for all sort of verifications (The goal is to maintain the production branch in a perfect state, without any issues)
3. If the build server passes all the verifications, it triggers the merge to the production branch