diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index 68fdb14da0cbfb..14216ac627938b 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java @@ -332,7 +332,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl @Option( name = "incompatible_string_join_requires_strings", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS}, metadataTags = { diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java index 9114c0a9eb9b97..22ce113f2dac15 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java @@ -248,7 +248,7 @@ public static Builder builderWithDefaults() { .incompatibleRemoveNativeMavenJar(false) .incompatibleRestrictNamedParams(false) .incompatibleStaticNameResolutionInBuildFiles(true) - .incompatibleStringJoinRequiresStrings(false) + .incompatibleStringJoinRequiresStrings(true) .internalSkylarkFlagTestCanary(false) .incompatibleDoNotSplitLinkingCmdline(false) .incompatibleDepsetForLibrariesToLinkGetter(false) diff --git a/tools/python/srcs_version.bzl b/tools/python/srcs_version.bzl index 53fce79fa13910..32e61b7332910f 100644 --- a/tools/python/srcs_version.bzl +++ b/tools/python/srcs_version.bzl @@ -82,10 +82,10 @@ root. Paths are represented as depsets with `preorder` order. ) def _join_lines(nodes): - return "\n".join(nodes) if nodes else "" + return "\n".join([str(n) for n in nodes]) if nodes else "" def _str_path(path): - return " -> ".join(path.to_list()) + return " -> ".join([str(p) for p in path.to_list()]) def _str_tv_info(tv_info): """Returns a string representation of a `_TransitiveVersionInfo`."""