Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

fix: pass serialized blob to util.cid #16

Merged
merged 2 commits into from
Jun 26, 2018
Merged

fix: pass serialized blob to util.cid #16

merged 2 commits into from
Jun 26, 2018

Conversation

richardschneider
Copy link
Contributor

BREAKING CHANGE: the first argument is now the serialized output NOT the dag node.
See ipld/interface-ipld-format#32

BREAKING CHANGE: the first argument is now the serialized output NOT the dag node.
See ipld/interface-ipld-format#32
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things on the JSDocs, doesn't block merging. Hence approving this change.

src/util.js Outdated
@@ -77,20 +78,20 @@ exports.deserialize = (data, callback) => {
/**
* Get the CID of the DAG-Node.
*
* @param {Object} dagNode - Internal representation
* @param {Buffer} blob - Serialized binary data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps: Git object.

src/util.js Outdated
@@ -77,20 +78,20 @@ exports.deserialize = (data, callback) => {
/**
* Get the CID of the DAG-Node.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps changing to Get the CID of the Git object?

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash merge.

@vmx
Copy link
Member

vmx commented Jun 26, 2018

@richardschneider Feel free to ignore the failure on Travis.

@richardschneider richardschneider merged commit d8f8687 into master Jun 26, 2018
@richardschneider richardschneider removed the status/in-progress In progress label Jun 26, 2018
@richardschneider richardschneider deleted the cid-blob branch June 26, 2018 10:12
richardschneider added a commit that referenced this pull request Jun 27, 2018
richardschneider added a commit that referenced this pull request Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants