Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/ipns/ paths trigger false-positive DNSLink lookup #266

Closed
lidel opened this issue May 21, 2024 · 3 comments · Fixed by ipfs/helia-verified-fetch#85
Closed

/ipns/ paths trigger false-positive DNSLink lookup #266

lidel opened this issue May 21, 2024 · 3 comments · Fixed by ipfs/helia-verified-fetch#85
Labels
bug Something isn't working
Milestone

Comments

@lidel
Copy link
Member

lidel commented May 21, 2024

Example: https://specs-ipfs-tech.ipns.inbrowser.dev/ipns/ipns-record/

The /ipns/ makes verified-fetch attempt to do DNSLink lookup for ipns-record hostname.

This should not happen because we are already on subdomain gateway.

@lidel lidel added the bug Something isn't working label May 21, 2024
@lidel lidel added this to the Beta milestone May 21, 2024
@lidel
Copy link
Member Author

lidel commented May 21, 2024

Early idea: service-worker-gateway should pass the original URL to verified-fetch('https://specs-ipfs-tech.ipns.inbrowser.dev/ipns/ipns-record/') so it has all information to make the right decision. Ir follows our design of shifting all conformance work to verified-fetch, when possible.

Once verified-fetch knows it is subdomain URL request, it will be able to not trigger /ipns/{id} resolution because it will know the content path is /ipns/specs.ipfs.tech/ipns/ipns-record/

@2color @SgtPooki thoughts?

@SgtPooki
Copy link
Member

@lidel yep, we should pass everything to verified-fetch and I believe we already are. However, there are some "gateway" things happening at sw level in order to receive/route requests.. we need to make sure it's not getting in the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants