Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Interop requirement - spdy / http2 #16

Closed
daviddias opened this issue Jun 11, 2015 · 5 comments
Closed

Interop requirement - spdy / http2 #16

daviddias opened this issue Jun 11, 2015 · 5 comments
Labels
topic/libp2p Topic libp2p

Comments

@daviddias
Copy link
Member

Opening this discussion on a issue, so that we have a log, as it has been a recurring topic for a while now :)

For interop purposes between implementations, it has been discussed several times to replace yamux for spdy, so other implementations can have access to a standard stream multiplexing library. However, most implementations for spdy or http2 are not there yet and pretty much every single one of them doesn't offer a streamable io interface, with the exception of spdystream by Docker, however, @whyrusleeping and @jbenet found some deadlock scenarios that still need to be solved/merged by the Docker team.

So, I guess we have to figure out if http2/spdy is the way and if so, will we invest resources on making our own implementation/supporting a current open source one?

@whyrusleeping
Copy link
Member

does the spdystream implementation by docker even interop correctly with one of the node implementations? I feel like that would be a good thing to test before we go much farther down that road.

@daviddias
Copy link
Member Author

For logging purposes:

It was discussed and reviewed again and spdy will be it :)

As for the spdystream implementation in Node.js, had a quick chat today with Indutny on IRC:

13:59 <daviddias> hey indutny , how is it going ? 
13:59 <indutny> good good
13:59 <indutny> how are you?
14:00 <daviddias> doing good, thank you. Still on the track of making spdystream
14:01 <indutny> yeah
14:01 <indutny> I think node-spdy will give you the primitives
14:02 <indutny> just wait a bit :)
14:05 <daviddias> definitely, that was where I started. But there were some bits I didn't understand completely, so I started hacking from scratch spdy to make sure I understood all of the nuances, but hell, so there is so many bits to it. You did an awesome job on node-spdy
14:06 <indutny> heh
14:06 <indutny> daviddias: node-spdy is going to become much better now
14:13 <daviddias> indutny nice! So what is missing? I happy to help :) 
14:14 <indutny> daviddias: lots of stuff, but I am still in the process of reshuffling code
14:14 <indutny> not sure if any help is possible atm
14:14 <indutny> but thank you!

The refactor should take about 2 weeks (ref: spdy-http2/node-spdy#208)

@daviddias
Copy link
Member Author

We have it now :)

@CMCDragonkai
Copy link

Which version of SPDY is ipfs using? The wikipedia says that the latest version is version 4.0.

@daviddias
Copy link
Member Author

We use 3.1

@daviddias daviddias added the topic/libp2p Topic libp2p label Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/libp2p Topic libp2p
Projects
None yet
Development

No branches or pull requests

3 participants