-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sharness - t0118 is broken - response for application/vnd.ipld.car SHOULD NOT include Content-Length #9651
Closed
3 tasks done
Labels
kind/bug
A bug in existing code (including security flaws)
need/triage
Needs initial labeling and prioritization
Comments
laurentsenta
added
kind/bug
A bug in existing code (including security flaws)
need/triage
Needs initial labeling and prioritization
labels
Feb 16, 2023
12 tasks
Thanks for catching this 👍
ps. I wonder if the same thing happens for TAR response? |
This will get handled by ipfs/boxo#177 which is blocked. |
4 tasks
5 tasks
Discussion also happening in ipfs/gateway-conformance#64 |
I believe this got resolved and can be closed:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
A bug in existing code (including security flaws)
need/triage
Needs initial labeling and prioritization
Checklist
Installation method
ipfs-update or dist.ipfs.tech
Version
Config
No response
Description
In sharness t0118 it seems that the test is misusing the invert option in grep:
kubo/test/sharness/t0118-gateway-car.sh
Lines 93 to 96 in ed4d6b7
The comment says that we should NOT return a
Content-Length
, but we do:(tested with Kubo and a car gateway from go-libipfs)
Changing the test to :
! grep "< Content-Length:" curl_output
reveals the error.I found a few other cases where we use
grep -v
and that might have a similar issue:The text was updated successfully, but these errors were encountered: