Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ipfs repo ls alias for ipfs refs local #9205

Closed
3 tasks done
Winterhuman opened this issue Aug 17, 2022 · 9 comments
Closed
3 tasks done

Create ipfs repo ls alias for ipfs refs local #9205

Winterhuman opened this issue Aug 17, 2022 · 9 comments
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@Winterhuman
Copy link
Contributor

Winterhuman commented Aug 17, 2022

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

Users wanting to list all objects in their repo need to run ipfs refs local, however, most users look under ipfs repo because of it's name; ipfs refs isn't intuitively located. Additionally, ipfs refs only has one subcommand which doesn't feel necessary.

So, I've opened this issue to discuss. I propose ipfs repo refs, with ipfs refs local becoming ipfs repo refs -l/--local.

@Winterhuman Winterhuman added the kind/enhancement A net-new feature or improvement to an existing feature label Aug 17, 2022
@Jorropo
Copy link
Contributor

Jorropo commented Aug 17, 2022

I am not in favor of moving all of ipfs refs, just ipfs refs local => ipfs repo ls.

@Winterhuman
Copy link
Contributor Author

That could work as well, an alias would be a lot easier than removing ipfs refs (and it would be more backwards compatible as well)

@Winterhuman Winterhuman changed the title Merge ipfs refs under ipfs repo Create ipfs repo ls alias for ipfs refs local Aug 25, 2022
@Winterhuman
Copy link
Contributor Author

After looking at ipfs refs's functionality closer, moving the whole thing under ipfs repo would make no sense. I think Jorropo's idea is the best moving forward

@BigLep
Copy link
Contributor

BigLep commented Aug 26, 2022

2022-08-26 triage conversation: add an alias from ipfs repo lsipfs refs local.

@BigLep BigLep added this to the Best Effort Track milestone Aug 26, 2022
@BigLep BigLep added exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors labels Aug 26, 2022
@BigLep
Copy link
Contributor

BigLep commented Aug 26, 2022

@Winterhuman : do you want to take this one?

@BigLep BigLep added the P3 Low: Not priority right now label Aug 26, 2022
@Winterhuman
Copy link
Contributor Author

@BigLep I wouldn't have a clue unfortunately

@Zanda256
Copy link

Zanda256 commented Sep 7, 2022

@BigLep I'm giving it a try. I'll ping you for review of my pr.

@susarlanikhilesh
Copy link
Contributor

susarlanikhilesh commented Oct 1, 2022

@BigLep @Jorropo #9320
Do you think this is good enough for the alias?
Or am I breaking any code rules?

Thank you

@Winterhuman
Copy link
Contributor Author

#9320 is now merged, closing issue. Thanks @susarlanikhilesh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

5 participants