Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart Block-put for multiple block injection #6315

Closed
hsanjuan opened this issue May 9, 2019 · 2 comments
Closed

Multipart Block-put for multiple block injection #6315

hsanjuan opened this issue May 9, 2019 · 2 comments
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@hsanjuan
Copy link
Contributor

hsanjuan commented May 9, 2019

Version information: master

Type: enhancement

Description:

I would like to have a "streaming" block-put where I can send many blocks on a single request to the block/put http endpoint. I don't think this works right now (correct me if I missed it).

Ideally the happy path is to translate this into a nicely buffered and optimized PutMany() so that, when ingesting many blocks via the API, there is a significant performance gain vs injecting one by one.

@hsanjuan hsanjuan self-assigned this May 9, 2019
@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label May 9, 2019
@Stebalien
Copy link
Member

I agree. We'll have to make sure to use EmitOnce when only putting one block for compatibility with js-ipfs but that's not that bad.

The only interesting thing here is that the current block API in the core API doesn't support batch put. See: ipfs/interface-go-ipfs-core#31.

@magik6k
Copy link
Member

magik6k commented May 31, 2019

#6331

@magik6k magik6k closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants