Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker tests in CI #6101

Closed
Stebalien opened this issue Mar 19, 2019 · 3 comments · Fixed by #8808
Closed

Docker tests in CI #6101

Stebalien opened this issue Mar 19, 2019 · 3 comments · Fixed by #8808
Assignees

Comments

@Stebalien
Copy link
Member

Since the transition to CircleCI, we've lost our docker tests. We should enable them in CircleCI (not sure if we can just flip a switch or something...).

@Stebalien
Copy link
Member Author

@lanzafame (or @mburns?) would one of you have time to get docker image testing working in CircleCI? We can either use our docker sharness tests or do something custom.

@Stebalien
Copy link
Member Author

We'll need to take a look at https://circleci.com/docs/2.0/building-docker-images/ and adapt the tests for this.

  1. We can't mount in CircleCI.
  2. Only docker containers can talk to each other.

@Stebalien
Copy link
Member Author

We'll need to modify:

  • test/sharness/t0301-docker-migrate.sh
    • We can't mount. We'll need to create a dummy container as described in https://circleci.com/docs/2.0/building-docker-images/.
    • The docker container can't talk to network services running inside the test. Specifically, it can't talk to socat. We'll want to run a special socat container (alpine/socat?) to serve the fake HTTP response.
  • .circleci/config.yml
    • We'll need to modify the sharness job's steps to invoke setup_remote_docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants