Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Grand NoCopy Bug #5924

Closed
DonaldTsang opened this issue Jan 14, 2019 · 4 comments
Closed

The Grand NoCopy Bug #5924

DonaldTsang opened this issue Jan 14, 2019 · 4 comments
Labels
topic/meta Topic meta

Comments

@DonaldTsang
Copy link

DonaldTsang commented Jan 14, 2019

Main issue: #4558 ("nocopy" option for "add" method doesn't work in a HTTP API call)
Secondary issue: #4224 (nocopy option doesnt work without moving files (defeating part of the purpose))
Third issue: #5815 (Recursive add of large directory fails at 100% (with nocopy and fscache))
Fourth issue: #4318 (nocopy adds files with different hashes than without nocopy)

Software that uses NoCopy (that I am aware of):

Software that could use NoCopy:

An odd solution referenced by a random forum:

you need to pass the Abspath header with the full file path, in the http multipart headers
AND you need to have the mime type set as
application/octet-stream or whatever
for other more specific mime types it wouldnt work even with the Abspath header
[application] does the right thing and passes the real mime type
which caused the problems
yea it was application/octet-stream thats the one that works
none of this is documented anywhere of course
so even though they provide the nocopy option, they dont tell you how to use it
and that guy that opened the original github issue which you linked to had run into this same problem

Now all we need to do is to reproduce the bug

@magik6k magik6k added the topic/meta Topic meta label Jan 14, 2019
@magik6k magik6k changed the title META: The Grand NoCopy Bug The Grand NoCopy Bug Jan 14, 2019
@eingenito
Copy link
Contributor

@DonaldTsang - Thanks for creating this meta issue. Upon further reading I'm not sure these issues are actually closely related.

#4558 is a documentation (?) issue I guess and I think @magik6k explains why it exists and how to get the desired behavior here: #4558 (comment)

#4224 is a feature request of sorts - although not super clear. There is a potential solution using symlinks, but it doesn't suit everyone's use case.

#4318 is also I guess a documentation issue? The reason for this behavior is summarized here: #4318 (comment) and is discussed more in the issue.

#5184 looks like a bug straight up.

What is the problem that you are running into specifically? Is it #5184? The others are behaviors that are unlikely to change, although we could document them better. I'm tempted to close them and open up a separate issue that just covers documentation of that behavior.

@DonaldTsang
Copy link
Author

@eingenito the main issues are #4224 and #4558 in my case for Hydrus, which I hope there should be more documentation and research on the matter.

@radfish
Copy link

radfish commented Feb 12, 2019

#5987 : server does not report error if path is invalid

#5988 : add --nocopy does not always add files to filestore. It doesn't add to filestore if blocks exist in blockstore. This leaves the user with duplicated data: in original filesystem files AND in blockstore, despite having used --nocopy.

@Stebalien
Copy link
Member

I've created an issue to specifically track what needs to land for this feature to stabilize: #7161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/meta Topic meta
Projects
None yet
Development

No branches or pull requests

5 participants