Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print dial status messages to stderr #4355

Open
Stebalien opened this issue Oct 30, 2017 · 2 comments
Open

Print dial status messages to stderr #4355

Stebalien opened this issue Oct 30, 2017 · 2 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature topic/commands Topic commands

Comments

@Stebalien
Copy link
Member

Currently, it can be a bit difficult to debug dial errors because:

  1. We only print the last error.
  2. We don't clearly state what addresses we're trying to dial.

Printing something like,

error: ...
error: ...
dialing [3/N]: /ip4/STUFF...

would make this significantly easier to debug.

see #3933

@Stebalien Stebalien added topic/commands Topic commands kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Oct 30, 2017
@reinerRubin
Copy link
Contributor

reinerRubin commented Mar 25, 2019

@Stebalien, I am going to try this one.

As I understand, if we want more informative final "failed to bootstrap" err, the bootstrap errs should not be just reduced to the last.

https://github.com/ipfs/go-ipfs/blob/8c96e3be90ac5ed4b34bb765833486f6b7816eaa/core/bootstrap.go#L196

upd
Yeah, it is more about go-libp2p-swarm/swarm_dial.go. Probably I'll do PR to that repo.

@Stebalien
Copy link
Member Author

We now return all (or most) errors when we fail. However, we don't print dial progress. Ideally, we'd pass some kind of status channel through with the context. Alternatively, we could implement this once we have a proper event system in libp2p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature topic/commands Topic commands
Projects
None yet
Development

No branches or pull requests

2 participants