Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odd gc test failure #3970

Open
whyrusleeping opened this issue Jun 11, 2017 · 1 comment
Open

odd gc test failure #3970

whyrusleeping opened this issue Jun 11, 2017 · 1 comment
Labels
topic/test failure Topic test failure

Comments

@whyrusleeping
Copy link
Member

Test failure in jenkins:

--- FAIL: TestAddGCLive (0.01s)
	add_test.go:113: gc shouldnt have started yet
FAIL
FAIL	github.com/ipfs/go-ipfs/core/coreunix	0.393s
@whyrusleeping whyrusleeping added the topic/test failure Topic test failure label Jun 11, 2017
@Stebalien
Copy link
Member

That's a bug in the test. Add now pauses for GC occasionally if it's waiting to run. The fact that we weren't reliably failing this test indicates that the test never really worked correctly.

I believe the correct fix is to simply remove the "gc started" check.

@Stebalien Stebalien mentioned this issue Jan 30, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/test failure Topic test failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @whyrusleeping