Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merkledag: CumulativeSize on directories overflows #3440

Open
mateon1 opened this issue Nov 29, 2016 · 4 comments
Open

merkledag: CumulativeSize on directories overflows #3440

mateon1 opened this issue Nov 29, 2016 · 4 comments
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog

Comments

@mateon1
Copy link
Contributor

mateon1 commented Nov 29, 2016

Version information: 0.4.5

Type: bug

Priority: P4

Description:

CumulativeSize of a directory (or file) can reach ~16 EB maximum, after which it wraps around to 0B.
An example showing this overflow:
QmW4Zd911qv7uaRM2vi79YsfHvZ93skxiCxLnwpgpf7hp3
The directory looks like 11GB, but contains a lot of 'large' folders (like a zip bomb) + a data folder (here, the npm repo) of 723 GB.
Here's the folder bomb used.

@whyrusleeping whyrusleeping added the status/ready Ready to be worked label Nov 29, 2016
@mib-kd743naq
Copy link
Contributor

This might be a separate ticket, but the npm subfolder in the example does not open on ipfs.io:
https://ipfs.io/ipfs/QmW4Zd911qv7uaRM2vi79YsfHvZ93skxiCxLnwpgpf7hp3/overflowdemo/npm

@Kubuxu
Copy link
Member

Kubuxu commented Nov 29, 2016

@mib-kd743naq I think this directory contains data in new sharding format, #3042

@whyrusleeping
Copy link
Member

people are using that in the wild already? i havent merged it.... o.o

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Dec 1, 2016
@Kubuxu Kubuxu mentioned this issue Dec 12, 2016
2 tasks
@dignifiedquire
Copy link
Member

@Kubuxu @whyrusleeping this is not related to sharding code, tested with 0.4.5-pre which does not contain #3042 and seeing the same issue when running with ipfs-whatever and ipfs object stat on the root hash of the graph generated.

ipfs object stat QmWra8edcqDmHi5TEdM3MW1GTXmpqam4bdXDW13XxxzHtA
NumLinks: 10
BlockSize: 524
LinksSize: 522
DataSize: 2
CumulativeSize: -806169813684932772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

No branches or pull requests

6 participants