From 88646e13ed02bd7e886da5eee0437b5b3290012d Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 7 Dec 2018 09:34:13 +0000
Subject: [PATCH 01/41] chore: update dependencies

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package.json b/package.json
index d1f51beaab..43f381120e 100644
--- a/package.json
+++ b/package.json
@@ -131,7 +131,7 @@
     "libp2p": "~0.24.1",
     "libp2p-bootstrap": "~0.9.3",
     "libp2p-crypto": "~0.14.1",
-    "libp2p-kad-dht": "~0.12.1",
+    "libp2p-kad-dht": "~0.13.0",
     "libp2p-keychain": "~0.3.3",
     "libp2p-mdns": "~0.12.0",
     "libp2p-mplex": "~0.8.4",
@@ -145,7 +145,7 @@
     "mafmt": "^6.0.2",
     "mime-types": "^2.1.21",
     "mkdirp": "~0.5.1",
-    "multiaddr": "^6.0.0",
+    "multiaddr": "~6.0.0",
     "multiaddr-to-uri": "^4.0.0",
     "multibase": "~0.6.0",
     "multihashes": "~0.4.14",

From b57865df16c14c255b8d68309b363a747471dcda Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 12 Dec 2018 08:59:44 +0000
Subject: [PATCH 02/41] chore: use hat

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 43f381120e..220b60fa0f 100644
--- a/package.json
+++ b/package.json
@@ -145,7 +145,7 @@
     "mafmt": "^6.0.2",
     "mime-types": "^2.1.21",
     "mkdirp": "~0.5.1",
-    "multiaddr": "~6.0.0",
+    "multiaddr": "^6.0.0",
     "multiaddr-to-uri": "^4.0.0",
     "multibase": "~0.6.0",
     "multihashes": "~0.4.14",

From d7d9f164ba61f538198711921553cc46465aa08b Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 12 Dec 2018 09:00:48 +0000
Subject: [PATCH 03/41] fix: revert kad dep upgrade

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 220b60fa0f..d1f51beaab 100644
--- a/package.json
+++ b/package.json
@@ -131,7 +131,7 @@
     "libp2p": "~0.24.1",
     "libp2p-bootstrap": "~0.9.3",
     "libp2p-crypto": "~0.14.1",
-    "libp2p-kad-dht": "~0.13.0",
+    "libp2p-kad-dht": "~0.12.1",
     "libp2p-keychain": "~0.3.3",
     "libp2p-mdns": "~0.12.0",
     "libp2p-mplex": "~0.8.4",

From 0d9cfe4dd6d74a382084428a1614d5fdcc6678db Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 7 Dec 2018 09:34:13 +0000
Subject: [PATCH 04/41] chore: update dependencies

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package.json b/package.json
index d1f51beaab..43f381120e 100644
--- a/package.json
+++ b/package.json
@@ -131,7 +131,7 @@
     "libp2p": "~0.24.1",
     "libp2p-bootstrap": "~0.9.3",
     "libp2p-crypto": "~0.14.1",
-    "libp2p-kad-dht": "~0.12.1",
+    "libp2p-kad-dht": "~0.13.0",
     "libp2p-keychain": "~0.3.3",
     "libp2p-mdns": "~0.12.0",
     "libp2p-mplex": "~0.8.4",
@@ -145,7 +145,7 @@
     "mafmt": "^6.0.2",
     "mime-types": "^2.1.21",
     "mkdirp": "~0.5.1",
-    "multiaddr": "^6.0.0",
+    "multiaddr": "~6.0.0",
     "multiaddr-to-uri": "^4.0.0",
     "multibase": "~0.6.0",
     "multihashes": "~0.4.14",

From 70613b3735ece58f63c193432d58940233fe9543 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 12 Dec 2018 08:59:44 +0000
Subject: [PATCH 05/41] chore: use hat

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 43f381120e..220b60fa0f 100644
--- a/package.json
+++ b/package.json
@@ -145,7 +145,7 @@
     "mafmt": "^6.0.2",
     "mime-types": "^2.1.21",
     "mkdirp": "~0.5.1",
-    "multiaddr": "~6.0.0",
+    "multiaddr": "^6.0.0",
     "multiaddr-to-uri": "^4.0.0",
     "multibase": "~0.6.0",
     "multihashes": "~0.4.14",

From dde12bc7c66077849f3a46b94b886909b2412656 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 12 Dec 2018 09:00:48 +0000
Subject: [PATCH 06/41] fix: revert kad dep upgrade

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 220b60fa0f..d1f51beaab 100644
--- a/package.json
+++ b/package.json
@@ -131,7 +131,7 @@
     "libp2p": "~0.24.1",
     "libp2p-bootstrap": "~0.9.3",
     "libp2p-crypto": "~0.14.1",
-    "libp2p-kad-dht": "~0.13.0",
+    "libp2p-kad-dht": "~0.12.1",
     "libp2p-keychain": "~0.3.3",
     "libp2p-mdns": "~0.12.0",
     "libp2p-mplex": "~0.8.4",

From 0011cc1c6de1b905a312a1431329b0961dff9ca1 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan@tableflip.io>
Date: Wed, 29 Aug 2018 17:25:35 +0100
Subject: [PATCH 07/41] feat: add cid-base option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/add.js                       |  15 +-
 src/cli/commands/bitswap/stat.js              |  16 +-
 src/cli/commands/bitswap/unwant.js            |  11 +-
 src/cli/commands/bitswap/wantlist.js          |  16 +-
 src/cli/commands/block/put.js                 |  11 +-
 src/cli/commands/block/stat.js                |  16 +-
 src/cli/commands/ls.js                        |  29 ++--
 src/cli/commands/object/get.js                |  13 +-
 src/cli/commands/object/links.js              |  11 +-
 src/cli/commands/object/new.js                |  14 +-
 src/cli/commands/object/patch/add-link.js     |  11 +-
 src/cli/commands/object/patch/append-data.js  |  23 ++-
 src/cli/commands/object/patch/rm-link.js      |  14 +-
 src/cli/commands/object/patch/set-data.js     |  23 ++-
 src/cli/commands/object/put.js                |  19 ++-
 src/cli/commands/pin/add.js                   |  13 +-
 src/cli/commands/pin/ls.js                    |  13 +-
 src/cli/commands/pin/rm.js                    |  16 +-
 src/cli/commands/resolve.js                   |   9 +-
 src/core/components/bitswap.js                |  67 +++++---
 src/core/components/block.js                  |  11 +-
 .../files-regular/add-pull-stream.js          |  20 ++-
 .../files-regular/ls-pull-stream.js           |   3 +-
 src/core/components/object.js                 |   5 +-
 src/core/components/pin.js                    |  43 ++++-
 src/core/components/resolve.js                |   5 +-
 src/http/api/resources/bitswap.js             |  35 +++-
 src/http/api/resources/block.js               |  21 ++-
 src/http/api/resources/files-regular.js       |  17 +-
 src/http/api/resources/object.js              | 156 +++++++++++++-----
 src/http/api/resources/pin.js                 |  39 ++++-
 src/http/api/resources/resolve.js             |   9 +-
 src/utils/cid.js                              |  14 ++
 test/cli/bitswap.js                           |  15 ++
 test/cli/block.js                             |  24 +++
 test/cli/files.js                             |  15 ++
 test/cli/ls.js                                |  15 ++
 test/cli/object.js                            |  77 +++++++++
 test/cli/pin.js                               |  25 +++
 test/cli/resolve.js                           |  24 ++-
 40 files changed, 726 insertions(+), 207 deletions(-)
 create mode 100644 src/utils/cid.js

diff --git a/src/cli/commands/add.js b/src/cli/commands/add.js
index 8b930434d6..9ea059b3c2 100644
--- a/src/cli/commands/add.js
+++ b/src/cli/commands/add.js
@@ -11,9 +11,8 @@ const getFolderSize = require('get-folder-size')
 const byteman = require('byteman')
 const waterfall = require('async/waterfall')
 const mh = require('multihashes')
-const utils = require('../utils')
-const print = require('../utils').print
-const createProgressBar = require('../utils').createProgressBar
+const multibase = require('multibase')
+const { print, isDaemonOn, createProgressBar } = require('../../utils')
 
 function checkPath (inPath, recursive) {
   // This function is to check for the following possible inputs
@@ -156,10 +155,15 @@ module.exports = {
       describe: 'CID version. Defaults to 0 unless an option that depends on CIDv1 is passed. (experimental)',
       default: 0
     },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
+    },
     hash: {
       type: 'string',
       choices: Object.keys(mh.names),
-      describe: 'Hash function to use. Will set Cid version to 1 if used. (experimental)'
+      describe: 'Hash function to use. Will set CID version to 1 if used. (experimental)'
     },
     quiet: {
       alias: 'q',
@@ -194,6 +198,7 @@ module.exports = {
         ? argv.shardSplitThreshold
         : Infinity,
       cidVersion: argv.cidVersion,
+      cidBase: argv.cidBase,
       rawLeaves: argv.rawLeaves,
       onlyHash: argv.onlyHash,
       hashAlg: argv.hash,
@@ -202,7 +207,7 @@ module.exports = {
       chunker: argv.chunker
     }
 
-    if (options.enableShardingExperiment && utils.isDaemonOn()) {
+    if (options.enableShardingExperiment && isDaemonOn()) {
       throw new Error('Error: Enabling the sharding experiment should be done on the daemon')
     }
     const ipfs = argv.ipfs
diff --git a/src/cli/commands/bitswap/stat.js b/src/cli/commands/bitswap/stat.js
index d7a26680f1..7dd01c5946 100644
--- a/src/cli/commands/bitswap/stat.js
+++ b/src/cli/commands/bitswap/stat.js
@@ -1,22 +1,30 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
 
 module.exports = {
   command: 'stat',
 
   describe: 'Show some diagnostic information on the bitswap agent.',
 
-  builder: {},
+  builder: {
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
+    }
+  },
 
   handler (argv) {
-    argv.ipfs.bitswap.stat((err, stats) => {
+    const { cidBase } = argv
+
+    argv.ipfs.bitswap.stat({ cidBase }, (err, stats) => {
       if (err) {
         throw err
       }
 
       stats.wantlist = stats.wantlist || []
-      stats.wantlist = stats.wantlist.map(entry => entry['/'])
       stats.peers = stats.peers || []
 
       print(`bitswap status
diff --git a/src/cli/commands/bitswap/unwant.js b/src/cli/commands/bitswap/unwant.js
index ea676450fa..810f7946d4 100644
--- a/src/cli/commands/bitswap/unwant.js
+++ b/src/cli/commands/bitswap/unwant.js
@@ -1,6 +1,8 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'unwant <key>',
@@ -12,6 +14,11 @@ module.exports = {
       alias: 'k',
       describe: 'Key to remove from your wantlist',
       type: 'string'
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
   handler (argv) {
@@ -19,7 +26,7 @@ module.exports = {
       if (err) {
         throw err
       }
-      print(`Key ${argv.key} removed from wantlist`)
+      print(`Key ${cidToString(argv.key, argv.cidBase)} removed from wantlist`)
     })
   }
 }
diff --git a/src/cli/commands/bitswap/wantlist.js b/src/cli/commands/bitswap/wantlist.js
index 9397f492ae..1f9bda315f 100644
--- a/src/cli/commands/bitswap/wantlist.js
+++ b/src/cli/commands/bitswap/wantlist.js
@@ -1,6 +1,7 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
 
 module.exports = {
   command: 'wantlist [peer]',
@@ -12,17 +13,22 @@ module.exports = {
       alias: 'p',
       describe: 'Specify which peer to show wantlist for.',
       type: 'string'
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
   handler (argv) {
-    argv.ipfs.bitswap.wantlist(argv.peer, (err, res) => {
+    const { peer, cidBase } = argv
+
+    argv.ipfs.bitswap.wantlist(peer, { cidBase }, (err, cids) => {
       if (err) {
         throw err
       }
-      res.Keys.forEach((cid) => {
-        print(cid['/'])
-      })
+      cids.forEach((cid) => print(cid))
     })
   }
 }
diff --git a/src/cli/commands/block/put.js b/src/cli/commands/block/put.js
index 9d75a9c72f..1606ee6ded 100644
--- a/src/cli/commands/block/put.js
+++ b/src/cli/commands/block/put.js
@@ -6,7 +6,9 @@ const bl = require('bl')
 const fs = require('fs')
 const Block = require('ipfs-block')
 const waterfall = require('async/waterfall')
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 function addBlock (data, opts) {
   const ipfs = opts.ipfs
@@ -27,7 +29,7 @@ function addBlock (data, opts) {
     if (err) {
       throw err
     }
-    print(cid.toBaseEncodedString())
+    print(cidToString(cid, opts.cidBase))
   })
 }
 
@@ -54,6 +56,11 @@ module.exports = {
       describe: 'cid version',
       type: 'number',
       default: 0
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
diff --git a/src/cli/commands/block/stat.js b/src/cli/commands/block/stat.js
index 07190fd225..330f4e544d 100644
--- a/src/cli/commands/block/stat.js
+++ b/src/cli/commands/block/stat.js
@@ -1,17 +1,25 @@
 'use strict'
 
-const CID = require('cids')
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
 
 module.exports = {
   command: 'stat <key>',
 
   describe: 'Print information of a raw IPFS block',
 
-  builder: {},
+  builder: {
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
+    }
+  },
 
   handler (argv) {
-    argv.ipfs.block.stat(new CID(argv.key), (err, stats) => {
+    const { key, cidBase } = argv
+
+    argv.ipfs.block.stat(key, { cidBase }, (err, stats) => {
       if (err) {
         throw err
       }
diff --git a/src/cli/commands/ls.js b/src/cli/commands/ls.js
index 97ba7ca692..cb882836fb 100644
--- a/src/cli/commands/ls.js
+++ b/src/cli/commands/ls.js
@@ -1,6 +1,7 @@
 'use strict'
 
-const utils = require('../utils')
+const multibase = require('multibase')
+const { print, rightpad } = require('../utils')
 
 module.exports = {
   command: 'ls <key>',
@@ -24,16 +25,16 @@ module.exports = {
       desc: 'Resolve linked objects to find out their types. (not implemented yet)',
       type: 'boolean',
       default: false // should be true when implemented
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
   handler (argv) {
-    let path = argv.key
-    if (path.startsWith('/ipfs/')) {
-      path = path.replace('/ipfs/', '')
-    }
-
-    argv.ipfs.ls(path, { recursive: argv.recursive }, (err, links) => {
+    argv.ipfs.ls(argv.key, { recursive: argv.recursive, cidBase: argv.cidBase }, (err, links) => {
       if (err) {
         throw err
       }
@@ -45,12 +46,18 @@ module.exports = {
       const multihashWidth = Math.max.apply(null, links.map((file) => file.hash.length))
       const sizeWidth = Math.max.apply(null, links.map((file) => String(file.size).length))
 
+      let pathParts = argv.key.split('/')
+
+      if (argv.key.startsWith('/ipfs/')) {
+        pathParts = pathParts.slice(2)
+      }
+
       links.forEach(link => {
         const fileName = link.type === 'dir' ? `${link.name || ''}/` : link.name
-        const padding = link.depth - path.split('/').length
-        utils.print(
-          utils.rightpad(link.hash, multihashWidth + 1) +
-          utils.rightpad(link.size || '', sizeWidth + 1) +
+        const padding = link.depth - pathParts.length
+        print(
+          rightpad(link.hash, multihashWidth + 1) +
+          rightpad(link.size || '', sizeWidth + 1) +
           '  '.repeat(padding) + fileName
         )
       })
diff --git a/src/cli/commands/object/get.js b/src/cli/commands/object/get.js
index 548ae4f508..45d8604633 100644
--- a/src/cli/commands/object/get.js
+++ b/src/cli/commands/object/get.js
@@ -1,7 +1,9 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
 const dagPB = require('ipld-dag-pb')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'get <key>',
@@ -14,8 +16,9 @@ module.exports = {
       default: 'base64'
     },
     'cid-base': {
-      default: 'base58btc',
-      describe: 'CID base to use.'
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
@@ -38,13 +41,13 @@ module.exports = {
 
         const answer = {
           Data: data,
-          Hash: result.toBaseEncodedString(argv.cidBase),
+          Hash: cidToString(result, argv.cidBase),
           Size: node.size,
           Links: node.links.map((l) => {
             return {
               Name: l.name,
               Size: l.size,
-              Hash: l.cid.toBaseEncodedString(argv.cidBase)
+              Hash: cidToString(l.cid, argv.cidBase)
             }
           })
         }
diff --git a/src/cli/commands/object/links.js b/src/cli/commands/object/links.js
index 9a3a3e203e..0fd98906ef 100644
--- a/src/cli/commands/object/links.js
+++ b/src/cli/commands/object/links.js
@@ -1,6 +1,8 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'links <key>',
@@ -9,8 +11,9 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      default: 'base58btc',
-      describe: 'CID base to use.'
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
@@ -23,7 +26,7 @@ module.exports = {
       }
 
       links.forEach((link) => {
-        print(`${link.cid.toBaseEncodedString(argv.cidBase)} ${link.size} ${link.name}`)
+        print(`${cidToString(link.cid, argv.cidBase)} ${link.size} ${link.name}`)
       })
     })
   }
diff --git a/src/cli/commands/object/new.js b/src/cli/commands/object/new.js
index fc8543fd25..1304997691 100644
--- a/src/cli/commands/object/new.js
+++ b/src/cli/commands/object/new.js
@@ -1,9 +1,8 @@
 'use strict'
 
-const debug = require('debug')
-const log = debug('cli:object')
-log.error = debug('cli:object:error')
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'new [<template>]',
@@ -12,8 +11,9 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      default: 'base58btc',
-      describe: 'CID base to use.'
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
@@ -23,7 +23,7 @@ module.exports = {
         throw err
       }
 
-      print(cid.toBaseEncodedString(argv.cidBase))
+      print(cidToString(cid, argv.cidBase))
     })
   }
 }
diff --git a/src/cli/commands/object/patch/add-link.js b/src/cli/commands/object/patch/add-link.js
index 83e0af8ba4..e631d910e3 100644
--- a/src/cli/commands/object/patch/add-link.js
+++ b/src/cli/commands/object/patch/add-link.js
@@ -2,7 +2,9 @@
 
 const dagPB = require('ipld-dag-pb')
 const DAGLink = dagPB.DAGLink
-const print = require('../../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../../utils')
+const { cidToString } = require('../../../../utils/cid')
 
 module.exports = {
   command: 'add-link <root> <name> <ref>',
@@ -11,8 +13,9 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      default: 'base58btc',
-      describe: 'CID base to use.'
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
@@ -39,7 +42,7 @@ module.exports = {
             throw err
           }
 
-          print(cid.toBaseEncodedString(argv.cidBase))
+          print(cidToString(result, argv.cidBase))
         })
       })
     })
diff --git a/src/cli/commands/object/patch/append-data.js b/src/cli/commands/object/patch/append-data.js
index 0449a2e35d..8e221f3090 100644
--- a/src/cli/commands/object/patch/append-data.js
+++ b/src/cli/commands/object/patch/append-data.js
@@ -2,12 +2,11 @@
 
 const bl = require('bl')
 const fs = require('fs')
-const debug = require('debug')
-const log = debug('cli:object')
-log.error = debug('cli:object:error')
-const print = require('../../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../../utils')
+const { cidToString } = require('../../../../utils/cid')
 
-function appendData (key, data, ipfs) {
+function appendData (key, data, ipfs, options) {
   ipfs.object.patch.appendData(key, data, {
     enc: 'base58'
   }, (err, cid) => {
@@ -15,7 +14,7 @@ function appendData (key, data, ipfs) {
       throw err
     }
 
-    print(cid.toBaseEncodedString())
+    print(cidToString(cid, options.cidBase))
   })
 }
 
@@ -24,12 +23,18 @@ module.exports = {
 
   describe: 'Append data to the data segment of a dag node',
 
-  builder: {},
+  builder: {
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
+    }
+  },
 
   handler (argv) {
     const ipfs = argv.ipfs
     if (argv.data) {
-      return appendData(argv.root, fs.readFileSync(argv.data), ipfs)
+      return appendData(argv.root, fs.readFileSync(argv.data), ipfs, argv)
     }
 
     process.stdin.pipe(bl((err, input) => {
@@ -37,7 +42,7 @@ module.exports = {
         throw err
       }
 
-      appendData(argv.root, input, ipfs)
+      appendData(argv.root, input, ipfs, argv)
     }))
   }
 }
diff --git a/src/cli/commands/object/patch/rm-link.js b/src/cli/commands/object/patch/rm-link.js
index 0324250054..63a23945f2 100644
--- a/src/cli/commands/object/patch/rm-link.js
+++ b/src/cli/commands/object/patch/rm-link.js
@@ -1,9 +1,8 @@
 'use strict'
 
-const debug = require('debug')
-const log = debug('cli:object')
-log.error = debug('cli:object:error')
-const print = require('../../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../../utils')
+const { cidToString } = require('../../../../utils/cid')
 
 module.exports = {
   command: 'rm-link <root> <link>',
@@ -12,8 +11,9 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      default: 'base58btc',
-      describe: 'CID base to use.'
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
@@ -25,7 +25,7 @@ module.exports = {
         throw err
       }
 
-      print(cid.toBaseEncodedString(argv.cidBase))
+      print(cidToString(cid, argv.cidBase))
     })
   }
 }
diff --git a/src/cli/commands/object/patch/set-data.js b/src/cli/commands/object/patch/set-data.js
index cb4b83b19a..efdaefeda4 100644
--- a/src/cli/commands/object/patch/set-data.js
+++ b/src/cli/commands/object/patch/set-data.js
@@ -2,12 +2,11 @@
 
 const fs = require('fs')
 const bl = require('bl')
-const debug = require('debug')
-const log = debug('cli:object')
-log.error = debug('cli:object:error')
-const print = require('../../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../../utils')
+const { cidToString } = require('../../../../utils/cid')
 
-function parseAndAddNode (key, data, ipfs) {
+function parseAndAddNode (key, data, ipfs, options) {
   ipfs.object.patch.setData(key, data, {
     enc: 'base58'
   }, (err, cid) => {
@@ -15,7 +14,7 @@ function parseAndAddNode (key, data, ipfs) {
       throw err
     }
 
-    print(cid.toBaseEncodedString())
+    print(cidToString(cid, options.cidBase))
   })
 }
 
@@ -24,12 +23,18 @@ module.exports = {
 
   describe: 'Set data field of an ipfs object',
 
-  builder: {},
+  builder: {
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
+    }
+  },
 
   handler (argv) {
     const ipfs = argv.ipfs
     if (argv.data) {
-      return parseAndAddNode(argv.root, fs.readFileSync(argv.data), ipfs)
+      return parseAndAddNode(argv.root, fs.readFileSync(argv.data), ipfs, argv)
     }
 
     process.stdin.pipe(bl((err, input) => {
@@ -37,7 +42,7 @@ module.exports = {
         throw err
       }
 
-      parseAndAddNode(argv.root, input, ipfs)
+      parseAndAddNode(argv.root, input, ipfs, argv)
     }))
   }
 }
diff --git a/src/cli/commands/object/put.js b/src/cli/commands/object/put.js
index 110a5a2238..996bd3b949 100644
--- a/src/cli/commands/object/put.js
+++ b/src/cli/commands/object/put.js
@@ -2,15 +2,17 @@
 
 const bl = require('bl')
 const fs = require('fs')
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
-function putNode (buf, enc, ipfs, cidEnc) {
-  ipfs.object.put(buf, { enc: enc }, (err, cid) => {
+function putNode (buf, options, ipfs) {
+  ipfs.object.put(buf, { enc: options.inputEnc }, (err, cid) => {
     if (err) {
       throw err
     }
 
-    print(`added ${cid.toBaseEncodedString(cidEnc)}`)
+    print(`added ${cidToString(cid, options.cidBase)}`)
   })
 }
 
@@ -25,8 +27,9 @@ module.exports = {
       default: 'json'
     },
     'cid-base': {
-      default: 'base58btc',
-      describe: 'CID base to use.'
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
@@ -34,7 +37,7 @@ module.exports = {
     const ipfs = argv.ipfs
     if (argv.data) {
       const buf = fs.readFileSync(argv.data)
-      return putNode(buf, argv.inputEnc, ipfs)
+      return putNode(buf, argv, ipfs)
     }
 
     process.stdin.pipe(bl((err, input) => {
@@ -42,7 +45,7 @@ module.exports = {
         throw err
       }
 
-      putNode(input, argv.inputEnc, ipfs, argv.cidBase)
+      putNode(input, argv, ipfs)
     }))
   }
 }
diff --git a/src/cli/commands/pin/add.js b/src/cli/commands/pin/add.js
index bfb0a0b9a3..c5cce29ee4 100644
--- a/src/cli/commands/pin/add.js
+++ b/src/cli/commands/pin/add.js
@@ -1,6 +1,7 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
 
 module.exports = {
   command: 'add <ipfsPath...>',
@@ -13,13 +14,19 @@ module.exports = {
       alias: 'r',
       default: true,
       describe: 'Recursively pin the object linked to by the specified object(s).'
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
   handler (argv) {
-    const recursive = argv.recursive
+    const { recursive, cidBase } = argv
     const type = recursive ? 'recursive' : 'direct'
-    argv.ipfs.pin.add(argv.ipfsPath, { recursive: recursive }, (err, results) => {
+
+    argv.ipfs.pin.add(argv.ipfsPath, { recursive, cidBase }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
         print(`pinned ${res.hash} ${type}ly`)
diff --git a/src/cli/commands/pin/ls.js b/src/cli/commands/pin/ls.js
index a59958942d..2f101e1a37 100644
--- a/src/cli/commands/pin/ls.js
+++ b/src/cli/commands/pin/ls.js
@@ -1,6 +1,7 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
 
 module.exports = {
   // bracket syntax with '...' tells yargs to optionally accept a list
@@ -21,15 +22,19 @@ module.exports = {
       alias: 'q',
       default: false,
       describe: 'Write just hashes of objects.'
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
   handler: (argv) => {
     const paths = argv.ipfsPath
-    const type = argv.type
-    const quiet = argv.quiet
+    const { type, quiet, cidBase } = argv
 
-    argv.ipfs.pin.ls(paths, { type }, (err, results) => {
+    argv.ipfs.pin.ls(paths, { type, cidBase }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
         let line = res.hash
diff --git a/src/cli/commands/pin/rm.js b/src/cli/commands/pin/rm.js
index acbadf8a96..37c9b1bcd6 100644
--- a/src/cli/commands/pin/rm.js
+++ b/src/cli/commands/pin/rm.js
@@ -1,6 +1,8 @@
 'use strict'
 
-const print = require('../../utils').print
+const multibase = require('multibase')
+const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'rm <ipfsPath...>',
@@ -13,15 +15,21 @@ module.exports = {
       alias: 'r',
       default: true,
       describe: 'Recursively unpin the objects linked to by the specified object(s).'
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
   handler: (argv) => {
-    const recursive = argv.recursive
-    argv.ipfs.pin.rm(argv.ipfsPath, { recursive: recursive }, (err, results) => {
+    const { recursive, cidBase } = argv
+
+    argv.ipfs.pin.rm(argv.ipfsPath, { recursive, cidBase }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        print(`unpinned ${res.hash}`)
+        print(`unpinned ${cidToString(res.hash, argv.cidBase)}`)
       })
     })
   }
diff --git a/src/cli/commands/resolve.js b/src/cli/commands/resolve.js
index c1b7a54991..6cf4e891c8 100644
--- a/src/cli/commands/resolve.js
+++ b/src/cli/commands/resolve.js
@@ -1,5 +1,6 @@
 'use strict'
 
+const multibase = require('multibase')
 const print = require('../utils').print
 
 module.exports = {
@@ -12,11 +13,17 @@ module.exports = {
       alias: 'r',
       type: 'boolean',
       default: false
+    },
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
     }
   },
 
   handler (argv) {
-    argv.ipfs.resolve(argv.name, { recursive: argv.recursive }, (err, res) => {
+    const { recursive, cidBase } = argv
+    argv.ipfs.resolve(argv.name, { recursive, cidBase }, (err, res) => {
       if (err) throw err
       print(res)
     })
diff --git a/src/core/components/bitswap.js b/src/core/components/bitswap.js
index 652135c70a..c1969c3074 100644
--- a/src/core/components/bitswap.js
+++ b/src/core/components/bitswap.js
@@ -7,23 +7,37 @@ const Big = require('big.js')
 const CID = require('cids')
 const PeerId = require('peer-id')
 const errCode = require('err-code')
+const multibase = require('multibase')
+const { cidToString } = require('../../utils/cid')
 
-function formatWantlist (list) {
-  return Array.from(list).map((e) => ({ '/': e[1].cid.toBaseEncodedString() }))
+function formatWantlist (list, cidBase) {
+  return Array.from(list).map((e) => cidToString(e[1].cid, cidBase))
 }
 
 module.exports = function bitswap (self) {
   return {
-    wantlist: promisify((peerId, callback) => {
-      if (!callback) {
+    wantlist: promisify((peerId, options, callback) => {
+      if (typeof peerId === 'function') {
         callback = peerId
-        peerId = undefined
+        options = {}
+        peerId = null
+      } else if (typeof options === 'function') {
+        callback = options
+        options = {}
       }
 
+      options = options || {}
+
       if (!self.isOnline()) {
         return setImmediate(() => callback(new Error(OFFLINE_ERROR)))
       }
 
+      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
+        return setImmediate(() => {
+          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
+        })
+      }
+
       let list
       if (peerId) {
         try {
@@ -38,27 +52,42 @@ module.exports = function bitswap (self) {
       } else {
         list = self._bitswap.getWantlist()
       }
-      list = formatWantlist(list)
-      return setImmediate(() => callback(null, { Keys: list }))
+
+      setImmediate(() => callback(null, formatWantlist(list, options.cidBase)))
     }),
 
-    stat: promisify((callback) => {
+    stat: promisify((options, callback) => {
+      if (typeof options === 'function') {
+        callback = options
+        options = {}
+      }
+
+      options = options || {}
+
       if (!self.isOnline()) {
         return setImmediate(() => callback(new Error(OFFLINE_ERROR)))
       }
 
+      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
+        return setImmediate(() => {
+          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
+        })
+      }
+
       const snapshot = self._bitswap.stat().snapshot
 
-      callback(null, {
-        provideBufLen: parseInt(snapshot.providesBufferLength.toString()),
-        blocksReceived: new Big(snapshot.blocksReceived),
-        wantlist: formatWantlist(self._bitswap.getWantlist()),
-        peers: self._bitswap.peers().map((id) => id.toB58String()),
-        dupBlksReceived: new Big(snapshot.dupBlksReceived),
-        dupDataReceived: new Big(snapshot.dupDataReceived),
-        dataReceived: new Big(snapshot.dataReceived),
-        blocksSent: new Big(snapshot.blocksSent),
-        dataSent: new Big(snapshot.dataSent)
+      setImmediate(() => {
+        callback(null, {
+          provideBufLen: parseInt(snapshot.providesBufferLength.toString()),
+          blocksReceived: new Big(snapshot.blocksReceived),
+          wantlist: formatWantlist(self._bitswap.getWantlist(), options.cidBase),
+          peers: self._bitswap.peers().map((id) => id.toB58String()),
+          dupBlksReceived: new Big(snapshot.dupBlksReceived),
+          dupDataReceived: new Big(snapshot.dupDataReceived),
+          dataReceived: new Big(snapshot.dataReceived),
+          blocksSent: new Big(snapshot.blocksSent),
+          dataSent: new Big(snapshot.dataSent)
+        })
       })
     }),
 
@@ -82,7 +111,7 @@ module.exports = function bitswap (self) {
         return setImmediate(() => callback(errCode(err, 'ERR_INVALID_CID')))
       }
 
-      return setImmediate(() => callback(null, self._bitswap.unwant(keys)))
+      setImmediate(() => callback(null, self._bitswap.unwant(keys)))
     })
   }
 }
diff --git a/src/core/components/block.js b/src/core/components/block.js
index 1e39880993..6eba812302 100644
--- a/src/core/components/block.js
+++ b/src/core/components/block.js
@@ -1,13 +1,14 @@
 'use strict'
 
 const Block = require('ipfs-block')
-const multihash = require('multihashes')
 const multihashing = require('multihashing-async')
 const CID = require('cids')
 const waterfall = require('async/waterfall')
 const setImmediate = require('async/setImmediate')
 const promisify = require('promisify-es6')
 const errCode = require('err-code')
+const multibase = require('multibase')
+const { cidToString } = require('../../utils/cid')
 
 module.exports = function block (self) {
   return {
@@ -103,6 +104,12 @@ module.exports = function block (self) {
         return setImmediate(() => callback(errCode(err, 'ERR_INVALID_CID')))
       }
 
+      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
+        return setImmediate(() => {
+          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
+        })
+      }
+
       if (options.preload !== false) {
         self._preload(cid)
       }
@@ -112,7 +119,7 @@ module.exports = function block (self) {
           return callback(err)
         }
         callback(null, {
-          key: multihash.toB58String(cid.multihash),
+          key: cidToString(cid, options.cidBase),
           size: block.data.length
         })
       })
diff --git a/src/core/components/files-regular/add-pull-stream.js b/src/core/components/files-regular/add-pull-stream.js
index f32bff090b..0d56b5e459 100644
--- a/src/core/components/files-regular/add-pull-stream.js
+++ b/src/core/components/files-regular/add-pull-stream.js
@@ -13,7 +13,7 @@ const WRAPPER = 'wrapper/'
 
 function noop () {}
 
-function prepareFile (self, opts, file, callback) {
+function prepareFile (file, self, opts, callback) {
   opts = opts || {}
 
   let cid = new CID(file.multihash)
@@ -46,7 +46,7 @@ function prepareFile (self, opts, file, callback) {
   ], callback)
 }
 
-function normalizeContent (opts, content) {
+function normalizeContent (content, opts) {
   if (!Array.isArray(content)) {
     content = [content]
   }
@@ -88,7 +88,7 @@ function normalizeContent (opts, content) {
   })
 }
 
-function preloadFile (self, opts, file) {
+function preloadFile (file, self, opts) {
   const isRootFile = opts.wrapWithDirectory
     ? file.path === ''
     : !file.path.includes('/')
@@ -102,7 +102,7 @@ function preloadFile (self, opts, file) {
   return file
 }
 
-function pinFile (self, opts, file, cb) {
+function pinFile (file, self, opts, cb) {
   // Pin a file if it is the root dir of a recursive add or the single file
   // of a direct add.
   const pin = 'pin' in opts ? opts.pin : true
@@ -117,7 +117,9 @@ function pinFile (self, opts, file, cb) {
 
 module.exports = function (self) {
   // Internal add func that gets used by all add funcs
-  return function addPullStream (options = {}) {
+  return function addPullStream (options) {
+    options = options || {}
+
     let chunkerOptions
     try {
       chunkerOptions = parseChunkerString(options.chunker)
@@ -145,12 +147,12 @@ module.exports = function (self) {
 
     opts.progress = progress
     return pull(
-      pull.map(normalizeContent.bind(null, opts)),
+      pull.map(content => normalizeContent(content, opts)),
       pull.flatten(),
       importer(self._ipld, opts),
-      pull.asyncMap(prepareFile.bind(null, self, opts)),
-      pull.map(preloadFile.bind(null, self, opts)),
-      pull.asyncMap(pinFile.bind(null, self, opts))
+      pull.asyncMap((file, cb) => prepareFile(file, self, opts, cb)),
+      pull.map(file => preloadFile(file, self, opts)),
+      pull.asyncMap((file, cb) => pinFile(file, self, opts, cb))
     )
   }
 }
diff --git a/src/core/components/files-regular/ls-pull-stream.js b/src/core/components/files-regular/ls-pull-stream.js
index 25d1e27a0c..bd1b962451 100644
--- a/src/core/components/files-regular/ls-pull-stream.js
+++ b/src/core/components/files-regular/ls-pull-stream.js
@@ -26,8 +26,7 @@ module.exports = function (self) {
         recursive ? node.depth >= pathDepth : node.depth === pathDepth
       ),
       pull.map(node => {
-        const cid = new CID(node.hash)
-        node = Object.assign({}, node, { hash: cid.toBaseEncodedString() })
+        node.hash = new CID(node.hash).toBaseEncodedString()
         delete node.content
         return node
       })
diff --git a/src/core/components/object.js b/src/core/components/object.js
index 57e8e0b9b4..7605b11d46 100644
--- a/src/core/components/object.js
+++ b/src/core/components/object.js
@@ -11,6 +11,7 @@ const CID = require('cids')
 const mh = require('multihashes')
 const Unixfs = require('ipfs-unixfs')
 const errCode = require('err-code')
+const { cidToString } = require('../../utils/cid')
 
 function normalizeMultihash (multihash, enc) {
   if (typeof multihash === 'string') {
@@ -293,6 +294,8 @@ module.exports = function object (self) {
         options = {}
       }
 
+      options = options || {}
+
       waterfall([
         (cb) => self.object.get(multihash, options, cb),
         (node, cb) => {
@@ -311,7 +314,7 @@ module.exports = function object (self) {
         const linkLength = result.node.links.reduce((a, l) => a + l.size, 0)
 
         callback(null, {
-          Hash: result.cid.toBaseEncodedString(),
+          Hash: cidToString(result.cid, options.cidBase),
           NumLinks: result.node.links.length,
           BlockSize: blockSize,
           LinksSize: blockSize - result.node.data.length,
diff --git a/src/core/components/pin.js b/src/core/components/pin.js
index e89c9f3fad..ebd891eaa5 100644
--- a/src/core/components/pin.js
+++ b/src/core/components/pin.js
@@ -14,8 +14,11 @@ const detectLimit = require('async/detectLimit')
 const setImmediate = require('async/setImmediate')
 const { Key } = require('interface-datastore')
 const errCode = require('err-code')
+const multibase = require('multibase')
+
 const createPinSet = require('./pin-set')
 const { resolvePath } = require('../utils')
+const { cidToString } = require('../../utils/cid')
 
 // arbitrary limit to the number of concurrent dag operations
 const concurrencyLimit = 300
@@ -143,10 +146,17 @@ module.exports = (self) => {
         callback = options
         options = {}
       }
+
       options = options || {}
 
       const recursive = options.recursive == null ? true : options.recursive
 
+      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
+        return setImmediate(() => {
+          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
+        })
+      }
+
       resolvePath(self.object, paths, (err, mhs) => {
         if (err) { return callback(err) }
 
@@ -193,18 +203,25 @@ module.exports = (self) => {
           // persist updated pin sets to datastore
           flushPins((err, root) => {
             if (err) { return callback(err) }
-            return callback(null, results.map(hash => ({ hash })))
+            callback(null, results.map(hash => ({ hash: cidToString(hash, options.cidBase) })))
           })
         })
       })
     }),
 
     rm: promisify((paths, options, callback) => {
-      let recursive = true
       if (typeof options === 'function') {
         callback = options
-      } else if (options && options.recursive === false) {
-        recursive = false
+      }
+
+      options = options || {}
+
+      const recursive = options.recursive == null ? true : options.recursive
+
+      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
+        return setImmediate(() => {
+          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
+        })
       }
 
       resolvePath(self.object, paths, (err, mhs) => {
@@ -251,7 +268,7 @@ module.exports = (self) => {
           flushPins((err, root) => {
             if (err) { return callback(err) }
             self.log(`Removed pins: ${results}`)
-            return callback(null, results.map(hash => ({ hash })))
+            callback(null, results.map(hash => ({ hash: cidToString(hash, options.cidBase) })))
           })
         })
       })
@@ -261,7 +278,7 @@ module.exports = (self) => {
       let type = types.all
       if (typeof paths === 'function') {
         callback = paths
-        options = null
+        options = {}
         paths = null
       }
       if (typeof options === 'function') {
@@ -271,7 +288,10 @@ module.exports = (self) => {
         options = paths
         paths = null
       }
-      if (options && options.type) {
+
+      options = options || {}
+
+      if (options.type) {
         if (typeof options.type !== 'string') {
           return setImmediate(() => callback(invalidPinTypeErr(options.type)))
         }
@@ -281,6 +301,12 @@ module.exports = (self) => {
         return setImmediate(() => callback(invalidPinTypeErr(type)))
       }
 
+      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
+        return setImmediate(() => {
+          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
+        })
+      }
+
       if (paths) {
         // check the pinned state of specific hashes
         waterfall([
@@ -345,10 +371,11 @@ module.exports = (self) => {
                 type: types.indirect,
                 hash
               })))
+              .map(p => Object.assign(p, { hash: cidToString(p.hash, options.cidBase) }))
             return callback(null, pins)
           })
         } else {
-          return callback(null, pins)
+          callback(null, pins.map(p => Object.assign(p, { hash: cidToString(p.hash, options.cidBase) })))
         }
       }
     }),
diff --git a/src/core/components/resolve.js b/src/core/components/resolve.js
index dd866cbfbb..14034427bc 100644
--- a/src/core/components/resolve.js
+++ b/src/core/components/resolve.js
@@ -5,6 +5,7 @@ const isIpfs = require('is-ipfs')
 const setImmediate = require('async/setImmediate')
 const doUntil = require('async/doUntil')
 const CID = require('cids')
+const { cidToString } = require('../../utils/cid')
 
 module.exports = (self) => {
   return promisify((name, opts, cb) => {
@@ -28,7 +29,7 @@ module.exports = (self) => {
     const cid = new CID(split[2])
 
     if (split.length === 3) {
-      return setImmediate(() => cb(null, name))
+      return setImmediate(() => cb(null, `/ipfs/${cidToString(cid, opts.cidBase)}`))
     }
 
     const path = split.slice(3).join('/')
@@ -36,7 +37,7 @@ module.exports = (self) => {
     resolve(cid, path, (err, cid) => {
       if (err) return cb(err)
       if (!cid) return cb(new Error('found non-link at given path'))
-      cb(null, `/ipfs/${cid.toBaseEncodedString(opts.cidBase)}`)
+      cb(null, `/ipfs/${cidToString(cid, opts.cidBase)}`)
     })
   })
 
diff --git a/src/http/api/resources/bitswap.js b/src/http/api/resources/bitswap.js
index 33eccd7bcb..8a6304d159 100644
--- a/src/http/api/resources/bitswap.js
+++ b/src/http/api/resources/bitswap.js
@@ -1,28 +1,45 @@
 'use strict'
 
 const boom = require('boom')
-
+const Joi = require('joi')
+const multibase = require('multibase')
+const { cidToString } = require('../../../utils/cid')
 const parseKey = require('./block').parseKey
 
 exports = module.exports
 
 exports.wantlist = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   handler: (request, reply) => {
     const peerId = request.query.peer
-    request.server.app.ipfs.bitswap.wantlist(peerId, (err, list) => {
+    const cidBase = request.query['cid-base']
+
+    request.server.app.ipfs.bitswap.wantlist(peerId, { cidBase }, (err, list) => {
       if (err) {
         return reply(boom.badRequest(err))
       }
-      reply(list)
+      reply({ Keys: list })
     })
   }
 }
 
 exports.stat = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   handler: (request, reply) => {
     const ipfs = request.server.app.ipfs
+    const cidBase = request.query['cid-base']
 
-    ipfs.bitswap.stat((err, stats) => {
+    ipfs.bitswap.stat({ cidBase }, (err, stats) => {
       if (err) {
         return reply({
           Message: err.toString(),
@@ -33,7 +50,7 @@ exports.stat = {
       reply({
         ProvideBufLen: stats.provideBufLen,
         BlocksReceived: stats.blocksReceived,
-        Wantlist: stats.wantlist,
+        Wantlist: stats.wantlist.map(cid => ({ '/': cid })),
         Peers: stats.peers,
         DupBlksReceived: stats.dupBlksReceived,
         DupDataReceived: stats.dupDataReceived,
@@ -46,6 +63,12 @@ exports.stat = {
 }
 
 exports.unwant = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKey method that assigns a `key` to request.pre.args
   parseArgs: parseKey,
 
@@ -57,7 +80,7 @@ exports.unwant = {
       if (err) {
         return reply(boom.badRequest(err))
       }
-      reply({ key: key.toBaseEncodedString() })
+      reply({ key: cidToString(key, request.query['cid-base']) })
     })
   }
 }
diff --git a/src/http/api/resources/block.js b/src/http/api/resources/block.js
index 9ef21b3c70..ffd961022b 100644
--- a/src/http/api/resources/block.js
+++ b/src/http/api/resources/block.js
@@ -2,6 +2,9 @@
 
 const CID = require('cids')
 const multipart = require('ipfs-multipart')
+const Joi = require('joi')
+const multibase = require('multibase')
+const { cidToString } = require('../../../utils/cid')
 const debug = require('debug')
 const log = debug('jsipfs:http-api:block')
 log.error = debug('jsipfs:http-api:block:error')
@@ -57,6 +60,12 @@ exports.get = {
 }
 
 exports.put = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // pre request handler that parses the args and returns `data` which is assigned to `request.pre.args`
   parseArgs: (request, reply) => {
     if (!request.payload) {
@@ -110,7 +119,7 @@ exports.put = {
       }
 
       return reply({
-        Key: block.cid.toBaseEncodedString(),
+        Key: cidToString(block.cid, request.query['cid-base']),
         Size: block.data.length
       })
     })
@@ -140,13 +149,21 @@ exports.del = {
 }
 
 exports.stat = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKey method that returns a `key`
   parseArgs: exports.parseKey,
 
   // main route handler which is called after the above `parseArgs`, but only if the args were valid
   handler: (request, reply) => {
     const key = request.pre.args.key
-    request.server.app.ipfs.block.stat(key, (err, stats) => {
+    const cidBase = request.query['cid-base']
+
+    request.server.app.ipfs.block.stat(key, { cidBase }, (err, stats) => {
       if (err) {
         log.error(err)
         return reply({
diff --git a/src/http/api/resources/files-regular.js b/src/http/api/resources/files-regular.js
index d38c1ede7b..704873bc9d 100644
--- a/src/http/api/resources/files-regular.js
+++ b/src/http/api/resources/files-regular.js
@@ -15,6 +15,8 @@ const abortable = require('pull-abortable')
 const Joi = require('joi')
 const ndjson = require('pull-ndjson')
 const { PassThrough } = require('readable-stream')
+const multibase = require('multibase')
+const { cidToString } = require('../../../utils/cid')
 
 exports = module.exports
 
@@ -169,6 +171,7 @@ exports.add = {
     query: Joi.object()
       .keys({
         'cid-version': Joi.number().integer().min(0).max(1).default(0),
+        'cid-base': Joi.string().valid(multibase.names),
         'raw-leaves': Joi.boolean(),
         'only-hash': Joi.boolean(),
         pin: Joi.boolean().default(true),
@@ -232,6 +235,7 @@ exports.add = {
 
     const options = {
       cidVersion: request.query['cid-version'],
+      cidBase: request.query['cid-base'],
       rawLeaves: request.query['raw-leaves'],
       progress: request.query.progress ? progressHandler : null,
       onlyHash: request.query['only-hash'],
@@ -298,6 +302,12 @@ exports.add = {
 }
 
 exports.ls = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKey method that returns a `key`
   parseArgs: exports.parseKey,
 
@@ -306,8 +316,9 @@ exports.ls = {
     const key = request.pre.args.key
     const ipfs = request.server.app.ipfs
     const recursive = request.query && request.query.recursive === 'true'
+    const cidBase = request.query['cid-base']
 
-    ipfs.ls(key, { recursive: recursive }, (err, files) => {
+    ipfs.ls(key, { recursive, cidBase }, (err, files) => {
       if (err) {
         return reply({
           Message: 'Failed to list dir: ' + err.message,
@@ -318,10 +329,10 @@ exports.ls = {
 
       reply({
         Objects: [{
-          Hash: key,
+          Hash: cidToString(key, cidBase),
           Links: files.map((file) => ({
             Name: file.name,
-            Hash: file.hash,
+            Hash: cidToString(file.hash, cidBase),
             Size: file.size,
             Type: toTypeCode(file.type),
             Depth: file.depth
diff --git a/src/http/api/resources/object.js b/src/http/api/resources/object.js
index a65009a937..7e2b3b3f19 100644
--- a/src/http/api/resources/object.js
+++ b/src/http/api/resources/object.js
@@ -6,6 +6,9 @@ const dagPB = require('ipld-dag-pb')
 const DAGLink = dagPB.DAGLink
 const DAGNode = dagPB.DAGNode
 const waterfall = require('async/waterfall')
+const Joi = require('joi')
+const multibase = require('multibase')
+const { cidToString } = require('../../../utils/cid')
 const debug = require('debug')
 const log = debug('jsipfs:http-api:object')
 log.error = debug('jsipfs:http-api:object:error')
@@ -31,42 +34,56 @@ exports.parseKey = (request, reply) => {
   }
 }
 
-exports.new = (request, reply) => {
-  const ipfs = request.server.app.ipfs
-  const template = request.query.arg
+exports.new = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
 
-  waterfall([
-    (cb) => ipfs.object.new(template, cb),
-    (cid, cb) => ipfs.object.get(cid, (err, node) => cb(err, { node, cid }))
-  ], (err, results) => {
-    if (err) {
-      log.error(err)
-      return reply({
-        Message: `Failed to create object: ${err.message}`,
-        Code: 0
-      }).code(500)
-    }
+  handler (request, reply) {
+    const ipfs = request.server.app.ipfs
+    const template = request.query.arg
 
-    const nodeJSON = results.node.toJSON()
-
-    const answer = {
-      Data: nodeJSON.data,
-      Hash: results.cid.toBaseEncodedString(),
-      Size: nodeJSON.size,
-      Links: nodeJSON.links.map((l) => {
-        return {
-          Name: l.name,
-          Size: l.size,
-          Hash: l.cid
-        }
-      })
-    }
+    waterfall([
+      (cb) => ipfs.object.new(template, cb),
+      (cid, cb) => ipfs.object.get(cid, (err, node) => cb(err, { node, cid }))
+    ], (err, results) => {
+      if (err) {
+        log.error(err)
+        return reply({
+          Message: `Failed to create object: ${err.message}`,
+          Code: 0
+        }).code(500)
+      }
 
-    return reply(answer)
-  })
+      const nodeJSON = results.node.toJSON()
+
+      const answer = {
+        Data: nodeJSON.data,
+        Hash: cidToString(results.cid, request.query['cid-base']),
+        Size: nodeJSON.size,
+        Links: nodeJSON.links.map((l) => {
+          return {
+            Name: l.name,
+            Size: l.size,
+            Hash: cidToString(l.cid, request.query['cid-base'])
+          }
+        })
+      }
+
+      return reply(answer)
+    })
+  }
 }
 
 exports.get = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKey method that returns a `key`
   parseArgs: exports.parseKey,
 
@@ -96,13 +113,13 @@ exports.get = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: results.cid.toBaseEncodedString(),
+        Hash: cidToString(results.cid, request.query['cid-base']),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: l.cid
+            Hash: cidToString(l.cid, request.query['cid-base'])
           }
         })
       }
@@ -113,6 +130,12 @@ exports.get = {
 }
 
 exports.put = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // pre request handler that parses the args and returns `node`
   // which is assigned to `request.pre.args`
   parseArgs: (request, reply) => {
@@ -215,13 +238,13 @@ exports.put = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: results.cid.toBaseEncodedString(),
+        Hash: cidToString(results.cid, request.query['cid-base']),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: l.cid
+            Hash: cidToString(l.cid, request.query['cid-base'])
           }
         })
       }
@@ -232,6 +255,12 @@ exports.put = {
 }
 
 exports.stat = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKey method that returns a `key`
   parseArgs: exports.parseKey,
 
@@ -239,8 +268,9 @@ exports.stat = {
   handler: (request, reply) => {
     const ipfs = request.server.app.ipfs
     const key = request.pre.args.key
+    const cidBase = request.query['cid-base']
 
-    ipfs.object.stat(key, (err, stats) => {
+    ipfs.object.stat(key, { cidBase }, (err, stats) => {
       if (err) {
         log.error(err)
         return reply({
@@ -278,6 +308,12 @@ exports.data = {
 }
 
 exports.links = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKey method that returns a `key`
   parseArgs: exports.parseKey,
 
@@ -301,12 +337,12 @@ exports.links = {
       const nodeJSON = results.node.toJSON()
 
       return reply({
-        Hash: results.cid.toBaseEncodedString(),
+        Hash: cidToString(results.cid, request.query['cid-base']),
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: l.cid
+            Hash: cidToString(l.cid, request.query['cid-base'])
           }
         })
       })
@@ -354,6 +390,12 @@ exports.parseKeyAndData = (request, reply) => {
 }
 
 exports.patchAppendData = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKeyAndData method that returns a `data` & `key`
   parseArgs: exports.parseKeyAndData,
 
@@ -380,13 +422,13 @@ exports.patchAppendData = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: results.cid.toBaseEncodedString(),
+        Hash: cidToString(results.cid, request.query['cid-base']),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: l.cid
+            Hash: cidToString(l.cid, request.query['cid-base'])
           }
         })
       }
@@ -397,6 +439,12 @@ exports.patchAppendData = {
 }
 
 exports.patchSetData = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // uses common parseKeyAndData method that returns a `data` & `key`
   parseArgs: exports.parseKeyAndData,
 
@@ -422,14 +470,26 @@ exports.patchSetData = {
       const nodeJSON = results.node.toJSON()
 
       return reply({
-        Hash: results.cid.toBaseEncodedString(),
-        Links: nodeJSON.links
+        Hash: cidToString(results.cid, request.query['cid-base']),
+        Links: nodeJSON.links.map((l) => {
+          return {
+            Name: l.name,
+            Size: l.size,
+            Hash: cidToString(l.cid, request.query['cid-base'])
+          }
+        })
       })
     })
   }
 }
 
 exports.patchAddLink = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // pre request handler that parses the args and returns `root`, `name` & `ref` which is assigned to `request.pre.args`
   parseArgs: (request, reply) => {
     if (!(request.query.arg instanceof Array) ||
@@ -490,13 +550,13 @@ exports.patchAddLink = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: results.cid.toBaseEncodedString(),
+        Hash: cidToString(results.cid, request.query['cid-base']),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: l.cid
+            Hash: cidToString(l.cid, request.query['cid-base'])
           }
         })
       }
@@ -507,6 +567,12 @@ exports.patchAddLink = {
 }
 
 exports.patchRmLink = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   // pre request handler that parses the args and returns `root` & `link` which is assigned to `request.pre.args`
   parseArgs: (request, reply) => {
     if (!(request.query.arg instanceof Array) ||
@@ -557,13 +623,13 @@ exports.patchRmLink = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: results.cid.toBaseEncodedString(),
+        Hash: cidToString(results.cid, request.query['cid-base']),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: l.cid
+            Hash: cidToString(l.cid, request.query['cid-base'])
           }
         })
       }
diff --git a/src/http/api/resources/pin.js b/src/http/api/resources/pin.js
index 5499dfd34f..b94c793371 100644
--- a/src/http/api/resources/pin.js
+++ b/src/http/api/resources/pin.js
@@ -1,6 +1,9 @@
 'use strict'
 
-const _ = require('lodash')
+const mapValues = require('lodash/mapValues')
+const keyBy = require('lodash/keyBy')
+const multibase = require('multibase')
+const Joi = require('joi')
 const debug = require('debug')
 const log = debug('jsipfs:http-api:pin')
 log.error = debug('jsipfs:http-api:pin:error')
@@ -24,6 +27,12 @@ function parseArgs (request, reply) {
 }
 
 exports.ls = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   parseArgs: (request, reply) => {
     const type = request.query.type || 'all'
 
@@ -36,7 +45,9 @@ exports.ls = {
   handler: (request, reply) => {
     const { path, type } = request.pre.args
     const ipfs = request.server.app.ipfs
-    ipfs.pin.ls(path, { type }, (err, result) => {
+    const cidBase = request.query['cid-base']
+
+    ipfs.pin.ls(path, { type, cidBase }, (err, result) => {
       if (err) {
         log.error(err)
         return reply({
@@ -46,8 +57,8 @@ exports.ls = {
       }
 
       return reply({
-        Keys: _.mapValues(
-          _.keyBy(result, obj => obj.hash),
+        Keys: mapValues(
+          keyBy(result, obj => obj.hash),
           obj => ({ Type: obj.type })
         )
       })
@@ -56,12 +67,20 @@ exports.ls = {
 }
 
 exports.add = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   parseArgs: parseArgs,
 
   handler: (request, reply) => {
     const ipfs = request.server.app.ipfs
     const { path, recursive } = request.pre.args
-    ipfs.pin.add(path, { recursive }, (err, result) => {
+    const cidBase = request.query['cid-base']
+
+    ipfs.pin.add(path, { recursive, cidBase }, (err, result) => {
       if (err) {
         log.error(err)
         return reply({
@@ -78,12 +97,20 @@ exports.add = {
 }
 
 exports.rm = {
+  validate: {
+    query: Joi.object().keys({
+      'cid-base': Joi.string().valid(multibase.names)
+    }).unknown()
+  },
+
   parseArgs: parseArgs,
 
   handler: (request, reply) => {
     const ipfs = request.server.app.ipfs
     const { path, recursive } = request.pre.args
-    ipfs.pin.rm(path, { recursive }, (err, result) => {
+    const cidBase = request.query['cid-base']
+
+    ipfs.pin.rm(path, { recursive, cidBase }, (err, result) => {
       if (err) {
         log.error(err)
         return reply({
diff --git a/src/http/api/resources/resolve.js b/src/http/api/resources/resolve.js
index 417f50d8e8..478e423595 100644
--- a/src/http/api/resources/resolve.js
+++ b/src/http/api/resources/resolve.js
@@ -2,6 +2,7 @@
 
 const Joi = require('joi')
 const debug = require('debug')
+const multibase = require('multibase')
 
 const log = debug('jsipfs:http-api:resolve')
 log.error = debug('jsipfs:http-api:resolve:error')
@@ -16,17 +17,19 @@ module.exports = {
           otherwise: Joi.boolean()
         }),
       recursive: Joi.boolean(),
-      arg: Joi.string().required()
+      arg: Joi.string().required(),
+      'cid-base': Joi.string().valid(multibase.names)
     }).unknown()
   },
   handler (request, reply) {
     const ipfs = request.server.app.ipfs
     const name = request.query.arg
     const recursive = request.query.r || request.query.recursive || false
+    const cidBase = request.query['cid-base']
 
-    log(name, { recursive })
+    log(name, { recursive, cidBase })
 
-    ipfs.resolve(name, { recursive }, (err, res) => {
+    ipfs.resolve(name, { recursive, cidBase }, (err, res) => {
       if (err) {
         log.error(err)
         return reply({ Message: err.message, Code: 0 }).code(500)
diff --git a/src/utils/cid.js b/src/utils/cid.js
new file mode 100644
index 0000000000..6431133a9f
--- /dev/null
+++ b/src/utils/cid.js
@@ -0,0 +1,14 @@
+const CID = require('cids')
+
+// Stringify a CID in the requested base, auto-converting to v1 if necessary
+exports.cidToString = (cid, base) => {
+  if (!CID.isCID(cid)) {
+    cid = new CID(cid)
+  }
+
+  if (cid.version === 0 && base && base !== 'base58btc') {
+    cid = cid.toV1()
+  }
+
+  return cid.toBaseEncodedString(base)
+}
diff --git a/test/cli/bitswap.js b/test/cli/bitswap.js
index 087bb19453..9e8279e204 100644
--- a/test/cli/bitswap.js
+++ b/test/cli/bitswap.js
@@ -4,6 +4,7 @@
 const expect = require('chai').expect
 const runOn = require('../utils/on-and-off').on
 const PeerId = require('peer-id')
+const CID = require('cids')
 const waitFor = require('../utils/wait-for')
 
 describe('bitswap', () => runOn((thing) => {
@@ -51,6 +52,13 @@ describe('bitswap', () => runOn((thing) => {
     })
   })
 
+  it('should get wantlist with CIDs encoded in specified base', function () {
+    this.timeout(20 * 1000)
+    return ipfs('bitswap wantlist --cid-base=base64').then((out) => {
+      expect(out).to.eql(new CID(key).toV1().toBaseEncodedString('base64') + '\n')
+    })
+  })
+
   it('wantlist peerid', function () {
     this.timeout(20 * 1000)
     return ipfs('bitswap wantlist ' + peerId).then((out) => {
@@ -75,6 +83,13 @@ describe('bitswap', () => runOn((thing) => {
     })
   })
 
+  it('should get stats with wantlist CIDs encoded in specified base', function () {
+    this.timeout(20 * 1000)
+    return ipfs('bitswap stat --cid-base=base64').then((out) => {
+      expect(out).to.include(new CID(key).toV1().toBaseEncodedString('base64'))
+    })
+  })
+
   it('unwant', function () {
     return ipfs('bitswap unwant ' + key).then((out) => {
       expect(out).to.eql(`Key ${key} removed from wantlist\n`)
diff --git a/test/cli/block.js b/test/cli/block.js
index 054e14995b..940aeb6bff 100644
--- a/test/cli/block.js
+++ b/test/cli/block.js
@@ -26,6 +26,14 @@ describe('block', () => runOnAndOff((thing) => {
         expect(out).to.eql('z43AaGF23fmvRnDP56Ub9WcJCfzSfqtmzNCCvmz5eudT8dtdCDS\n'))
   })
 
+  it('should put and print CID encoded in specified base', function () {
+    this.timeout(40 * 1000)
+
+    return ipfs('block put test/fixtures/test-data/hello --cid-base=base64').then((out) => {
+      expect(out).to.eql('mAXASIKlIkE8vD0ebj4GXaUswGEsNLtHBzSoewPuF0pmhkqRH\n')
+    })
+  })
+
   it('get', function () {
     this.timeout(40 * 1000)
 
@@ -55,6 +63,22 @@ describe('block', () => runOnAndOff((thing) => {
       })
   })
 
+  it('should stat and print CID encoded in specified base', function () {
+    this.timeout(80 * 1000)
+
+    return ipfs('block put test/fixtures/test-data/hello')
+      .then((out) => {
+        expect(out).to.eql('QmZjTnYw2TFhn9Nn7tjmPSoTBoY7YRkwPzwSrSbabY24Kp\n')
+        return ipfs('block stat QmZjTnYw2TFhn9Nn7tjmPSoTBoY7YRkwPzwSrSbabY24Kp --cid-base=base64')
+      })
+      .then((out) => {
+        expect(out).to.eql([
+          'Key: mAXASIKlIkE8vD0ebj4GXaUswGEsNLtHBzSoewPuF0pmhkqRH',
+          'Size: 12'
+        ].join('\n') + '\n')
+      })
+  })
+
   it.skip('rm', function () {
     this.timeout(40 * 1000)
 
diff --git a/test/cli/files.js b/test/cli/files.js
index 69843145e6..bd9409f872 100644
--- a/test/cli/files.js
+++ b/test/cli/files.js
@@ -363,6 +363,21 @@ describe('files', () => runOnAndOff((thing) => {
     })
   })
 
+  it('should add and print CID encoded in specified base', function () {
+    this.timeout(30 * 1000)
+
+<<<<<<< HEAD
+    return ipfs('add test/fixtures/test-data/hello --cid-base=base64')
+      .then((out) => {
+        expect(out).to.eql('added mAXASIKlIkE8vD0ebj4GXaUswGEsNLtHBzSoewPuF0pmhkqRH hello\n')
+=======
+    return ipfs('add test/fixtures/test-data/hello --cid-base=base32')
+      .then((out) => {
+        expect(out).to.eql('added bafybeicg2rebjoofv4kbyovkw7af3rpiitvnl6i7ckcywaq6xjcxnc2mby hello\n')
+>>>>>>> feat: add cid-base option for files.add*
+      })
+  })
+
   it('cat', function () {
     this.timeout(30 * 1000)
 
diff --git a/test/cli/ls.js b/test/cli/ls.js
index 4eccf82c07..f833a1e32b 100644
--- a/test/cli/ls.js
+++ b/test/cli/ls.js
@@ -89,4 +89,19 @@ describe('ls', () => runOnAndOff((thing) => {
         )
       })
   })
+
+  it('should ls and print CIDs encoded in specified base', function () {
+    this.timeout(20 * 1000)
+
+    return ipfs('ls Qmaj2NmcyAXT8dFmZRRytE12wpcaHADzbChKToMEjBsj5Z --cid-base=base64')
+      .then((out) => {
+        expect(out).to.eql(
+          'mAXASILidvV1YroHLqBvmuXko1Ly1UVenZV1K+MvhsjXhdvZQ 123530 blocks/\n' +
+          'mAXASIBT4ZYkQw0IApLoNHBxSjpezyayKZHJyxmFKpt0I3sK5 3939   config\n' +
+          'mAXASIGCpScP8zpa0CqUgyVCR/Cm0Co8pnULGe3seXSsOnJsJ 5503   datastore/\n' +
+          'mAXASIF58POI3+TbHb69iXpD3dRqfXusEj1mHMwPCFenM6HWZ 7397   init-docs/\n' +
+          'mAXASICiW5ai+KiU60glImEMMkiHaNSOAivpXspriIhJO8iHI 10     version\n'
+        )
+      })
+  })
 }))
diff --git a/test/cli/object.js b/test/cli/object.js
index 1462d00d55..de6c5828df 100644
--- a/test/cli/object.js
+++ b/test/cli/object.js
@@ -33,6 +33,22 @@ describe('object', () => runOnAndOff((thing) => {
     })
   })
 
+  it('should new and print CID encoded in specified base', () => {
+    return ipfs('object new --cid-base=base64').then((out) => {
+      expect(out).to.eql(
+        'mAXASIOOwxEKY/BwUmvv0yJlvuSQnrkHkZJuTTKSVmRt4UrhV\n'
+      )
+    })
+  })
+
+  it('should new and print CID encoded in specified base', () => {
+    return ipfs('object new --cid-base=base32').then((out) => {
+      expect(out).to.eql(
+        'bafybeihdwdcefgh4dqkjv67uzcmw7ojee6xedzdetojuzjevtenxquvyku\n'
+      )
+    })
+  })
+
   it('get', () => {
     return ipfs('object get QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n').then((out) => {
       const result = JSON.parse(out)
@@ -69,6 +85,17 @@ describe('object', () => runOnAndOff((thing) => {
       })
   })
 
+  it('should get and print CIDs encoded in specified base', () => {
+    return ipfs('object put test/fixtures/test-data/node.json')
+      .then(out => out.replace('added', '').trim())
+      .then(cid => ipfs(`object get ${cid} --cid-base=base64`))
+      .then(out => {
+        const result = JSON.parse(out)
+        expect(result.Hash).to.equal('mAXASIKbM02Neyt6L1RRLYVEOuNlqDOzTvBboo3cI/u6f/+Vk')
+        expect(result.Links[0].Hash).to.equal('mAXASIIq3psXnRzeHisc4Y8t2c50V1GZt5E5XVr9Vovnpq19E')
+      })
+  })
+
   it('put', () => {
     return ipfs('object put test/fixtures/test-data/node.json').then((out) => {
       expect(out).to.eql(
@@ -77,6 +104,15 @@ describe('object', () => runOnAndOff((thing) => {
     })
   })
 
+  it('should put and print CID encoded in specified base', () => {
+    return ipfs('object put test/fixtures/test-data/node.json --cid-base=base64')
+      .then((out) => {
+        expect(out).to.eql(
+          'added mAXASIKbM02Neyt6L1RRLYVEOuNlqDOzTvBboo3cI/u6f/+Vk\n'
+        )
+      })
+  })
+
   it('stat', function () {
     this.timeout(40 * 1000)
 
@@ -126,6 +162,15 @@ describe('object', () => runOnAndOff((thing) => {
     })
   })
 
+  it('should get links and print CIDs encoded in specified base', () => {
+    return ipfs('object put test/fixtures/test-data/node.json')
+      .then(out => out.replace('added', '').trim())
+      .then(cid => ipfs(`object links ${cid} --cid-base=base64`))
+      .then(out => {
+        expect(out).to.equal('mAXASIIq3psXnRzeHisc4Y8t2c50V1GZt5E5XVr9Vovnpq19E 8 some link\n')
+      })
+  })
+
   describe('patch', function () {
     this.timeout(40 * 1000)
 
@@ -137,6 +182,14 @@ describe('object', () => runOnAndOff((thing) => {
       })
     })
 
+    it('should append-data and print CID encoded in specified base', () => {
+      return ipfs('object patch append-data QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n test/fixtures/test-data/badconfig --cid-base=base64').then((out) => {
+        expect(out).to.eql(
+          'mAXASIP+BZ7jGtaTyLGOs0xYcQvH7K9kVKEbyzXAkwLoZwrRj\n'
+        )
+      })
+    })
+
     it('set-data', () => {
       return ipfs('object patch set-data QmfY37rjbPCZRnhvvJuQ46htW3VCAWziVB991P79h6WSv6 test/fixtures/test-data/badconfig').then((out) => {
         expect(out).to.eql(
@@ -145,6 +198,14 @@ describe('object', () => runOnAndOff((thing) => {
       })
     })
 
+    it('should set-data and print CID encoded in specified base', () => {
+      return ipfs('object patch set-data QmfY37rjbPCZRnhvvJuQ46htW3VCAWziVB991P79h6WSv6 test/fixtures/test-data/badconfig --cid-base=base64').then((out) => {
+        expect(out).to.eql(
+          'mAXASIP+BZ7jGtaTyLGOs0xYcQvH7K9kVKEbyzXAkwLoZwrRj\n'
+        )
+      })
+    })
+
     it('add-link', () => {
       return ipfs('object patch add-link QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n foo QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn').then((out) => {
         expect(out).to.eql(
@@ -153,6 +214,14 @@ describe('object', () => runOnAndOff((thing) => {
       })
     })
 
+    it('should add-link and print CID encoded in specified base', () => {
+      return ipfs('object patch add-link QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n foo QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn --cid-base=base64').then((out) => {
+        expect(out).to.eql(
+          'mAXASIOEVPbXq2xYoEsRZhaPB61btcy1x359osjv4a2L/lgPs\n'
+        )
+      })
+    })
+
     it('rm-link', () => {
       return ipfs('object patch rm-link QmdVHE8fUD6FLNLugtNxqDFyhaCgdob372hs6BYEe75VAK foo').then((out) => {
         expect(out).to.eql(
@@ -160,5 +229,13 @@ describe('object', () => runOnAndOff((thing) => {
         )
       })
     })
+
+    it('should rm-link and print CID encoded in specified base', () => {
+      return ipfs('object patch rm-link QmdVHE8fUD6FLNLugtNxqDFyhaCgdob372hs6BYEe75VAK foo --cid-base=base64').then((out) => {
+        expect(out).to.eql(
+          'mAXASIOOwxEKY/BwUmvv0yJlvuSQnrkHkZJuTTKSVmRt4UrhV\n'
+        )
+      })
+    })
   })
 }))
diff --git a/test/cli/pin.js b/test/cli/pin.js
index a3fc1d0b03..7fc55adb3e 100644
--- a/test/cli/pin.js
+++ b/test/cli/pin.js
@@ -3,6 +3,7 @@
 'use strict'
 
 const expect = require('chai').expect
+const CID = require('cids')
 const runOnAndOff = require('../utils/on-and-off')
 
 // fixture structure:
@@ -32,6 +33,14 @@ describe('pin', () => runOnAndOff(thing => {
       return ipfs(`pin rm ${pins.root}`)
         .then(out => expect(out).to.equal(`unpinned ${pins.root}\n`))
     })
+
+    it('should rm and print CIDs encoded in specified base', () => {
+      return ipfs(`pin rm ${pins.root} --cid-base=base64`)
+        .then(out => {
+          const b64CidStr = new CID(pins.root).toV1().toBaseEncodedString('base64')
+          expect(out).to.eql(`unpinned ${b64CidStr}\n`)
+        })
+    })
   })
 
   describe('add', function () {
@@ -48,6 +57,14 @@ describe('pin', () => runOnAndOff(thing => {
           expect(out).to.eql(`pinned ${pins.solarWiki} directly\n`)
         )
     })
+
+    it('should add and print CIDs encoded in specified base', () => {
+      return ipfs(`pin add ${pins.root} --cid-base=base64`)
+        .then(out => {
+          const b64CidStr = new CID(pins.root).toV1().toBaseEncodedString('base64')
+          expect(out).to.eql(`pinned ${b64CidStr} recursively\n`)
+        })
+    })
   })
 
   describe('ls', function () {
@@ -73,5 +90,13 @@ describe('pin', () => runOnAndOff(thing => {
         expect(firstLineParts).to.have.length(1)
       })
     })
+
+    it('should ls and print CIDs encoded in specified base', () => {
+      return ipfs(`pin ls ${pins.root} --cid-base=base64`)
+        .then(out => {
+          const b64CidStr = new CID(pins.root).toV1().toBaseEncodedString('base64')
+          expect(out).to.eql(`${b64CidStr} recursive\n`)
+        })
+    })
   })
 }))
diff --git a/test/cli/resolve.js b/test/cli/resolve.js
index 667c459e3b..3aa7bcb70c 100644
--- a/test/cli/resolve.js
+++ b/test/cli/resolve.js
@@ -4,6 +4,7 @@
 const path = require('path')
 const expect = require('chai').expect
 const isIpfs = require('is-ipfs')
+const CID = require('cids')
 
 const runOnAndOff = require('../utils/on-and-off')
 
@@ -29,7 +30,28 @@ describe('resolve', () => runOnAndOff((thing) => {
       })
   })
 
-  it('should resolve an IPFS path link', () => {
+  it('should resolve an IPFS hash and print CID encoded in specified base', function () {
+    this.timeout(10 * 1000)
+
+    const filePath = path.join(process.cwd(), '/src/init-files/init-docs/readme')
+    let b58Hash
+    let b64Hash
+
+    return ipfs(`add ${filePath}`)
+      .then((out) => {
+        b58Hash = out.split(' ')[1]
+        expect(isIpfs.cid(b58Hash)).to.be.true()
+        b64Hash = new CID(b58Hash).toV1().toBaseEncodedString('base64')
+        return ipfs(`resolve /ipfs/${b58Hash} --cid-base=base64`)
+      })
+      .then((out) => {
+        expect(out).to.contain(`/ipfs/${b64Hash}`)
+      })
+  })
+
+  it('should resolve an IPFS path link', function () {
+    this.timeout(10 * 1000)
+
     const filePath = path.join(process.cwd(), '/src/init-files/init-docs/readme')
     let fileHash, rootHash
 

From ca4a188d5a5d6a61a6e09c33afe669e7e53c44d1 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Thu, 20 Sep 2018 09:05:31 +0100
Subject: [PATCH 08/41] fix: remove redundant CID instance creates

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/bitswap/stat.js          |  6 ++----
 src/cli/commands/bitswap/unwant.js        |  6 +++---
 src/cli/commands/bitswap/wantlist.js      |  6 ++----
 src/cli/commands/block/get.js             |  7 ++-----
 src/cli/commands/block/rm.js              | 12 +++++-------
 src/cli/commands/block/stat.js            |  6 ++----
 src/cli/commands/object/get.js            | 10 +++++-----
 src/cli/commands/object/links.js          |  8 +++-----
 src/cli/commands/object/new.js            |  6 +++---
 src/cli/commands/object/patch/add-link.js | 13 +++++--------
 src/cli/commands/object/patch/rm-link.js  |  6 +++---
 src/cli/commands/object/stat.js           | 15 ++++++++++-----
 src/cli/commands/pin/add.js               |  5 ++---
 src/cli/commands/pin/ls.js                |  7 +++----
 src/cli/commands/pin/rm.js                |  6 ++----
 src/utils/cid.js                          |  2 ++
 test/cli/files.js                         |  6 ------
 17 files changed, 54 insertions(+), 73 deletions(-)

diff --git a/src/cli/commands/bitswap/stat.js b/src/cli/commands/bitswap/stat.js
index 7dd01c5946..281c83ddbf 100644
--- a/src/cli/commands/bitswap/stat.js
+++ b/src/cli/commands/bitswap/stat.js
@@ -16,10 +16,8 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    const { cidBase } = argv
-
-    argv.ipfs.bitswap.stat({ cidBase }, (err, stats) => {
+  handler ({ ipfs, cidBase }) {
+    ipfs.bitswap.stat({ cidBase }, (err, stats) => {
       if (err) {
         throw err
       }
diff --git a/src/cli/commands/bitswap/unwant.js b/src/cli/commands/bitswap/unwant.js
index 810f7946d4..f9a0627d55 100644
--- a/src/cli/commands/bitswap/unwant.js
+++ b/src/cli/commands/bitswap/unwant.js
@@ -21,12 +21,12 @@ module.exports = {
       choices: multibase.names
     }
   },
-  handler (argv) {
-    argv.ipfs.bitswap.unwant(argv.key, (err) => {
+  handler ({ ipfs, key, cidBase }) {
+    ipfs.bitswap.unwant(key, (err) => {
       if (err) {
         throw err
       }
-      print(`Key ${cidToString(argv.key, argv.cidBase)} removed from wantlist`)
+      print(`Key ${cidToString(key, cidBase)} removed from wantlist`)
     })
   }
 }
diff --git a/src/cli/commands/bitswap/wantlist.js b/src/cli/commands/bitswap/wantlist.js
index 1f9bda315f..db40b710fc 100644
--- a/src/cli/commands/bitswap/wantlist.js
+++ b/src/cli/commands/bitswap/wantlist.js
@@ -21,10 +21,8 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    const { peer, cidBase } = argv
-
-    argv.ipfs.bitswap.wantlist(peer, { cidBase }, (err, cids) => {
+  handler ({ ipfs, peer, cidBase }) {
+    ipfs.bitswap.wantlist(peer, { cidBase }, (err, cids) => {
       if (err) {
         throw err
       }
diff --git a/src/cli/commands/block/get.js b/src/cli/commands/block/get.js
index 9fb61f4434..f5c32fe0e1 100644
--- a/src/cli/commands/block/get.js
+++ b/src/cli/commands/block/get.js
@@ -1,6 +1,5 @@
 'use strict'
 
-const CID = require('cids')
 const print = require('../../utils').print
 
 module.exports = {
@@ -10,10 +9,8 @@ module.exports = {
 
   builder: {},
 
-  handler (argv) {
-    const cid = new CID(argv.key)
-
-    argv.ipfs.block.get(cid, (err, block) => {
+  handler ({ ipfs, key }) {
+    ipfs.block.get(key, (err, block) => {
       if (err) {
         throw err
       }
diff --git a/src/cli/commands/block/rm.js b/src/cli/commands/block/rm.js
index 40e1951058..7b8a27db60 100644
--- a/src/cli/commands/block/rm.js
+++ b/src/cli/commands/block/rm.js
@@ -1,8 +1,6 @@
 'use strict'
 
-const utils = require('../../utils')
-const mh = require('multihashes')
-const print = utils.print
+const { print, isDaemonOn } = require('../../utils')
 
 module.exports = {
   command: 'rm <key>',
@@ -11,18 +9,18 @@ module.exports = {
 
   builder: {},
 
-  handler (argv) {
-    if (utils.isDaemonOn()) {
+  handler ({ ipfs, key }) {
+    if (isDaemonOn()) {
       // TODO implement this once `js-ipfs-http-client` supports it
       throw new Error('rm block with daemon running is not yet implemented')
     }
 
-    argv.ipfs.block.rm(mh.fromB58String(argv.key), (err) => {
+    ipfs.block.rm(key, (err) => {
       if (err) {
         throw err
       }
 
-      print('removed ' + argv.key)
+      print('removed ' + key)
     })
   }
 }
diff --git a/src/cli/commands/block/stat.js b/src/cli/commands/block/stat.js
index 330f4e544d..77a96a3e8d 100644
--- a/src/cli/commands/block/stat.js
+++ b/src/cli/commands/block/stat.js
@@ -16,10 +16,8 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    const { key, cidBase } = argv
-
-    argv.ipfs.block.stat(key, { cidBase }, (err, stats) => {
+  handler ({ ipfs, key, cidBase }) {
+    ipfs.block.stat(key, { cidBase }, (err, stats) => {
       if (err) {
         throw err
       }
diff --git a/src/cli/commands/object/get.js b/src/cli/commands/object/get.js
index 45d8604633..59541f9ae6 100644
--- a/src/cli/commands/object/get.js
+++ b/src/cli/commands/object/get.js
@@ -22,8 +22,8 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    argv.ipfs.object.get(argv.key, { enc: 'base58' }, (err, node) => {
+  handler ({ ipfs, key, dataEncoding, cidBase }) {
+    ipfs.object.get(key, { enc: 'base58' }, (err, node) => {
       if (err) {
         throw err
       }
@@ -36,18 +36,18 @@ module.exports = {
         let data = node.data
 
         if (Buffer.isBuffer(data)) {
-          data = node.data.toString(argv.dataEncoding || undefined)
+          data = node.data.toString(dataEncoding || undefined)
         }
 
         const answer = {
           Data: data,
-          Hash: cidToString(result, argv.cidBase),
+          Hash: cidToString(result, cidBase),
           Size: node.size,
           Links: node.links.map((l) => {
             return {
               Name: l.name,
               Size: l.size,
-              Hash: cidToString(l.cid, argv.cidBase)
+              Hash: cidToString(l.cid, cidBase)
             }
           })
         }
diff --git a/src/cli/commands/object/links.js b/src/cli/commands/object/links.js
index 0fd98906ef..e820967ff8 100644
--- a/src/cli/commands/object/links.js
+++ b/src/cli/commands/object/links.js
@@ -17,16 +17,14 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    argv.ipfs.object.links(argv.key, {
-      enc: 'base58'
-    }, (err, links) => {
+  handler ({ ipfs, key, cidBase }) {
+    ipfs.object.links(key, { enc: 'base58' }, (err, links) => {
       if (err) {
         throw err
       }
 
       links.forEach((link) => {
-        print(`${cidToString(link.cid, argv.cidBase)} ${link.size} ${link.name}`)
+        print(`${cidToString(link.cid, cidBase)} ${link.size} ${link.name}`)
       })
     })
   }
diff --git a/src/cli/commands/object/new.js b/src/cli/commands/object/new.js
index 1304997691..fc73f8c313 100644
--- a/src/cli/commands/object/new.js
+++ b/src/cli/commands/object/new.js
@@ -17,13 +17,13 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    argv.ipfs.object.new(argv.template, (err, cid) => {
+  handler ({ ipfs, template, cidBase }) {
+    ipfs.object.new(template, (err, cid) => {
       if (err) {
         throw err
       }
 
-      print(cidToString(cid, argv.cidBase))
+      print(cidToString(cid, cidBase))
     })
   }
 }
diff --git a/src/cli/commands/object/patch/add-link.js b/src/cli/commands/object/patch/add-link.js
index e631d910e3..088db5d073 100644
--- a/src/cli/commands/object/patch/add-link.js
+++ b/src/cli/commands/object/patch/add-link.js
@@ -19,11 +19,8 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    const ipfs = argv.ipfs
-    ipfs.object.get(argv.ref, {
-      enc: 'base58'
-    }, (err, nodeA) => {
+  handler ({ ipfs, root, name, ref, cidBase }) {
+    ipfs.object.get(ref, { enc: 'base58' }, (err, nodeA) => {
       if (err) {
         throw err
       }
@@ -33,16 +30,16 @@ module.exports = {
           throw err
         }
 
-        const link = new DAGLink(argv.name, nodeA.size, result)
+        const link = new DAGLink(name, nodeA.size, result)
 
-        ipfs.object.patch.addLink(argv.root, link, {
+        ipfs.object.patch.addLink(root, link, {
           enc: 'base58'
         }, (err, cid) => {
           if (err) {
             throw err
           }
 
-          print(cidToString(result, argv.cidBase))
+          print(cidToString(result, cidBase))
         })
       })
     })
diff --git a/src/cli/commands/object/patch/rm-link.js b/src/cli/commands/object/patch/rm-link.js
index 63a23945f2..8763449477 100644
--- a/src/cli/commands/object/patch/rm-link.js
+++ b/src/cli/commands/object/patch/rm-link.js
@@ -17,15 +17,15 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    argv.ipfs.object.patch.rmLink(argv.root, { name: argv.link }, {
+  handler ({ ipfs, root, link, cidBase }) {
+    ipfs.object.patch.rmLink(root, { name: link }, {
       enc: 'base58'
     }, (err, cid) => {
       if (err) {
         throw err
       }
 
-      print(cidToString(cid, argv.cidBase))
+      print(cidToString(cid, cidBase))
     })
   }
 }
diff --git a/src/cli/commands/object/stat.js b/src/cli/commands/object/stat.js
index 01fbec16ff..cb4936c304 100644
--- a/src/cli/commands/object/stat.js
+++ b/src/cli/commands/object/stat.js
@@ -1,5 +1,6 @@
 'use strict'
 
+const multibase = require('multibase')
 const print = require('../../utils').print
 
 module.exports = {
@@ -7,12 +8,16 @@ module.exports = {
 
   describe: 'Get stats for the DAG node named by <key>',
 
-  builder: {},
+  builder: {
+    'cid-base': {
+      describe: 'Number base to display CIDs in.',
+      type: 'string',
+      choices: multibase.names
+    }
+  },
 
-  handler (argv) {
-    argv.ipfs.object.stat(argv.key, {
-      enc: 'base58'
-    }, (err, stats) => {
+  handler ({ ipfs, key, cidBase }) {
+    ipfs.object.stat(key, { enc: 'base58', cidBase }, (err, stats) => {
       if (err) {
         throw err
       }
diff --git a/src/cli/commands/pin/add.js b/src/cli/commands/pin/add.js
index c5cce29ee4..486d71e6f9 100644
--- a/src/cli/commands/pin/add.js
+++ b/src/cli/commands/pin/add.js
@@ -22,11 +22,10 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    const { recursive, cidBase } = argv
+  handler ({ ipfs, ipfsPath, recursive, cidBase }) {
     const type = recursive ? 'recursive' : 'direct'
 
-    argv.ipfs.pin.add(argv.ipfsPath, { recursive, cidBase }, (err, results) => {
+    ipfs.pin.add(ipfsPath, { recursive, cidBase }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
         print(`pinned ${res.hash} ${type}ly`)
diff --git a/src/cli/commands/pin/ls.js b/src/cli/commands/pin/ls.js
index 2f101e1a37..a871438abb 100644
--- a/src/cli/commands/pin/ls.js
+++ b/src/cli/commands/pin/ls.js
@@ -30,11 +30,10 @@ module.exports = {
     }
   },
 
-  handler: (argv) => {
-    const paths = argv.ipfsPath
-    const { type, quiet, cidBase } = argv
+  handler: ({ ipfs, ipfsPath, type, quiet, cidBase }) => {
+    const paths = ipfsPath
 
-    argv.ipfs.pin.ls(paths, { type, cidBase }, (err, results) => {
+    ipfs.pin.ls(paths, { type, cidBase }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
         let line = res.hash
diff --git a/src/cli/commands/pin/rm.js b/src/cli/commands/pin/rm.js
index 37c9b1bcd6..1779df30f4 100644
--- a/src/cli/commands/pin/rm.js
+++ b/src/cli/commands/pin/rm.js
@@ -23,10 +23,8 @@ module.exports = {
     }
   },
 
-  handler: (argv) => {
-    const { recursive, cidBase } = argv
-
-    argv.ipfs.pin.rm(argv.ipfsPath, { recursive, cidBase }, (err, results) => {
+  handler: ({ ipfs, ipfsPath, recursive, cidBase }) => {
+    ipfs.pin.rm(ipfsPath, { recursive, cidBase }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
         print(`unpinned ${cidToString(res.hash, argv.cidBase)}`)
diff --git a/src/utils/cid.js b/src/utils/cid.js
index 6431133a9f..56f1b8fa60 100644
--- a/src/utils/cid.js
+++ b/src/utils/cid.js
@@ -1,3 +1,5 @@
+'use strict'
+
 const CID = require('cids')
 
 // Stringify a CID in the requested base, auto-converting to v1 if necessary
diff --git a/test/cli/files.js b/test/cli/files.js
index bd9409f872..60f8bb0798 100644
--- a/test/cli/files.js
+++ b/test/cli/files.js
@@ -366,15 +366,9 @@ describe('files', () => runOnAndOff((thing) => {
   it('should add and print CID encoded in specified base', function () {
     this.timeout(30 * 1000)
 
-<<<<<<< HEAD
     return ipfs('add test/fixtures/test-data/hello --cid-base=base64')
       .then((out) => {
         expect(out).to.eql('added mAXASIKlIkE8vD0ebj4GXaUswGEsNLtHBzSoewPuF0pmhkqRH hello\n')
-=======
-    return ipfs('add test/fixtures/test-data/hello --cid-base=base32')
-      .then((out) => {
-        expect(out).to.eql('added bafybeicg2rebjoofv4kbyovkw7af3rpiitvnl6i7ckcywaq6xjcxnc2mby hello\n')
->>>>>>> feat: add cid-base option for files.add*
       })
   })
 

From c393f1f2029e0312f9e54fb6ed8c9dbe41be3024 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Thu, 20 Sep 2018 09:48:11 +0100
Subject: [PATCH 09/41] fix: remove unnecessary CID to string

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/pin/rm.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/cli/commands/pin/rm.js b/src/cli/commands/pin/rm.js
index 1779df30f4..f28a6270a6 100644
--- a/src/cli/commands/pin/rm.js
+++ b/src/cli/commands/pin/rm.js
@@ -2,7 +2,6 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
-const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'rm <ipfsPath...>',
@@ -27,7 +26,7 @@ module.exports = {
     ipfs.pin.rm(ipfsPath, { recursive, cidBase }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        print(`unpinned ${cidToString(res.hash, argv.cidBase)}`)
+        print(`unpinned ${res.hash}`)
       })
     })
   }

From 3577f1f7b15998237e965409ec13bd177da8f156 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Thu, 20 Sep 2018 10:03:51 +0100
Subject: [PATCH 10/41] fix: remove duplicated logic

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/block/put.js | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/src/cli/commands/block/put.js b/src/cli/commands/block/put.js
index 1606ee6ded..d3f0d9c5a7 100644
--- a/src/cli/commands/block/put.js
+++ b/src/cli/commands/block/put.js
@@ -1,35 +1,19 @@
 'use strict'
 
-const CID = require('cids')
-const multihashing = require('multihashing-async')
 const bl = require('bl')
 const fs = require('fs')
-const Block = require('ipfs-block')
-const waterfall = require('async/waterfall')
 const multibase = require('multibase')
 const { print } = require('../../utils')
 const { cidToString } = require('../../../utils/cid')
 
 function addBlock (data, opts) {
   const ipfs = opts.ipfs
-  let cid
 
-  waterfall([
-    (cb) => multihashing(data, opts.mhtype || 'sha2-256', cb),
-    (multihash, cb) => {
-      if (opts.format !== 'dag-pb' || opts.version !== 0) {
-        cid = new CID(1, opts.format || 'dag-pb', multihash)
-      } else {
-        cid = new CID(0, 'dag-pb', multihash)
-      }
-
-      ipfs.block.put(new Block(data, cid), cb)
-    }
-  ], (err) => {
+  ipfs.block.put(data, (err, block) => {
     if (err) {
       throw err
     }
-    print(cidToString(cid, opts.cidBase))
+    print(cidToString(block.cid, opts.cidBase))
   })
 }
 

From 53867a99c1d0741577d08e88636461e4c8d7c6e4 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Thu, 20 Sep 2018 10:22:59 +0100
Subject: [PATCH 11/41] fix: pick appropriate CID version

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/block/put.js |  5 ++---
 src/core/components/block.js  | 18 ++++++++++++++++--
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/cli/commands/block/put.js b/src/cli/commands/block/put.js
index d3f0d9c5a7..c94cde08cf 100644
--- a/src/cli/commands/block/put.js
+++ b/src/cli/commands/block/put.js
@@ -9,7 +9,7 @@ const { cidToString } = require('../../../utils/cid')
 function addBlock (data, opts) {
   const ipfs = opts.ipfs
 
-  ipfs.block.put(data, (err, block) => {
+  ipfs.block.put(data, opts, (err, block) => {
     if (err) {
       throw err
     }
@@ -38,8 +38,7 @@ module.exports = {
     },
     version: {
       describe: 'cid version',
-      type: 'number',
-      default: 0
+      type: 'number'
     },
     'cid-base': {
       describe: 'Number base to display CIDs in.',
diff --git a/src/core/components/block.js b/src/core/components/block.js
index 6eba812302..5a113d44c0 100644
--- a/src/core/components/block.js
+++ b/src/core/components/block.js
@@ -58,15 +58,29 @@ module.exports = function block (self) {
 
           const mhtype = options.mhtype || 'sha2-256'
           const format = options.format || 'dag-pb'
-          const cidVersion = options.version || 0
+          let cidVersion
           // const mhlen = options.mhlen || 0
 
+          if (options.version == null) {
+            // Pick appropriate CID version
+            cidVersion = mhtype === 'sha2-256' && format === 'dag-pb' ? 0 : 1
+          } else {
+            cidVersion = options.version
+          }
+
           multihashing(block, mhtype, (err, multihash) => {
             if (err) {
               return cb(err)
             }
 
-            cb(null, new Block(block, new CID(cidVersion, format, multihash)))
+            let cid
+            try {
+              cid = new CID(cidVersion, format, multihash)
+            } catch (err) {
+              return cb(err)
+            }
+
+            cb(null, new Block(block, cid))
           })
         },
         (block, cb) => self._blockService.put(block, (err) => {

From 77d1e442f39b4cfbe7f8ec05e50c69ee27e3ee18 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Thu, 20 Sep 2018 10:28:20 +0100
Subject: [PATCH 12/41] fix: simplify ls

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/ls.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/cli/commands/ls.js b/src/cli/commands/ls.js
index cb882836fb..7e05e7acf0 100644
--- a/src/cli/commands/ls.js
+++ b/src/cli/commands/ls.js
@@ -33,22 +33,22 @@ module.exports = {
     }
   },
 
-  handler (argv) {
-    argv.ipfs.ls(argv.key, { recursive: argv.recursive, cidBase: argv.cidBase }, (err, links) => {
+  handler ({ ipfs, key, recursive, headers, cidBase }) {
+    ipfs.ls(key, { recursive, cidBase }, (err, links) => {
       if (err) {
         throw err
       }
 
-      if (argv.headers) {
+      if (headers) {
         links = [{ hash: 'Hash', size: 'Size', name: 'Name' }].concat(links)
       }
 
       const multihashWidth = Math.max.apply(null, links.map((file) => file.hash.length))
       const sizeWidth = Math.max.apply(null, links.map((file) => String(file.size).length))
 
-      let pathParts = argv.key.split('/')
+      let pathParts = key.split('/')
 
-      if (argv.key.startsWith('/ipfs/')) {
+      if (key.startsWith('/ipfs/')) {
         pathParts = pathParts.slice(2)
       }
 

From 414d7794cee0e24225599408dcff07d7e190c145 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Tue, 13 Nov 2018 19:56:03 +0000
Subject: [PATCH 13/41] test: add HTTP API tests for bitswap cid-base option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/http/api/resources/bitswap.js |  2 +-
 src/http/api/routes/bitswap.js    |  9 ++--
 src/http/api/routes/object.js     | 27 +++++++----
 test/http-api/inject/bitswap.js   | 78 +++++++++++++++++++++++++++++++
 4 files changed, 103 insertions(+), 13 deletions(-)

diff --git a/src/http/api/resources/bitswap.js b/src/http/api/resources/bitswap.js
index 8a6304d159..c412ccb954 100644
--- a/src/http/api/resources/bitswap.js
+++ b/src/http/api/resources/bitswap.js
@@ -23,7 +23,7 @@ exports.wantlist = {
       if (err) {
         return reply(boom.badRequest(err))
       }
-      reply({ Keys: list })
+      reply({ Keys: list.map(cid => ({ '/': cid })) })
     })
   }
 }
diff --git a/src/http/api/routes/bitswap.js b/src/http/api/routes/bitswap.js
index 04def2fb91..45be830b6d 100644
--- a/src/http/api/routes/bitswap.js
+++ b/src/http/api/routes/bitswap.js
@@ -9,7 +9,8 @@ module.exports = (server) => {
     method: '*',
     path: '/api/v0/bitswap/wantlist',
     config: {
-      handler: resources.bitswap.wantlist.handler
+      handler: resources.bitswap.wantlist.handler,
+      validate: resources.bitswap.wantlist.validate
     }
   })
 
@@ -17,7 +18,8 @@ module.exports = (server) => {
     method: '*',
     path: '/api/v0/bitswap/stat',
     config: {
-      handler: resources.bitswap.stat.handler
+      handler: resources.bitswap.stat.handler,
+      validate: resources.bitswap.stat.validate
     }
   })
 
@@ -28,7 +30,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.bitswap.unwant.parseArgs, assign: 'args' }
       ],
-      handler: resources.bitswap.unwant.handler
+      handler: resources.bitswap.unwant.handler,
+      validate: resources.bitswap.unwant.validate
     }
   })
 }
diff --git a/src/http/api/routes/object.js b/src/http/api/routes/object.js
index 51d7ba9fe9..407b6c58a0 100644
--- a/src/http/api/routes/object.js
+++ b/src/http/api/routes/object.js
@@ -9,7 +9,8 @@ module.exports = (server) => {
     method: '*',
     path: '/api/v0/object/new',
     config: {
-      handler: resources.object.new
+      handler: resources.object.new.handler,
+      validate: resources.object.new.validate
     }
   })
 
@@ -20,7 +21,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.get.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.get.handler
+      handler: resources.object.get.handler,
+      validate: resources.object.get.validate
     }
   })
 
@@ -35,7 +37,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.put.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.put.handler
+      handler: resources.object.put.handler,
+      validate: resources.object.put.validate
     }
   })
 
@@ -46,7 +49,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.stat.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.stat.handler
+      handler: resources.object.stat.handler,
+      validate: resources.object.stat.validate
     }
   })
 
@@ -68,7 +72,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.links.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.links.handler
+      handler: resources.object.links.handler,
+      validate: resources.object.links.validate
     }
   })
 
@@ -83,7 +88,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.patchAppendData.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.patchAppendData.handler
+      handler: resources.object.patchAppendData.handler,
+      validate: resources.object.patchAppendData.validate
     }
   })
 
@@ -98,7 +104,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.patchSetData.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.patchSetData.handler
+      handler: resources.object.patchSetData.handler,
+      validate: resources.object.patchSetData.validate
     }
   })
 
@@ -109,7 +116,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.patchAddLink.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.patchAddLink.handler
+      handler: resources.object.patchAddLink.handler,
+      validate: resources.object.patchAddLink.validate
     }
   })
 
@@ -120,7 +128,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.object.patchRmLink.parseArgs, assign: 'args' }
       ],
-      handler: resources.object.patchRmLink.handler
+      handler: resources.object.patchRmLink.handler,
+      validate: resources.object.patchRmLink.validate
     }
   })
 }
diff --git a/test/http-api/inject/bitswap.js b/test/http-api/inject/bitswap.js
index 16e2c6ceef..7855774f35 100644
--- a/test/http-api/inject/bitswap.js
+++ b/test/http-api/inject/bitswap.js
@@ -2,15 +2,46 @@
 'use strict'
 
 const expect = require('chai').expect
+const CID = require('cids')
+const waitFor = require('../../utils/wait-for')
 
 module.exports = (http) => {
   describe('/bitswap', () => {
+    const wantedCid = 'QmUBdnXXPyoDFXj3Hj39dNJ5VkN3QFRskXxcGaYFBB8CNR'
     let api
 
     before(() => {
       api = http.api.server.select('API')
     })
 
+    before(function (done) {
+      this.timeout(120 * 1000)
+
+      // Add a CID to the wantlist
+      api.inject({
+        method: 'GET',
+        url: `/api/v0/block/get?arg=${wantedCid}`
+      })
+
+      const test = (cb) => {
+        api.inject({
+          method: 'GET',
+          url: '/api/v0/bitswap/wantlist'
+        }, (res) => {
+          if (res.statusCode !== 200) {
+            return cb(new Error(`unexpected status ${res.statusCode}`))
+          }
+          const wanted = !!res.result.Keys.find(k => k['/'] === wantedCid)
+          cb(null, wanted)
+        })
+      }
+
+      waitFor(test, {
+        name: wantedCid + ' to be wanted',
+        timeout: 60 * 1000
+      }, done)
+    })
+
     it('/wantlist', (done) => {
       api.inject({
         method: 'GET',
@@ -18,6 +49,30 @@ module.exports = (http) => {
       }, (res) => {
         expect(res.statusCode).to.equal(200)
         expect(res.result).to.have.property('Keys')
+        expect(res.result.Keys).to.deep.include({ '/': wantedCid })
+        done()
+      })
+    })
+
+    it('/wantlist?cid-base=base64', (done) => {
+      const base64Cid = new CID(wantedCid).toV1().toString('base64')
+      api.inject({
+        method: 'GET',
+        url: '/api/v0/bitswap/wantlist?cid-base=base64'
+      }, (res) => {
+        expect(res.statusCode).to.equal(200)
+        expect(res.result.Keys).to.deep.include({ '/': base64Cid })
+        done()
+      })
+    })
+
+    it('/wantlist?cid-base=invalid', (done) => {
+      api.inject({
+        method: 'GET',
+        url: '/api/v0/bitswap/wantlist?cid-base=invalid'
+      }, (res) => {
+        expect(res.statusCode).to.equal(400)
+        expect(res.result.Message).to.include('child "cid-base" fails')
         done()
       })
     })
@@ -40,5 +95,28 @@ module.exports = (http) => {
         done()
       })
     })
+
+    it('/stat?cid-base=base64', (done) => {
+      const base64Cid = new CID(wantedCid).toV1().toString('base64')
+      api.inject({
+        method: 'GET',
+        url: '/api/v0/bitswap/stat?cid-base=base64'
+      }, (res) => {
+        expect(res.statusCode).to.equal(200)
+        expect(res.result.Wantlist).to.deep.include({ '/': base64Cid })
+        done()
+      })
+    })
+
+    it('/stat?cid-base=invalid', (done) => {
+      api.inject({
+        method: 'GET',
+        url: '/api/v0/bitswap/stat?cid-base=invalid'
+      }, (res) => {
+        expect(res.statusCode).to.equal(400)
+        expect(res.result.Message).to.include('child "cid-base" fails')
+        done()
+      })
+    })
   })
 }

From 49d70fa5ffa451a311d4915c13a34980a99434b8 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Tue, 13 Nov 2018 20:10:44 +0000
Subject: [PATCH 14/41] test: add HTTP API tests for block.put with cid-base
 option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/http/api/resources/block.js |  2 +-
 src/http/api/routes/block.js    | 15 ++++++-----
 test/http-api/inject/block.js   | 44 +++++++++++++++++++++++++++++++++
 3 files changed, 54 insertions(+), 7 deletions(-)

diff --git a/src/http/api/resources/block.js b/src/http/api/resources/block.js
index ffd961022b..a8abdd3f40 100644
--- a/src/http/api/resources/block.js
+++ b/src/http/api/resources/block.js
@@ -126,7 +126,7 @@ exports.put = {
   }
 }
 
-exports.del = {
+exports.rm = {
   // uses common parseKey method that returns a `key`
   parseArgs: exports.parseKey,
 
diff --git a/src/http/api/routes/block.js b/src/http/api/routes/block.js
index 0ee4ca6204..51bd0bdf61 100644
--- a/src/http/api/routes/block.js
+++ b/src/http/api/routes/block.js
@@ -12,7 +12,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.block.get.parseArgs, assign: 'args' }
       ],
-      handler: resources.block.get.handler
+      handler: resources.block.get.handler,
+      validate: resources.block.get.validate
     }
   })
 
@@ -27,18 +28,19 @@ module.exports = (server) => {
       pre: [
         { method: resources.block.put.parseArgs, assign: 'args' }
       ],
-      handler: resources.block.put.handler
+      handler: resources.block.put.handler,
+      validate: resources.block.put.validate
     }
   })
 
   api.route({
     method: '*',
-    path: '/api/v0/block/del',
+    path: '/api/v0/block/rm',
     config: {
       pre: [
-        { method: resources.block.del.parseArgs, assign: 'args' }
+        { method: resources.block.rm.parseArgs, assign: 'args' }
       ],
-      handler: resources.block.del.handler
+      handler: resources.block.rm.handler
     }
   })
 
@@ -49,7 +51,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.block.stat.parseArgs, assign: 'args' }
       ],
-      handler: resources.block.stat.handler
+      handler: resources.block.stat.handler,
+      validate: resources.block.stat.validate
     }
   })
 }
diff --git a/test/http-api/inject/block.js b/test/http-api/inject/block.js
index 643fd0b766..9875425332 100644
--- a/test/http-api/inject/block.js
+++ b/test/http-api/inject/block.js
@@ -56,6 +56,50 @@ module.exports = (http) => {
           })
         })
       })
+
+      it('should put a value and return a base64 encoded CID', (done) => {
+        const form = new FormData()
+        const filePath = 'test/fixtures/test-data/hello'
+        form.append('data', fs.createReadStream(filePath))
+        const headers = form.getHeaders()
+        const expectedResult = {
+          Key: 'mAXASIKlIkE8vD0ebj4GXaUswGEsNLtHBzSoewPuF0pmhkqRH',
+          Size: 12
+        }
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/block/put?cid-base=base64',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(res.result).to.deep.equal(expectedResult)
+            done()
+          })
+        })
+      })
+
+      it('should not put a value for invalid cid-base option', (done) => {
+        const form = new FormData()
+        const filePath = 'test/fixtures/test-data/hello'
+        form.append('data', fs.createReadStream(filePath))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/block/put?cid-base=invalid',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
 
     describe('/block/get', () => {

From 258978278cbd1f8ffb4aa27967834c54370dcc89 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 14 Nov 2018 10:21:49 +0000
Subject: [PATCH 15/41] test: add HTTP API tests for block.stat with cid-base
 option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/http/api/routes/block.js  |  3 +-
 test/http-api/inject/block.js | 61 +++++++++++++++++++++++++++--------
 2 files changed, 48 insertions(+), 16 deletions(-)

diff --git a/src/http/api/routes/block.js b/src/http/api/routes/block.js
index 51bd0bdf61..03d8159876 100644
--- a/src/http/api/routes/block.js
+++ b/src/http/api/routes/block.js
@@ -12,8 +12,7 @@ module.exports = (server) => {
       pre: [
         { method: resources.block.get.parseArgs, assign: 'args' }
       ],
-      handler: resources.block.get.handler,
-      validate: resources.block.get.validate
+      handler: resources.block.get.handler
     }
   })
 
diff --git a/test/http-api/inject/block.js b/test/http-api/inject/block.js
index 9875425332..76e6bf8cff 100644
--- a/test/http-api/inject/block.js
+++ b/test/http-api/inject/block.js
@@ -6,9 +6,10 @@ const expect = require('chai').expect
 const fs = require('fs')
 const FormData = require('form-data')
 const streamToPromise = require('stream-to-promise')
+const multibase = require('multibase')
 
 module.exports = (http) => {
-  describe('/block', () => {
+  describe.only('/block', () => {
     let api
 
     before(() => {
@@ -59,13 +60,8 @@ module.exports = (http) => {
 
       it('should put a value and return a base64 encoded CID', (done) => {
         const form = new FormData()
-        const filePath = 'test/fixtures/test-data/hello'
-        form.append('data', fs.createReadStream(filePath))
+        form.append('data', Buffer.from('TEST' + Date.now()))
         const headers = form.getHeaders()
-        const expectedResult = {
-          Key: 'mAXASIKlIkE8vD0ebj4GXaUswGEsNLtHBzSoewPuF0pmhkqRH',
-          Size: 12
-        }
 
         streamToPromise(form).then((payload) => {
           api.inject({
@@ -75,7 +71,7 @@ module.exports = (http) => {
             payload: payload
           }, (res) => {
             expect(res.statusCode).to.equal(200)
-            expect(res.result).to.deep.equal(expectedResult)
+            expect(multibase.isEncoded(res.result.Key)).to.deep.equal('base64')
             done()
           })
         })
@@ -83,8 +79,7 @@ module.exports = (http) => {
 
       it('should not put a value for invalid cid-base option', (done) => {
         const form = new FormData()
-        const filePath = 'test/fixtures/test-data/hello'
-        form.append('data', fs.createReadStream(filePath))
+        form.append('data', Buffer.from('TEST' + Date.now()))
         const headers = form.getHeaders()
 
         streamToPromise(form).then((payload) => {
@@ -175,13 +170,51 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should stat a block and return a base64 encoded CID', (done) => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/block/put?cid-base=base64',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Key)).to.deep.equal('base64')
+            done()
+          })
+        })
+      })
+
+      it('should not stat a block for invalid cid-base option', (done) => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/block/put?cid-base=invalid',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
 
-    describe('/block/del', () => {
+    describe('/block/rm', () => {
       it('returns 400 for request without argument', (done) => {
         api.inject({
           method: 'GET',
-          url: '/api/v0/block/del'
+          url: '/api/v0/block/rm'
         }, (res) => {
           expect(res.statusCode).to.equal(400)
           expect(res.result).to.be.a('string')
@@ -192,7 +225,7 @@ module.exports = (http) => {
       it('returns 500 for request with invalid argument', (done) => {
         api.inject({
           method: 'GET',
-          url: '/api/v0/block/del?arg=invalid'
+          url: '/api/v0/block/rm?arg=invalid'
         }, (res) => {
           expect(res.statusCode).to.equal(500)
           expect(res.result.Code).to.equal(0)
@@ -204,7 +237,7 @@ module.exports = (http) => {
       it('returns 200', (done) => {
         api.inject({
           method: 'GET',
-          url: '/api/v0/block/del?arg=QmZjTnYw2TFhn9Nn7tjmPSoTBoY7YRkwPzwSrSbabY24Kp'
+          url: '/api/v0/block/rm?arg=QmZjTnYw2TFhn9Nn7tjmPSoTBoY7YRkwPzwSrSbabY24Kp'
         }, (res) => {
           expect(res.statusCode).to.equal(200)
           done()

From ba32660468634387490866dfede8a5a22c1cec21 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 14 Nov 2018 15:35:52 +0000
Subject: [PATCH 16/41] test: add HTTP API test for add with cid-base option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/block.js |  2 +-
 test/http-api/inject/files.js | 43 +++++++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+), 1 deletion(-)

diff --git a/test/http-api/inject/block.js b/test/http-api/inject/block.js
index 76e6bf8cff..efa44a9212 100644
--- a/test/http-api/inject/block.js
+++ b/test/http-api/inject/block.js
@@ -9,7 +9,7 @@ const streamToPromise = require('stream-to-promise')
 const multibase = require('multibase')
 
 module.exports = (http) => {
-  describe.only('/block', () => {
+  describe('/block', () => {
     let api
 
     before(() => {
diff --git a/test/http-api/inject/files.js b/test/http-api/inject/files.js
index 86c7f7dbcb..03d3b097d7 100644
--- a/test/http-api/inject/files.js
+++ b/test/http-api/inject/files.js
@@ -3,6 +3,9 @@
 
 const crypto = require('crypto')
 const expect = require('chai').expect
+const FormData = require('form-data')
+const streamToPromise = require('stream-to-promise')
+const multibase = require('multibase')
 
 module.exports = (http) => {
   describe('/files', () => {
@@ -37,6 +40,46 @@ module.exports = (http) => {
           done()
         })
       })
+
+      // TODO: unskip when we can retrieve data from the repo with a different
+      // version CID then it was added with.
+      it.skip('should add data and return a base64 encoded CID', (done) => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add?cid-base=base64',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(JSON.parse(res.result).Hash)).to.deep.equal('base64')
+            done()
+          })
+        }).catch(err => console.error(err))
+      })
+
+      it('should add data without pinning and return a base64 encoded CID', (done) => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add?cid-base=base64&pin=false',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(JSON.parse(res.result).Hash)).to.deep.equal('base64')
+            done()
+          })
+        }).catch(err => console.error(err))
+      })
     })
 
     describe('/cat', () => {

From 79378b62bc65a85f91f0f7c56e73f4a3729b06e6 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 14 Nov 2018 17:08:12 +0000
Subject: [PATCH 17/41] test: add HTTP API test for ls with cid-base option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/files.js | 37 ++++++++++++++++++++++++++++++++---
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/test/http-api/inject/files.js b/test/http-api/inject/files.js
index 03d3b097d7..320dd6843b 100644
--- a/test/http-api/inject/files.js
+++ b/test/http-api/inject/files.js
@@ -59,7 +59,7 @@ module.exports = (http) => {
             expect(multibase.isEncoded(JSON.parse(res.result).Hash)).to.deep.equal('base64')
             done()
           })
-        }).catch(err => console.error(err))
+        })
       })
 
       it('should add data without pinning and return a base64 encoded CID', (done) => {
@@ -78,7 +78,7 @@ module.exports = (http) => {
             expect(multibase.isEncoded(JSON.parse(res.result).Hash)).to.deep.equal('base64')
             done()
           })
-        }).catch(err => console.error(err))
+        })
       })
     })
 
@@ -121,6 +121,37 @@ module.exports = (http) => {
 
     describe('/get', () => {}) // TODO
 
-    describe('/ls', () => {}) // TODO
+    describe('/ls', () => {
+      it('should list directory contents and return a base64 encoded CIDs', (done) => {
+        const form = new FormData()
+        form.append('file', Buffer.from('TEST' + Date.now()), { filename: 'data.txt' })
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add?wrap-with-directory=true',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+
+            const files = res.result.trim().split('\n').map(r => JSON.parse(r))
+            const dir = files[files.length - 1]
+
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/ls?cid-base=base64&arg=' + dir.Hash
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              res.result.Objects.forEach(item => {
+                expect(multibase.isEncoded(item.Hash)).to.deep.equal('base64')
+              })
+              done()
+            })
+          })
+        })
+      })
+    })
   })
 }

From a896818cafa51053ff0e278df7a99d7c01a94bcb Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Wed, 14 Nov 2018 21:48:10 +0000
Subject: [PATCH 18/41] test: add HTTP API tests for object.new/get/put with
 cid-base

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/object.js | 49 ++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/test/http-api/inject/object.js b/test/http-api/inject/object.js
index b3bf547c8a..4d490b36f5 100644
--- a/test/http-api/inject/object.js
+++ b/test/http-api/inject/object.js
@@ -10,6 +10,7 @@ chai.use(dirtyChai)
 const fs = require('fs')
 const FormData = require('form-data')
 const streamToPromise = require('stream-to-promise')
+const multibase = require('multibase')
 
 module.exports = (http) => {
   describe('/object', () => {
@@ -32,6 +33,17 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should create a new object and return a base64 encoded CID', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new?cid-base=base64'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+          expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+          done()
+        })
+      })
     })
 
     describe('/get', () => {
@@ -69,6 +81,24 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should get object and return a base64 encoded CID', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/get?cid-base=base64&arg=' + res.result.Hash
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+            done()
+          })
+        })
+      })
     })
 
     describe('/put', () => {
@@ -138,6 +168,25 @@ module.exports = (http) => {
           })
         })
       })
+
+      it('should put data and return a base64 encoded CID', (done) => {
+        const form = new FormData()
+        form.append('file', JSON.stringify({ Data: 'TEST' + Date.now(), Links: [] }), { filename: 'node.json' })
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/put?cid-base=base64',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+            done()
+          })
+        })
+      })
     })
 
     describe('/stat', () => {

From af34fdf16e30ea7824ff9ae12a17feebed73713b Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 16 Nov 2018 12:44:55 +0000
Subject: [PATCH 19/41] test: add HTTP API tests for object.* with cid-base
 option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/object.js | 411 +++++++++++++++++++++++++++++++++
 1 file changed, 411 insertions(+)

diff --git a/test/http-api/inject/object.js b/test/http-api/inject/object.js
index 4d490b36f5..232ddc1922 100644
--- a/test/http-api/inject/object.js
+++ b/test/http-api/inject/object.js
@@ -11,6 +11,7 @@ const fs = require('fs')
 const FormData = require('form-data')
 const streamToPromise = require('stream-to-promise')
 const multibase = require('multibase')
+const waterfall = require('async/waterfall')
 
 module.exports = (http) => {
   describe('/object', () => {
@@ -44,6 +45,17 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should not create a new object for invalid cid-base option', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new?cid-base=invalid'
+        }, (res) => {
+          expect(res.statusCode).to.equal(400)
+          expect(res.result.Message).to.include('child "cid-base" fails')
+          done()
+        })
+      })
     })
 
     describe('/get', () => {
@@ -99,6 +111,24 @@ module.exports = (http) => {
           })
         })
       })
+
+      it('should not get an object for invalid cid-base option', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/get?cid-base=invalid&arg=' + res.result.Hash
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
 
     describe('/put', () => {
@@ -187,6 +217,25 @@ module.exports = (http) => {
           })
         })
       })
+
+      it('should not put data for invalid cid-base option', (done) => {
+        const form = new FormData()
+        form.append('file', JSON.stringify({ Data: 'TEST' + Date.now(), Links: [] }), { filename: 'node.json' })
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/put?cid-base=invalid',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
 
     describe('/stat', () => {
@@ -228,6 +277,42 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should stat object and return a base64 encoded CID', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/stat?cid-base=base64&arg=' + res.result.Hash
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+            done()
+          })
+        })
+      })
+
+      it('should not stat object for invalid cid-base option', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/stat?cid-base=invalid&arg=' + res.result.Hash
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
 
     describe('/data', () => {
@@ -307,6 +392,98 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should list object links and return a base64 encoded CID', (done) => {
+        waterfall([
+          (cb) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/new'
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              cb(null, res.result.Hash)
+            })
+          },
+          (linkHash, cb) => {
+            const form = new FormData()
+            form.append('file', JSON.stringify({
+              Data: 'TEST' + Date.now(),
+              Links: [{ Name: 'emptyNode', Hash: linkHash, Size: 8 }]
+            }), { filename: 'node.json' })
+            const headers = form.getHeaders()
+
+            streamToPromise(form).then((payload) => {
+              api.inject({
+                method: 'POST',
+                url: '/api/v0/object/put',
+                headers: headers,
+                payload: payload
+              }, (res) => {
+                expect(res.statusCode).to.equal(200)
+                cb(null, res.result.Hash)
+              })
+            })
+          }
+        ], (err, hash) => {
+          expect(err).to.not.exist()
+
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/links?cid-base=base64&arg=' + hash
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+            expect(res.result.Links).to.have.length(1)
+            expect(multibase.isEncoded(res.result.Links[0].Hash)).to.deep.equal('base64')
+            done()
+          })
+        })
+      })
+
+      it('should not list object links for invalid cid-base option', (done) => {
+        waterfall([
+          (cb) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/new'
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              cb(null, res.result.Hash)
+            })
+          },
+          (linkHash, cb) => {
+            const form = new FormData()
+            form.append('file', JSON.stringify({
+              Data: 'TEST' + Date.now(),
+              Links: [{ Name: 'emptyNode', Hash: linkHash, Size: 8 }]
+            }), { filename: 'node.json' })
+            const headers = form.getHeaders()
+
+            streamToPromise(form).then((payload) => {
+              api.inject({
+                method: 'POST',
+                url: '/api/v0/object/put',
+                headers: headers,
+                payload: payload
+              }, (res) => {
+                expect(res.statusCode).to.equal(200)
+                cb(null, res.result.Hash)
+              })
+            })
+          }
+        ], (err, hash) => {
+          expect(err).to.not.exist()
+
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/object/links?cid-base=invalid&arg=' + hash
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
 
     describe('/patch/append-data', () => {
@@ -382,6 +559,58 @@ module.exports = (http) => {
           })
         })
       })
+
+      it('should append data to object and return a base64 encoded CID', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          const form = new FormData()
+          form.append('data', Buffer.from('TEST' + Date.now()))
+          const headers = form.getHeaders()
+
+          streamToPromise(form).then((payload) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/patch/append-data?cid-base=base64&arg=' + res.result.Hash,
+              headers: headers,
+              payload: payload
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+              done()
+            })
+          })
+        })
+      })
+
+      it('should not append data to object for invalid cid-base option', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          const form = new FormData()
+          form.append('data', Buffer.from('TEST' + Date.now()))
+          const headers = form.getHeaders()
+
+          streamToPromise(form).then((payload) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/patch/append-data?cid-base=invalid&arg=' + res.result.Hash,
+              headers: headers,
+              payload: payload
+            }, (res) => {
+              expect(res.statusCode).to.equal(400)
+              expect(res.result.Message).to.include('child "cid-base" fails')
+              done()
+            })
+          })
+        })
+      })
     })
 
     describe('/patch/set-data', () => {
@@ -455,6 +684,58 @@ module.exports = (http) => {
           })
         })
       })
+
+      it('should set data for object and return a base64 encoded CID', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          const form = new FormData()
+          form.append('data', Buffer.from('TEST' + Date.now()))
+          const headers = form.getHeaders()
+
+          streamToPromise(form).then((payload) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/patch/set-data?cid-base=base64&arg=' + res.result.Hash,
+              headers: headers,
+              payload: payload
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+              done()
+            })
+          })
+        })
+      })
+
+      it('should not set data for object for invalid cid-base option', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          const form = new FormData()
+          form.append('data', Buffer.from('TEST' + Date.now()))
+          const headers = form.getHeaders()
+
+          streamToPromise(form).then((payload) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/patch/set-data?cid-base=invalid&arg=' + res.result.Hash,
+              headers: headers,
+              payload: payload
+            }, (res) => {
+              expect(res.statusCode).to.equal(400)
+              expect(res.result.Message).to.include('child "cid-base" fails')
+              done()
+            })
+          })
+        })
+      })
     })
 
     describe('/patch/add-link', () => {
@@ -519,6 +800,42 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should add a link to an object and return a base64 encoded CID', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          api.inject({
+            method: 'POST',
+            url: `/api/v0/object/patch/add-link?cid-base=base64&arg=${res.result.Hash}&arg=test&arg=${res.result.Hash}`
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+            done()
+          })
+        })
+      })
+
+      it('should not add a link to an object for invalid cid-base option', (done) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/object/new'
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+
+          api.inject({
+            method: 'POST',
+            url: `/api/v0/object/patch/add-link?cid-base=invalid&arg=${res.result.Hash}&arg=test&arg=${res.result.Hash}`
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
 
     describe('/patch/rm-link', () => {
@@ -578,6 +895,100 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should remove a link from an object and return a base64 encoded CID', (done) => {
+        const linkName = 'TEST' + Date.now()
+
+        waterfall([
+          (cb) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/new'
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              cb(null, res.result.Hash)
+            })
+          },
+          (linkHash, cb) => {
+            const form = new FormData()
+            form.append('file', JSON.stringify({
+              Data: 'TEST' + Date.now(),
+              Links: [{ Name: linkName, Hash: linkHash, Size: 8 }]
+            }), { filename: 'node.json' })
+            const headers = form.getHeaders()
+
+            streamToPromise(form).then((payload) => {
+              api.inject({
+                method: 'POST',
+                url: '/api/v0/object/put',
+                headers: headers,
+                payload: payload
+              }, (res) => {
+                expect(res.statusCode).to.equal(200)
+                cb(null, res.result.Hash, linkHash)
+              })
+            })
+          }
+        ], (err, hash) => {
+          expect(err).to.not.exist()
+
+          api.inject({
+            method: 'POST',
+            url: `/api/v0/object/patch/rm-link?cid-base=base64&arg=${hash}&arg=${linkName}`
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Hash)).to.deep.equal('base64')
+            done()
+          })
+        })
+      })
+
+      it('should not remove a link from an object for invalid cid-base option', (done) => {
+        const linkName = 'TEST' + Date.now()
+
+        waterfall([
+          (cb) => {
+            api.inject({
+              method: 'POST',
+              url: '/api/v0/object/new'
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              cb(null, res.result.Hash)
+            })
+          },
+          (linkHash, cb) => {
+            const form = new FormData()
+            form.append('file', JSON.stringify({
+              Data: 'TEST' + Date.now(),
+              Links: [{ Name: linkName, Hash: linkHash, Size: 8 }]
+            }), { filename: 'node.json' })
+            const headers = form.getHeaders()
+
+            streamToPromise(form).then((payload) => {
+              api.inject({
+                method: 'POST',
+                url: '/api/v0/object/put',
+                headers: headers,
+                payload: payload
+              }, (res) => {
+                expect(res.statusCode).to.equal(200)
+                cb(null, res.result.Hash)
+              })
+            })
+          }
+        ], (err, hash) => {
+          expect(err).to.not.exist()
+
+          api.inject({
+            method: 'POST',
+            url: `/api/v0/object/patch/rm-link?cid-base=invalid&arg=${hash}&arg=${linkName}`
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
     })
   })
 }

From d0622930954b8396d76f6d3a60de47a838e251b5 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 16 Nov 2018 16:13:10 +0000
Subject: [PATCH 20/41] test: add HTTP API tests for pin.* with cid-base option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/http/api/routes/pin.js  |   9 +-
 test/http-api/inject/pin.js | 169 ++++++++++++++++++++++++++++++++++++
 2 files changed, 175 insertions(+), 3 deletions(-)

diff --git a/src/http/api/routes/pin.js b/src/http/api/routes/pin.js
index 657bb375ac..76b6a57ad1 100644
--- a/src/http/api/routes/pin.js
+++ b/src/http/api/routes/pin.js
@@ -12,7 +12,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.pin.add.parseArgs, assign: 'args' }
       ],
-      handler: resources.pin.add.handler
+      handler: resources.pin.add.handler,
+      validate: resources.pin.add.validate
     }
   })
 
@@ -23,7 +24,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.pin.rm.parseArgs, assign: 'args' }
       ],
-      handler: resources.pin.rm.handler
+      handler: resources.pin.rm.handler,
+      validate: resources.pin.rm.validate
     }
   })
 
@@ -34,7 +36,8 @@ module.exports = (server) => {
       pre: [
         { method: resources.pin.ls.parseArgs, assign: 'args' }
       ],
-      handler: resources.pin.ls.handler
+      handler: resources.pin.ls.handler,
+      validate: resources.pin.ls.validate
     }
   })
 }
diff --git a/test/http-api/inject/pin.js b/test/http-api/inject/pin.js
index e351e721a7..9180533246 100644
--- a/test/http-api/inject/pin.js
+++ b/test/http-api/inject/pin.js
@@ -3,6 +3,9 @@
 'use strict'
 
 const expect = require('chai').expect
+const FormData = require('form-data')
+const streamToPromise = require('stream-to-promise')
+const multibase = require('multibase')
 
 // We use existing pin structure in the go-ipfs-repo fixture
 // so that we don't have to stream a bunch of object/put operations
@@ -75,6 +78,62 @@ module.exports = (http) => {
           })
         })
       })
+
+      it('should remove pin and return base64 encoded CID', done => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            const hash = JSON.parse(res.result).Hash
+
+            api.inject({
+              method: 'POST',
+              url: `/api/v0/pin/rm?arg=${hash}&cid-base=base64`
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              res.result.Pins.forEach(cid => {
+                expect(multibase.isEncoded(cid)).to.deep.equal('base64')
+              })
+              done()
+            })
+          })
+        })
+      })
+
+      it('should not remove pin for invalid cid-base option', done => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            const hash = JSON.parse(res.result).Hash
+
+            api.inject({
+              method: 'POST',
+              url: `/api/v0/pin/rm?arg=${hash}&cid-base=invalid`
+            }, (res) => {
+              expect(res.statusCode).to.equal(400)
+              expect(res.result.Message).to.include('child "cid-base" fails')
+              done()
+            })
+          })
+        })
+      })
     })
 
     describe('add', () => {
@@ -113,6 +172,62 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should add pin and return base64 encoded CID', done => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add?pin=false',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            const hash = JSON.parse(res.result).Hash
+
+            api.inject({
+              method: 'POST',
+              url: `/api/v0/pin/add?arg=${hash}&cid-base=base64`
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              res.result.Pins.forEach(cid => {
+                expect(multibase.isEncoded(cid)).to.deep.equal('base64')
+              })
+              done()
+            })
+          })
+        })
+      })
+
+      it('should not add pin for invalid cid-base option', done => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add?pin=false',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            const hash = JSON.parse(res.result).Hash
+
+            api.inject({
+              method: 'POST',
+              url: `/api/v0/pin/add?arg=${hash}&cid-base=invalid`
+            }, (res) => {
+              expect(res.statusCode).to.equal(400)
+              expect(res.result.Message).to.include('child "cid-base" fails')
+              done()
+            })
+          })
+        })
+      })
     })
 
     describe('ls', () => {
@@ -161,6 +276,60 @@ module.exports = (http) => {
           done()
         })
       })
+
+      it('should list pins and return base64 encoded CIDs', done => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+
+            api.inject({
+              method: 'POST',
+              url: `/api/v0/pin/ls?cid-base=base64`
+            }, (res) => {
+              expect(res.statusCode).to.equal(200)
+              Object.keys(res.result.Keys).forEach(cid => {
+                expect(multibase.isEncoded(cid)).to.deep.equal('base64')
+              })
+              done()
+            })
+          })
+        })
+      })
+
+      it('should not list pins for invalid cid-base option', done => {
+        const form = new FormData()
+        form.append('data', Buffer.from('TEST' + Date.now()))
+        const headers = form.getHeaders()
+
+        streamToPromise(form).then((payload) => {
+          api.inject({
+            method: 'POST',
+            url: '/api/v0/add',
+            headers: headers,
+            payload: payload
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+
+            api.inject({
+              method: 'POST',
+              url: `/api/v0/pin/ls?cid-base=invalid`
+            }, (res) => {
+              expect(res.statusCode).to.equal(400)
+              expect(res.result.Message).to.include('child "cid-base" fails')
+              done()
+            })
+          })
+        })
+      })
     })
   })
 }

From e3e46e03caa7b7ea2d725103e93cdf3a0dd89e40 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 16 Nov 2018 16:28:00 +0000
Subject: [PATCH 21/41] test: add HTTP API tests for resolve with cid-base
 option

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/resolve.js | 72 +++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 test/http-api/inject/resolve.js

diff --git a/test/http-api/inject/resolve.js b/test/http-api/inject/resolve.js
new file mode 100644
index 0000000000..a9aef87266
--- /dev/null
+++ b/test/http-api/inject/resolve.js
@@ -0,0 +1,72 @@
+/* eslint-env mocha */
+/* eslint max-nested-callbacks: ["error", 8] */
+'use strict'
+
+const expect = require('chai').expect
+const FormData = require('form-data')
+const streamToPromise = require('stream-to-promise')
+const multibase = require('multibase')
+
+module.exports = (http) => {
+  describe('resolve', () => {
+    let api
+
+    before(() => {
+      api = http.api.server.select('API')
+    })
+
+    it('should resolve a path and return a base2 encoded CID', done => {
+      const form = new FormData()
+      form.append('data', Buffer.from('TEST' + Date.now()))
+      const headers = form.getHeaders()
+
+      streamToPromise(form).then((payload) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/add',
+          headers: headers,
+          payload: payload
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+          const hash = JSON.parse(res.result).Hash
+
+          api.inject({
+            method: 'POST',
+            url: `/api/v0/resolve?arg=/ipfs/${hash}&cid-base=base2`
+          }, (res) => {
+            expect(res.statusCode).to.equal(200)
+            expect(multibase.isEncoded(res.result.Path.replace('/ipfs/', ''))).to.deep.equal('base2')
+            done()
+          })
+        })
+      })
+    })
+
+    it('should not resolve a path for invalid cid-base option', done => {
+      const form = new FormData()
+      form.append('data', Buffer.from('TEST' + Date.now()))
+      const headers = form.getHeaders()
+
+      streamToPromise(form).then((payload) => {
+        api.inject({
+          method: 'POST',
+          url: '/api/v0/add',
+          headers: headers,
+          payload: payload
+        }, (res) => {
+          expect(res.statusCode).to.equal(200)
+          const hash = JSON.parse(res.result).Hash
+
+          api.inject({
+            method: 'POST',
+            url: `/api/v0/resolve?arg=/ipfs/${hash}&cid-base=invalid`
+          }, (res) => {
+            expect(res.statusCode).to.equal(400)
+            expect(res.result.Message).to.include('child "cid-base" fails')
+            done()
+          })
+        })
+      })
+    })
+  })
+}

From 5a1bc35a720e7a9a346abce14c50668d077e8b98 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Tue, 20 Nov 2018 17:06:20 +0000
Subject: [PATCH 22/41] refactor: back out of core accepting cidBase

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/add.js                 |  4 +--
 src/cli/commands/bitswap/stat.js        |  5 ++--
 src/cli/commands/bitswap/wantlist.js    |  5 ++--
 src/cli/commands/block/stat.js          |  5 ++--
 src/cli/commands/object/stat.js         |  5 ++--
 src/cli/commands/pin/add.js             |  5 ++--
 src/cli/commands/pin/ls.js              |  5 ++--
 src/cli/commands/pin/rm.js              |  5 ++--
 src/core/components/bitswap.js          | 37 ++++---------------------
 src/core/components/block.js            | 10 +------
 src/core/components/object.js           |  3 +-
 src/core/components/pin.js              | 20 ++-----------
 src/http/api/resources/bitswap.js       | 10 ++++---
 src/http/api/resources/block.js         |  5 ++--
 src/http/api/resources/files-regular.js |  5 ++--
 src/http/api/resources/object.js        |  5 ++--
 src/http/api/resources/pin.js           | 16 +++++------
 17 files changed, 53 insertions(+), 97 deletions(-)

diff --git a/src/cli/commands/add.js b/src/cli/commands/add.js
index 9ea059b3c2..878a87349d 100644
--- a/src/cli/commands/add.js
+++ b/src/cli/commands/add.js
@@ -13,6 +13,7 @@ const waterfall = require('async/waterfall')
 const mh = require('multihashes')
 const multibase = require('multibase')
 const { print, isDaemonOn, createProgressBar } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 function checkPath (inPath, recursive) {
   // This function is to check for the following possible inputs
@@ -89,7 +90,7 @@ function addPipeline (index, addStream, list, argv) {
       sortBy(added, 'path')
         .reverse()
         .map((file) => {
-          const log = [ 'added', file.hash ]
+          const log = [ 'added', cidToString(file.hash, argv.cidBase) ]
 
           if (!quiet && file.path.length > 0) log.push(file.path)
 
@@ -198,7 +199,6 @@ module.exports = {
         ? argv.shardSplitThreshold
         : Infinity,
       cidVersion: argv.cidVersion,
-      cidBase: argv.cidBase,
       rawLeaves: argv.rawLeaves,
       onlyHash: argv.onlyHash,
       hashAlg: argv.hash,
diff --git a/src/cli/commands/bitswap/stat.js b/src/cli/commands/bitswap/stat.js
index 281c83ddbf..dcee8b2c6b 100644
--- a/src/cli/commands/bitswap/stat.js
+++ b/src/cli/commands/bitswap/stat.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'stat',
@@ -17,12 +18,12 @@ module.exports = {
   },
 
   handler ({ ipfs, cidBase }) {
-    ipfs.bitswap.stat({ cidBase }, (err, stats) => {
+    ipfs.bitswap.stat((err, stats) => {
       if (err) {
         throw err
       }
 
-      stats.wantlist = stats.wantlist || []
+      stats.wantlist = stats.wantlist.Keys.map(cid => cidToString(cid, cidBase))
       stats.peers = stats.peers || []
 
       print(`bitswap status
diff --git a/src/cli/commands/bitswap/wantlist.js b/src/cli/commands/bitswap/wantlist.js
index db40b710fc..104b170b7a 100644
--- a/src/cli/commands/bitswap/wantlist.js
+++ b/src/cli/commands/bitswap/wantlist.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'wantlist [peer]',
@@ -22,11 +23,11 @@ module.exports = {
   },
 
   handler ({ ipfs, peer, cidBase }) {
-    ipfs.bitswap.wantlist(peer, { cidBase }, (err, cids) => {
+    ipfs.bitswap.wantlist(peer, (err, cids) => {
       if (err) {
         throw err
       }
-      cids.forEach((cid) => print(cid))
+      cids.forEach((cid) => print(cidToString(cid, cidBase)))
     })
   }
 }
diff --git a/src/cli/commands/block/stat.js b/src/cli/commands/block/stat.js
index 77a96a3e8d..c9e84cfa5f 100644
--- a/src/cli/commands/block/stat.js
+++ b/src/cli/commands/block/stat.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'stat <key>',
@@ -17,12 +18,12 @@ module.exports = {
   },
 
   handler ({ ipfs, key, cidBase }) {
-    ipfs.block.stat(key, { cidBase }, (err, stats) => {
+    ipfs.block.stat(key, (err, stats) => {
       if (err) {
         throw err
       }
 
-      print('Key: ' + stats.key)
+      print('Key: ' + cidToString(stats.key, cidBase))
       print('Size: ' + stats.size)
     })
   }
diff --git a/src/cli/commands/object/stat.js b/src/cli/commands/object/stat.js
index cb4936c304..522d240f95 100644
--- a/src/cli/commands/object/stat.js
+++ b/src/cli/commands/object/stat.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const print = require('../../utils').print
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'stat <key>',
@@ -17,7 +18,7 @@ module.exports = {
   },
 
   handler ({ ipfs, key, cidBase }) {
-    ipfs.object.stat(key, { enc: 'base58', cidBase }, (err, stats) => {
+    ipfs.object.stat(key, { enc: 'base58' }, (err, stats) => {
       if (err) {
         throw err
       }
@@ -25,7 +26,7 @@ module.exports = {
       delete stats.Hash // only for js-ipfs-http-client output
 
       Object.keys(stats).forEach((key) => {
-        print(`${key}: ${stats[key]}`)
+        print(`${key}: ${cidToString(stats[key], cidBase)}`)
       })
     })
   }
diff --git a/src/cli/commands/pin/add.js b/src/cli/commands/pin/add.js
index 486d71e6f9..38eaf9ee5f 100644
--- a/src/cli/commands/pin/add.js
+++ b/src/cli/commands/pin/add.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'add <ipfsPath...>',
@@ -25,10 +26,10 @@ module.exports = {
   handler ({ ipfs, ipfsPath, recursive, cidBase }) {
     const type = recursive ? 'recursive' : 'direct'
 
-    ipfs.pin.add(ipfsPath, { recursive, cidBase }, (err, results) => {
+    ipfs.pin.add(ipfsPath, { recursive }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        print(`pinned ${res.hash} ${type}ly`)
+        print(`pinned ${cidToString(res.hash, cidBase)} ${type}ly`)
       })
     })
   }
diff --git a/src/cli/commands/pin/ls.js b/src/cli/commands/pin/ls.js
index a871438abb..83487567d9 100644
--- a/src/cli/commands/pin/ls.js
+++ b/src/cli/commands/pin/ls.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   // bracket syntax with '...' tells yargs to optionally accept a list
@@ -33,10 +34,10 @@ module.exports = {
   handler: ({ ipfs, ipfsPath, type, quiet, cidBase }) => {
     const paths = ipfsPath
 
-    ipfs.pin.ls(paths, { type, cidBase }, (err, results) => {
+    ipfs.pin.ls(paths, { type }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        let line = res.hash
+        let line = cidToString(res.hash, cidBase)
         if (!quiet) {
           line += ` ${res.type}`
         }
diff --git a/src/cli/commands/pin/rm.js b/src/cli/commands/pin/rm.js
index f28a6270a6..e7a10bb272 100644
--- a/src/cli/commands/pin/rm.js
+++ b/src/cli/commands/pin/rm.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
+const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'rm <ipfsPath...>',
@@ -23,10 +24,10 @@ module.exports = {
   },
 
   handler: ({ ipfs, ipfsPath, recursive, cidBase }) => {
-    ipfs.pin.rm(ipfsPath, { recursive, cidBase }, (err, results) => {
+    ipfs.pin.rm(ipfsPath, { recursive }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        print(`unpinned ${res.hash}`)
+        print(`unpinned ${cidToString(res.hash, cidBase)}`)
       })
     })
   }
diff --git a/src/core/components/bitswap.js b/src/core/components/bitswap.js
index c1969c3074..cdee77647b 100644
--- a/src/core/components/bitswap.js
+++ b/src/core/components/bitswap.js
@@ -7,37 +7,23 @@ const Big = require('big.js')
 const CID = require('cids')
 const PeerId = require('peer-id')
 const errCode = require('err-code')
-const multibase = require('multibase')
-const { cidToString } = require('../../utils/cid')
 
 function formatWantlist (list, cidBase) {
-  return Array.from(list).map((e) => cidToString(e[1].cid, cidBase))
+  return Array.from(list).map((e) => ({ '/': e[1].cid.toBaseEncodedString() }))
 }
 
 module.exports = function bitswap (self) {
   return {
-    wantlist: promisify((peerId, options, callback) => {
+    wantlist: promisify((peerId, callback) => {
       if (typeof peerId === 'function') {
         callback = peerId
-        options = {}
         peerId = null
-      } else if (typeof options === 'function') {
-        callback = options
-        options = {}
       }
 
-      options = options || {}
-
       if (!self.isOnline()) {
         return setImmediate(() => callback(new Error(OFFLINE_ERROR)))
       }
 
-      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
-        return setImmediate(() => {
-          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
-        })
-      }
-
       let list
       if (peerId) {
         try {
@@ -53,34 +39,21 @@ module.exports = function bitswap (self) {
         list = self._bitswap.getWantlist()
       }
 
-      setImmediate(() => callback(null, formatWantlist(list, options.cidBase)))
+      setImmediate(() => callback(null, formatWantlist(list)))
     }),
 
-    stat: promisify((options, callback) => {
-      if (typeof options === 'function') {
-        callback = options
-        options = {}
-      }
-
-      options = options || {}
-
+    stat: promisify((callback) => {
       if (!self.isOnline()) {
         return setImmediate(() => callback(new Error(OFFLINE_ERROR)))
       }
 
-      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
-        return setImmediate(() => {
-          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
-        })
-      }
-
       const snapshot = self._bitswap.stat().snapshot
 
       setImmediate(() => {
         callback(null, {
           provideBufLen: parseInt(snapshot.providesBufferLength.toString()),
           blocksReceived: new Big(snapshot.blocksReceived),
-          wantlist: formatWantlist(self._bitswap.getWantlist(), options.cidBase),
+          wantlist: formatWantlist(self._bitswap.getWantlist()),
           peers: self._bitswap.peers().map((id) => id.toB58String()),
           dupBlksReceived: new Big(snapshot.dupBlksReceived),
           dupDataReceived: new Big(snapshot.dupDataReceived),
diff --git a/src/core/components/block.js b/src/core/components/block.js
index 5a113d44c0..6a1bb960d1 100644
--- a/src/core/components/block.js
+++ b/src/core/components/block.js
@@ -7,8 +7,6 @@ const waterfall = require('async/waterfall')
 const setImmediate = require('async/setImmediate')
 const promisify = require('promisify-es6')
 const errCode = require('err-code')
-const multibase = require('multibase')
-const { cidToString } = require('../../utils/cid')
 
 module.exports = function block (self) {
   return {
@@ -118,12 +116,6 @@ module.exports = function block (self) {
         return setImmediate(() => callback(errCode(err, 'ERR_INVALID_CID')))
       }
 
-      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
-        return setImmediate(() => {
-          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
-        })
-      }
-
       if (options.preload !== false) {
         self._preload(cid)
       }
@@ -133,7 +125,7 @@ module.exports = function block (self) {
           return callback(err)
         }
         callback(null, {
-          key: cidToString(cid, options.cidBase),
+          key: cid.toString(),
           size: block.data.length
         })
       })
diff --git a/src/core/components/object.js b/src/core/components/object.js
index 7605b11d46..85a3137522 100644
--- a/src/core/components/object.js
+++ b/src/core/components/object.js
@@ -11,7 +11,6 @@ const CID = require('cids')
 const mh = require('multihashes')
 const Unixfs = require('ipfs-unixfs')
 const errCode = require('err-code')
-const { cidToString } = require('../../utils/cid')
 
 function normalizeMultihash (multihash, enc) {
   if (typeof multihash === 'string') {
@@ -314,7 +313,7 @@ module.exports = function object (self) {
         const linkLength = result.node.links.reduce((a, l) => a + l.size, 0)
 
         callback(null, {
-          Hash: cidToString(result.cid, options.cidBase),
+          Hash: result.cid.toBaseEncodedString(),
           NumLinks: result.node.links.length,
           BlockSize: blockSize,
           LinksSize: blockSize - result.node.data.length,
diff --git a/src/core/components/pin.js b/src/core/components/pin.js
index ebd891eaa5..e74427a96a 100644
--- a/src/core/components/pin.js
+++ b/src/core/components/pin.js
@@ -18,7 +18,6 @@ const multibase = require('multibase')
 
 const createPinSet = require('./pin-set')
 const { resolvePath } = require('../utils')
-const { cidToString } = require('../../utils/cid')
 
 // arbitrary limit to the number of concurrent dag operations
 const concurrencyLimit = 300
@@ -151,12 +150,6 @@ module.exports = (self) => {
 
       const recursive = options.recursive == null ? true : options.recursive
 
-      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
-        return setImmediate(() => {
-          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
-        })
-      }
-
       resolvePath(self.object, paths, (err, mhs) => {
         if (err) { return callback(err) }
 
@@ -203,7 +196,7 @@ module.exports = (self) => {
           // persist updated pin sets to datastore
           flushPins((err, root) => {
             if (err) { return callback(err) }
-            callback(null, results.map(hash => ({ hash: cidToString(hash, options.cidBase) })))
+            callback(null, results.map(hash => ({ hash })))
           })
         })
       })
@@ -268,7 +261,7 @@ module.exports = (self) => {
           flushPins((err, root) => {
             if (err) { return callback(err) }
             self.log(`Removed pins: ${results}`)
-            callback(null, results.map(hash => ({ hash: cidToString(hash, options.cidBase) })))
+            callback(null, results.map(hash => ({ hash })))
           })
         })
       })
@@ -301,12 +294,6 @@ module.exports = (self) => {
         return setImmediate(() => callback(invalidPinTypeErr(type)))
       }
 
-      if (options.cidBase && !multibase.names.includes(options.cidBase)) {
-        return setImmediate(() => {
-          callback(errCode(new Error('invalid multibase'), 'ERR_INVALID_MULTIBASE'))
-        })
-      }
-
       if (paths) {
         // check the pinned state of specific hashes
         waterfall([
@@ -371,11 +358,10 @@ module.exports = (self) => {
                 type: types.indirect,
                 hash
               })))
-              .map(p => Object.assign(p, { hash: cidToString(p.hash, options.cidBase) }))
             return callback(null, pins)
           })
         } else {
-          callback(null, pins.map(p => Object.assign(p, { hash: cidToString(p.hash, options.cidBase) })))
+          callback(null, pins)
         }
       }
     }),
diff --git a/src/http/api/resources/bitswap.js b/src/http/api/resources/bitswap.js
index c412ccb954..d0c963ee50 100644
--- a/src/http/api/resources/bitswap.js
+++ b/src/http/api/resources/bitswap.js
@@ -19,11 +19,11 @@ exports.wantlist = {
     const peerId = request.query.peer
     const cidBase = request.query['cid-base']
 
-    request.server.app.ipfs.bitswap.wantlist(peerId, { cidBase }, (err, list) => {
+    request.server.app.ipfs.bitswap.wantlist(peerId, (err, list) => {
       if (err) {
         return reply(boom.badRequest(err))
       }
-      reply({ Keys: list.map(cid => ({ '/': cid })) })
+      reply({ Keys: list.Keys.map(cid => ({ '/': cidToString(cid, cidBase) })) })
     })
   }
 }
@@ -39,7 +39,7 @@ exports.stat = {
     const ipfs = request.server.app.ipfs
     const cidBase = request.query['cid-base']
 
-    ipfs.bitswap.stat({ cidBase }, (err, stats) => {
+    ipfs.bitswap.stat((err, stats) => {
       if (err) {
         return reply({
           Message: err.toString(),
@@ -47,10 +47,12 @@ exports.stat = {
         }).code(500)
       }
 
+      stats.wantlist = stats.wantlist.Keys.map(cid => ({ '/': cidToString(cid, cidBase) }))
+
       reply({
         ProvideBufLen: stats.provideBufLen,
         BlocksReceived: stats.blocksReceived,
-        Wantlist: stats.wantlist.map(cid => ({ '/': cid })),
+        Wantlist: stats.wantlist,
         Peers: stats.peers,
         DupBlksReceived: stats.dupBlksReceived,
         DupDataReceived: stats.dupDataReceived,
diff --git a/src/http/api/resources/block.js b/src/http/api/resources/block.js
index a8abdd3f40..6167e203f8 100644
--- a/src/http/api/resources/block.js
+++ b/src/http/api/resources/block.js
@@ -161,9 +161,8 @@ exports.stat = {
   // main route handler which is called after the above `parseArgs`, but only if the args were valid
   handler: (request, reply) => {
     const key = request.pre.args.key
-    const cidBase = request.query['cid-base']
 
-    request.server.app.ipfs.block.stat(key, { cidBase }, (err, stats) => {
+    request.server.app.ipfs.block.stat(key, (err, stats) => {
       if (err) {
         log.error(err)
         return reply({
@@ -173,7 +172,7 @@ exports.stat = {
       }
 
       return reply({
-        Key: stats.key,
+        Key: cidToString(stats.key, request.query['cid-base']),
         Size: stats.size
       })
     })
diff --git a/src/http/api/resources/files-regular.js b/src/http/api/resources/files-regular.js
index 704873bc9d..ff228d77eb 100644
--- a/src/http/api/resources/files-regular.js
+++ b/src/http/api/resources/files-regular.js
@@ -235,7 +235,6 @@ exports.add = {
 
     const options = {
       cidVersion: request.query['cid-version'],
-      cidBase: request.query['cid-base'],
       rawLeaves: request.query['raw-leaves'],
       progress: request.query.progress ? progressHandler : null,
       onlyHash: request.query['only-hash'],
@@ -281,7 +280,7 @@ exports.add = {
       pull.map((file) => {
         return {
           Name: file.path, // addPullStream already turned this into a hash if it wanted to
-          Hash: file.hash,
+          Hash: cidToString(file.hash, request.query['cid-base']),
           Size: file.size
         }
       }),
@@ -318,7 +317,7 @@ exports.ls = {
     const recursive = request.query && request.query.recursive === 'true'
     const cidBase = request.query['cid-base']
 
-    ipfs.ls(key, { recursive, cidBase }, (err, files) => {
+    ipfs.ls(key, { recursive }, (err, files) => {
       if (err) {
         return reply({
           Message: 'Failed to list dir: ' + err.message,
diff --git a/src/http/api/resources/object.js b/src/http/api/resources/object.js
index 7e2b3b3f19..63f2d09b47 100644
--- a/src/http/api/resources/object.js
+++ b/src/http/api/resources/object.js
@@ -268,9 +268,8 @@ exports.stat = {
   handler: (request, reply) => {
     const ipfs = request.server.app.ipfs
     const key = request.pre.args.key
-    const cidBase = request.query['cid-base']
 
-    ipfs.object.stat(key, { cidBase }, (err, stats) => {
+    ipfs.object.stat(key, (err, stats) => {
       if (err) {
         log.error(err)
         return reply({
@@ -279,6 +278,8 @@ exports.stat = {
         }).code(500)
       }
 
+      stats.Hash = cidToString(stats.Hash, request.query['cid-base'])
+
       return reply(stats)
     })
   }
diff --git a/src/http/api/resources/pin.js b/src/http/api/resources/pin.js
index b94c793371..cf99d28c41 100644
--- a/src/http/api/resources/pin.js
+++ b/src/http/api/resources/pin.js
@@ -4,6 +4,7 @@ const mapValues = require('lodash/mapValues')
 const keyBy = require('lodash/keyBy')
 const multibase = require('multibase')
 const Joi = require('joi')
+const { cidToString } = require('../../../utils/cid')
 const debug = require('debug')
 const log = debug('jsipfs:http-api:pin')
 log.error = debug('jsipfs:http-api:pin:error')
@@ -45,9 +46,8 @@ exports.ls = {
   handler: (request, reply) => {
     const { path, type } = request.pre.args
     const ipfs = request.server.app.ipfs
-    const cidBase = request.query['cid-base']
 
-    ipfs.pin.ls(path, { type, cidBase }, (err, result) => {
+    ipfs.pin.ls(path, { type }, (err, result) => {
       if (err) {
         log.error(err)
         return reply({
@@ -58,7 +58,7 @@ exports.ls = {
 
       return reply({
         Keys: mapValues(
-          keyBy(result, obj => obj.hash),
+          keyBy(result, obj => cidToString(obj.hash, request.query['cid-base'])),
           obj => ({ Type: obj.type })
         )
       })
@@ -78,9 +78,8 @@ exports.add = {
   handler: (request, reply) => {
     const ipfs = request.server.app.ipfs
     const { path, recursive } = request.pre.args
-    const cidBase = request.query['cid-base']
 
-    ipfs.pin.add(path, { recursive, cidBase }, (err, result) => {
+    ipfs.pin.add(path, { recursive }, (err, result) => {
       if (err) {
         log.error(err)
         return reply({
@@ -90,7 +89,7 @@ exports.add = {
       }
 
       return reply({
-        Pins: result.map(obj => obj.hash)
+        Pins: result.map(obj => cidToString(obj.hash, request.query['cid-base']))
       })
     })
   }
@@ -108,9 +107,8 @@ exports.rm = {
   handler: (request, reply) => {
     const ipfs = request.server.app.ipfs
     const { path, recursive } = request.pre.args
-    const cidBase = request.query['cid-base']
 
-    ipfs.pin.rm(path, { recursive, cidBase }, (err, result) => {
+    ipfs.pin.rm(path, { recursive }, (err, result) => {
       if (err) {
         log.error(err)
         return reply({
@@ -120,7 +118,7 @@ exports.rm = {
       }
 
       return reply({
-        Pins: result.map(obj => obj.hash)
+        Pins: result.map(obj => cidToString(obj.hash, request.query['cid-base']))
       })
     })
   }

From ae2b7339cdd52068055668473bb238657ab877b4 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Tue, 20 Nov 2018 22:37:35 +0000
Subject: [PATCH 23/41] fix: bitswap tests

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/add.js              | 4 ++--
 src/cli/commands/bitswap/stat.js     | 2 +-
 src/cli/commands/bitswap/wantlist.js | 4 ++--
 src/core/components/bitswap.js       | 2 +-
 src/http/api/resources/bitswap.js    | 4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/cli/commands/add.js b/src/cli/commands/add.js
index 878a87349d..bf764fb8f7 100644
--- a/src/cli/commands/add.js
+++ b/src/cli/commands/add.js
@@ -12,8 +12,8 @@ const byteman = require('byteman')
 const waterfall = require('async/waterfall')
 const mh = require('multihashes')
 const multibase = require('multibase')
-const { print, isDaemonOn, createProgressBar } = require('../../utils')
-const { cidToString } = require('../../../utils/cid')
+const { print, isDaemonOn, createProgressBar } = require('../utils')
+const { cidToString } = require('../../utils/cid')
 
 function checkPath (inPath, recursive) {
   // This function is to check for the following possible inputs
diff --git a/src/cli/commands/bitswap/stat.js b/src/cli/commands/bitswap/stat.js
index dcee8b2c6b..2588a3e534 100644
--- a/src/cli/commands/bitswap/stat.js
+++ b/src/cli/commands/bitswap/stat.js
@@ -23,7 +23,7 @@ module.exports = {
         throw err
       }
 
-      stats.wantlist = stats.wantlist.Keys.map(cid => cidToString(cid, cidBase))
+      stats.wantlist = stats.wantlist.map(k => cidToString(k['/'], cidBase))
       stats.peers = stats.peers || []
 
       print(`bitswap status
diff --git a/src/cli/commands/bitswap/wantlist.js b/src/cli/commands/bitswap/wantlist.js
index 104b170b7a..9396db0ee1 100644
--- a/src/cli/commands/bitswap/wantlist.js
+++ b/src/cli/commands/bitswap/wantlist.js
@@ -23,11 +23,11 @@ module.exports = {
   },
 
   handler ({ ipfs, peer, cidBase }) {
-    ipfs.bitswap.wantlist(peer, (err, cids) => {
+    ipfs.bitswap.wantlist(peer, (err, list) => {
       if (err) {
         throw err
       }
-      cids.forEach((cid) => print(cidToString(cid, cidBase)))
+      list.Keys.forEach(k => print(cidToString(k['/'], cidBase)))
     })
   }
 }
diff --git a/src/core/components/bitswap.js b/src/core/components/bitswap.js
index cdee77647b..930ab88e2d 100644
--- a/src/core/components/bitswap.js
+++ b/src/core/components/bitswap.js
@@ -39,7 +39,7 @@ module.exports = function bitswap (self) {
         list = self._bitswap.getWantlist()
       }
 
-      setImmediate(() => callback(null, formatWantlist(list)))
+      setImmediate(() => callback(null, { Keys: formatWantlist(list) }))
     }),
 
     stat: promisify((callback) => {
diff --git a/src/http/api/resources/bitswap.js b/src/http/api/resources/bitswap.js
index d0c963ee50..bd9b1d9895 100644
--- a/src/http/api/resources/bitswap.js
+++ b/src/http/api/resources/bitswap.js
@@ -23,7 +23,7 @@ exports.wantlist = {
       if (err) {
         return reply(boom.badRequest(err))
       }
-      reply({ Keys: list.Keys.map(cid => ({ '/': cidToString(cid, cidBase) })) })
+      reply({ Keys: list.Keys.map(k => ({ '/': cidToString(k['/'], cidBase) })) })
     })
   }
 }
@@ -47,7 +47,7 @@ exports.stat = {
         }).code(500)
       }
 
-      stats.wantlist = stats.wantlist.Keys.map(cid => ({ '/': cidToString(cid, cidBase) }))
+      stats.wantlist = stats.wantlist.map(k => ({ '/': cidToString(k['/'], cidBase) }))
 
       reply({
         ProvideBufLen: stats.provideBufLen,

From 501005bbae21925542939b38e9bce94ec8ba11e2 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Tue, 20 Nov 2018 23:14:30 +0000
Subject: [PATCH 24/41] fix: test fixes and tweaks

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/ls.js                  | 5 ++++-
 src/http/api/resources/files-regular.js | 8 ++++----
 test/cli/files.js                       | 2 +-
 test/http-api/inject/files.js           | 1 +
 4 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/cli/commands/ls.js b/src/cli/commands/ls.js
index 7e05e7acf0..1dea656fb2 100644
--- a/src/cli/commands/ls.js
+++ b/src/cli/commands/ls.js
@@ -2,6 +2,7 @@
 
 const multibase = require('multibase')
 const { print, rightpad } = require('../utils')
+const { cidToString } = require('../../utils/cid')
 
 module.exports = {
   command: 'ls <key>',
@@ -34,11 +35,13 @@ module.exports = {
   },
 
   handler ({ ipfs, key, recursive, headers, cidBase }) {
-    ipfs.ls(key, { recursive, cidBase }, (err, links) => {
+    ipfs.ls(key, { recursive }, (err, links) => {
       if (err) {
         throw err
       }
 
+      links = links.map(file => Object.assign(file, { hash: cidToString(file.hash, cidBase) }))
+
       if (headers) {
         links = [{ hash: 'Hash', size: 'Size', name: 'Name' }].concat(links)
       }
diff --git a/src/http/api/resources/files-regular.js b/src/http/api/resources/files-regular.js
index ff228d77eb..612c06aa7e 100644
--- a/src/http/api/resources/files-regular.js
+++ b/src/http/api/resources/files-regular.js
@@ -126,11 +126,11 @@ exports.get = {
 
   // main route handler which is called after the above `parseArgs`, but only if the args were valid
   handler: (request, reply) => {
-    const cid = request.pre.args.key
+    const key = request.pre.args.key
     const ipfs = request.server.app.ipfs
     const pack = tar.pack()
 
-    ipfs.get(cid, (err, filesArray) => {
+    ipfs.get(key, (err, filesArray) => {
       if (err) {
         log.error(err)
         pack.emit('error', err)
@@ -312,7 +312,7 @@ exports.ls = {
 
   // main route handler which is called after the above `parseArgs`, but only if the args were valid
   handler: (request, reply) => {
-    const key = request.pre.args.key
+    const { key } = request.pre.args
     const ipfs = request.server.app.ipfs
     const recursive = request.query && request.query.recursive === 'true'
     const cidBase = request.query['cid-base']
@@ -328,7 +328,7 @@ exports.ls = {
 
       reply({
         Objects: [{
-          Hash: cidToString(key, cidBase),
+          Hash: key,
           Links: files.map((file) => ({
             Name: file.name,
             Hash: cidToString(file.hash, cidBase),
diff --git a/test/cli/files.js b/test/cli/files.js
index 60f8bb0798..71f0a8a886 100644
--- a/test/cli/files.js
+++ b/test/cli/files.js
@@ -368,7 +368,7 @@ describe('files', () => runOnAndOff((thing) => {
 
     return ipfs('add test/fixtures/test-data/hello --cid-base=base64')
       .then((out) => {
-        expect(out).to.eql('added mAXASIKlIkE8vD0ebj4GXaUswGEsNLtHBzSoewPuF0pmhkqRH hello\n')
+        expect(out).to.eql('added mAXASIEbUSBS5xa8UHDqqt8BdxehE6tX5HxKFiwIeukV2i0wO hello\n')
       })
   })
 
diff --git a/test/http-api/inject/files.js b/test/http-api/inject/files.js
index 320dd6843b..bae8f48f8f 100644
--- a/test/http-api/inject/files.js
+++ b/test/http-api/inject/files.js
@@ -1,3 +1,4 @@
+/* eslint max-nested-callbacks: ["error", 8] */
 /* eslint-env mocha */
 'use strict'
 

From af8b5d615305f12cc29e2fe1695052ea2cae44e1 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Tue, 20 Nov 2018 23:26:07 +0000
Subject: [PATCH 25/41] fix: object stat CLI

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/object/stat.js | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/cli/commands/object/stat.js b/src/cli/commands/object/stat.js
index 522d240f95..e89fe64860 100644
--- a/src/cli/commands/object/stat.js
+++ b/src/cli/commands/object/stat.js
@@ -1,21 +1,13 @@
 'use strict'
 
-const multibase = require('multibase')
 const print = require('../../utils').print
-const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
   command: 'stat <key>',
 
   describe: 'Get stats for the DAG node named by <key>',
 
-  builder: {
-    'cid-base': {
-      describe: 'Number base to display CIDs in.',
-      type: 'string',
-      choices: multibase.names
-    }
-  },
+  builder: {},
 
   handler ({ ipfs, key, cidBase }) {
     ipfs.object.stat(key, { enc: 'base58' }, (err, stats) => {
@@ -26,7 +18,7 @@ module.exports = {
       delete stats.Hash // only for js-ipfs-http-client output
 
       Object.keys(stats).forEach((key) => {
-        print(`${key}: ${cidToString(stats[key], cidBase)}`)
+        print(`${key}: ${stats[key]}`)
       })
     })
   }

From dcde143526bacd435b04c97f3063a3df5e77ffac Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Tue, 20 Nov 2018 23:36:17 +0000
Subject: [PATCH 26/41] fix: pin rm test

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/cli/pin.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/test/cli/pin.js b/test/cli/pin.js
index 7fc55adb3e..5313e3dbd3 100644
--- a/test/cli/pin.js
+++ b/test/cli/pin.js
@@ -34,8 +34,11 @@ describe('pin', () => runOnAndOff(thing => {
         .then(out => expect(out).to.equal(`unpinned ${pins.root}\n`))
     })
 
-    it('should rm and print CIDs encoded in specified base', () => {
-      return ipfs(`pin rm ${pins.root} --cid-base=base64`)
+    it('should rm and print CIDs encoded in specified base', function () {
+      this.timeout(30 * 1000)
+
+      return ipfs(`add -r ${fixturePath}`)
+        .then(() => ipfs(`pin rm ${pins.root} --cid-base=base64`))
         .then(out => {
           const b64CidStr = new CID(pins.root).toV1().toBaseEncodedString('base64')
           expect(out).to.eql(`unpinned ${b64CidStr}\n`)

From c06c7b5a3f0931f34ff466b9e287ec6aeecd99b8 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 23 Nov 2018 10:51:06 +0000
Subject: [PATCH 27/41] chore: update dependencies

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index d1f51beaab..6a6915c627 100644
--- a/package.json
+++ b/package.json
@@ -122,7 +122,7 @@
     "ipld-git": "~0.2.2",
     "ipld-zcash": "~0.1.6",
     "ipns": "~0.4.3",
-    "is-ipfs": "~0.4.7",
+    "is-ipfs": "~0.4.8",
     "is-pull-stream": "~0.0.0",
     "is-stream": "^1.1.0",
     "joi": "^14.3.0",

From 6e44992f93e5765359b7757ce4a985345592bd23 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Mon, 26 Nov 2018 09:04:08 +0000
Subject: [PATCH 28/41] chore: appease linter

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/bitswap.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/http-api/inject/bitswap.js b/test/http-api/inject/bitswap.js
index 7855774f35..afec15d017 100644
--- a/test/http-api/inject/bitswap.js
+++ b/test/http-api/inject/bitswap.js
@@ -31,7 +31,7 @@ module.exports = (http) => {
           if (res.statusCode !== 200) {
             return cb(new Error(`unexpected status ${res.statusCode}`))
           }
-          const wanted = !!res.result.Keys.find(k => k['/'] === wantedCid)
+          const wanted = Boolean(res.result.Keys.find(k => k['/'] === wantedCid))
           cb(null, wanted)
         })
       }

From e1bd28ba252f20e18777d1c464ce2b55130ef781 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Thu, 29 Nov 2018 15:35:52 +0000
Subject: [PATCH 29/41] fix: bad merge

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/object/patch/add-link.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cli/commands/object/patch/add-link.js b/src/cli/commands/object/patch/add-link.js
index 088db5d073..762462e31d 100644
--- a/src/cli/commands/object/patch/add-link.js
+++ b/src/cli/commands/object/patch/add-link.js
@@ -39,7 +39,7 @@ module.exports = {
             throw err
           }
 
-          print(cidToString(result, cidBase))
+          print(cidToString(cid, cidBase))
         })
       })
     })

From 1093610030a03ff5597c12dffff822b831bc6de1 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 14 Dec 2018 11:15:06 +0000
Subject: [PATCH 30/41] feat: optional upgrade, disable for bitswap

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/bitswap/stat.js     |  4 ++--
 src/cli/commands/bitswap/unwant.js   |  4 ++--
 src/cli/commands/bitswap/wantlist.js |  4 ++--
 src/http/api/resources/bitswap.js    | 12 +++++++++---
 src/utils/cid.js                     | 13 +++++++++----
 5 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/src/cli/commands/bitswap/stat.js b/src/cli/commands/bitswap/stat.js
index 2588a3e534..94060701eb 100644
--- a/src/cli/commands/bitswap/stat.js
+++ b/src/cli/commands/bitswap/stat.js
@@ -11,7 +11,7 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
@@ -23,7 +23,7 @@ module.exports = {
         throw err
       }
 
-      stats.wantlist = stats.wantlist.map(k => cidToString(k['/'], cidBase))
+      stats.wantlist = stats.wantlist.map(k => cidToString(k['/'], { base: cidBase, upgrade: false }))
       stats.peers = stats.peers || []
 
       print(`bitswap status
diff --git a/src/cli/commands/bitswap/unwant.js b/src/cli/commands/bitswap/unwant.js
index f9a0627d55..af0c77296b 100644
--- a/src/cli/commands/bitswap/unwant.js
+++ b/src/cli/commands/bitswap/unwant.js
@@ -16,7 +16,7 @@ module.exports = {
       type: 'string'
     },
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
@@ -26,7 +26,7 @@ module.exports = {
       if (err) {
         throw err
       }
-      print(`Key ${cidToString(key, cidBase)} removed from wantlist`)
+      print(`Key ${cidToString(key, { base: cidBase, upgrade: false })} removed from wantlist`)
     })
   }
 }
diff --git a/src/cli/commands/bitswap/wantlist.js b/src/cli/commands/bitswap/wantlist.js
index 9396db0ee1..7c8e15d1a2 100644
--- a/src/cli/commands/bitswap/wantlist.js
+++ b/src/cli/commands/bitswap/wantlist.js
@@ -16,7 +16,7 @@ module.exports = {
       type: 'string'
     },
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
@@ -27,7 +27,7 @@ module.exports = {
       if (err) {
         throw err
       }
-      list.Keys.forEach(k => print(cidToString(k['/'], cidBase)))
+      list.Keys.forEach(k => print(cidToString(k['/'], { base: cidBase, upgrade: false })))
     })
   }
 }
diff --git a/src/http/api/resources/bitswap.js b/src/http/api/resources/bitswap.js
index bd9b1d9895..9028fce698 100644
--- a/src/http/api/resources/bitswap.js
+++ b/src/http/api/resources/bitswap.js
@@ -23,7 +23,11 @@ exports.wantlist = {
       if (err) {
         return reply(boom.badRequest(err))
       }
-      reply({ Keys: list.Keys.map(k => ({ '/': cidToString(k['/'], cidBase) })) })
+      reply({
+        Keys: list.Keys.map(k => ({
+          '/': cidToString(k['/'], { base: cidBase, upgrade: false })
+        }))
+      })
     })
   }
 }
@@ -47,7 +51,9 @@ exports.stat = {
         }).code(500)
       }
 
-      stats.wantlist = stats.wantlist.map(k => ({ '/': cidToString(k['/'], cidBase) }))
+      stats.wantlist = stats.wantlist.map(k => ({
+        '/': cidToString(k['/'], { base: cidBase, upgrade: false })
+      }))
 
       reply({
         ProvideBufLen: stats.provideBufLen,
@@ -82,7 +88,7 @@ exports.unwant = {
       if (err) {
         return reply(boom.badRequest(err))
       }
-      reply({ key: cidToString(key, request.query['cid-base']) })
+      reply({ key: cidToString(key, { base: request.query['cid-base'], upgrade: false }) })
     })
   }
 }
diff --git a/src/utils/cid.js b/src/utils/cid.js
index 56f1b8fa60..c36e9bb21d 100644
--- a/src/utils/cid.js
+++ b/src/utils/cid.js
@@ -2,15 +2,20 @@
 
 const CID = require('cids')
 
-// Stringify a CID in the requested base, auto-converting to v1 if necessary
-exports.cidToString = (cid, base) => {
+// Stringify a CID in the requested base, upgrading to v1 if necessary
+exports.cidToString = (cid, options) => {
+  options = options || {}
+  options.base = options.base || null
+  options.upgrade = options.upgrade !== false
+
   if (!CID.isCID(cid)) {
     cid = new CID(cid)
   }
 
-  if (cid.version === 0 && base && base !== 'base58btc') {
+  if (cid.version === 0 && options.base && options.base !== 'base58btc') {
+    if (!options.upgrade) return cid.toString()
     cid = cid.toV1()
   }
 
-  return cid.toBaseEncodedString(base)
+  return cid.toBaseEncodedString(options.base)
 }

From 541a730ca007b3a5b3ca88c164e5c6bb3cfcded8 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 14 Dec 2018 11:39:37 +0000
Subject: [PATCH 31/41] fix: do not auto upgrade object API CIDs

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/object/get.js               |  4 ++--
 src/cli/commands/object/links.js             |  2 +-
 src/cli/commands/object/new.js               |  2 +-
 src/cli/commands/object/patch/add-link.js    |  2 +-
 src/cli/commands/object/patch/append-data.js |  2 +-
 src/cli/commands/object/patch/rm-link.js     |  2 +-
 src/cli/commands/object/patch/set-data.js    |  2 +-
 src/cli/commands/object/put.js               |  2 +-
 src/utils/cid.js                             | 16 +++++++++++++++-
 9 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/src/cli/commands/object/get.js b/src/cli/commands/object/get.js
index 59541f9ae6..e7927354d4 100644
--- a/src/cli/commands/object/get.js
+++ b/src/cli/commands/object/get.js
@@ -41,13 +41,13 @@ module.exports = {
 
         const answer = {
           Data: data,
-          Hash: cidToString(result, cidBase),
+          Hash: cidToString(result, { base: cidBase, upgrade: false }),
           Size: node.size,
           Links: node.links.map((l) => {
             return {
               Name: l.name,
               Size: l.size,
-              Hash: cidToString(l.cid, cidBase)
+              Hash: cidToString(l.cid, { base: cidBase, upgrade: false })
             }
           })
         }
diff --git a/src/cli/commands/object/links.js b/src/cli/commands/object/links.js
index e820967ff8..f40ae621a0 100644
--- a/src/cli/commands/object/links.js
+++ b/src/cli/commands/object/links.js
@@ -24,7 +24,7 @@ module.exports = {
       }
 
       links.forEach((link) => {
-        print(`${cidToString(link.cid, cidBase)} ${link.size} ${link.name}`)
+        print(`${cidToString(link.cid, { base: cidBase, upgrade: false })} ${link.size} ${link.name}`)
       })
     })
   }
diff --git a/src/cli/commands/object/new.js b/src/cli/commands/object/new.js
index fc73f8c313..58da80c723 100644
--- a/src/cli/commands/object/new.js
+++ b/src/cli/commands/object/new.js
@@ -23,7 +23,7 @@ module.exports = {
         throw err
       }
 
-      print(cidToString(cid, cidBase))
+      print(cidToString(cid, { base: cidBase, upgrade: false }))
     })
   }
 }
diff --git a/src/cli/commands/object/patch/add-link.js b/src/cli/commands/object/patch/add-link.js
index 762462e31d..ccbeb2cedb 100644
--- a/src/cli/commands/object/patch/add-link.js
+++ b/src/cli/commands/object/patch/add-link.js
@@ -39,7 +39,7 @@ module.exports = {
             throw err
           }
 
-          print(cidToString(cid, cidBase))
+          print(cidToString(cid, { base: cidBase, upgrade: false }))
         })
       })
     })
diff --git a/src/cli/commands/object/patch/append-data.js b/src/cli/commands/object/patch/append-data.js
index 8e221f3090..424064aacd 100644
--- a/src/cli/commands/object/patch/append-data.js
+++ b/src/cli/commands/object/patch/append-data.js
@@ -14,7 +14,7 @@ function appendData (key, data, ipfs, options) {
       throw err
     }
 
-    print(cidToString(cid, options.cidBase))
+    print(cidToString(cid, { base: options.cidBase, upgrade: false }))
   })
 }
 
diff --git a/src/cli/commands/object/patch/rm-link.js b/src/cli/commands/object/patch/rm-link.js
index 8763449477..82dff38379 100644
--- a/src/cli/commands/object/patch/rm-link.js
+++ b/src/cli/commands/object/patch/rm-link.js
@@ -25,7 +25,7 @@ module.exports = {
         throw err
       }
 
-      print(cidToString(cid, cidBase))
+      print(cidToString(cid, { base: cidBase, upgrade: false }))
     })
   }
 }
diff --git a/src/cli/commands/object/patch/set-data.js b/src/cli/commands/object/patch/set-data.js
index efdaefeda4..d201ab2900 100644
--- a/src/cli/commands/object/patch/set-data.js
+++ b/src/cli/commands/object/patch/set-data.js
@@ -14,7 +14,7 @@ function parseAndAddNode (key, data, ipfs, options) {
       throw err
     }
 
-    print(cidToString(cid, options.cidBase))
+    print(cidToString(cid, { base: options.cidBase, upgrade: false }))
   })
 }
 
diff --git a/src/cli/commands/object/put.js b/src/cli/commands/object/put.js
index 996bd3b949..f0bb0a6f26 100644
--- a/src/cli/commands/object/put.js
+++ b/src/cli/commands/object/put.js
@@ -12,7 +12,7 @@ function putNode (buf, options, ipfs) {
       throw err
     }
 
-    print(`added ${cidToString(cid, options.cidBase)}`)
+    print(`added ${cidToString(cid, { base: options.cidBase, upgrade: false })}`)
   })
 }
 
diff --git a/src/utils/cid.js b/src/utils/cid.js
index c36e9bb21d..adf16963d0 100644
--- a/src/utils/cid.js
+++ b/src/utils/cid.js
@@ -2,7 +2,21 @@
 
 const CID = require('cids')
 
-// Stringify a CID in the requested base, upgrading to v1 if necessary
+/**
+* Stringify a CID encoded in the requested base, upgrading to v1 if necessary.
+*
+* Setting upgrade to false will disable automatic CID upgrading from v0 to v1
+* which is necessary if the multibase is something other than base58btc. Note
+* that it will also not apply the encoding (since v0 CIDs can only be encoded
+* as base58btc).
+*
+* @param {CID|Buffer|String} cid The CID to encode
+* @param {Object} [options] Optional options
+* @param {String} [options.base] Name of multibase codec to encode the CID with
+* @param {Boolean} [options.upgrade] Automatically upgrade v0 CIDs to v1 when
+* necessary. Default: true.
+* @returns {String}
+*/
 exports.cidToString = (cid, options) => {
   options = options || {}
   options.base = options.base || null

From 575c0650ab9851fe4e47052d8eefa31b18dd6514 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 14 Dec 2018 11:53:56 +0000
Subject: [PATCH 32/41] fix: convert remaining cidToString usages to use
 options object

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/add.js                 |  2 +-
 src/cli/commands/block/put.js           |  2 +-
 src/cli/commands/block/stat.js          |  2 +-
 src/cli/commands/ls.js                  |  2 +-
 src/cli/commands/pin/add.js             |  2 +-
 src/cli/commands/pin/ls.js              |  2 +-
 src/cli/commands/pin/rm.js              |  2 +-
 src/core/components/resolve.js          |  4 +--
 src/http/api/resources/block.js         |  4 +--
 src/http/api/resources/files-regular.js |  4 +--
 src/http/api/resources/object.js        | 34 ++++++++++++-------------
 src/http/api/resources/pin.js           |  6 ++---
 12 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/src/cli/commands/add.js b/src/cli/commands/add.js
index bf764fb8f7..1d29e46853 100644
--- a/src/cli/commands/add.js
+++ b/src/cli/commands/add.js
@@ -90,7 +90,7 @@ function addPipeline (index, addStream, list, argv) {
       sortBy(added, 'path')
         .reverse()
         .map((file) => {
-          const log = [ 'added', cidToString(file.hash, argv.cidBase) ]
+          const log = [ 'added', cidToString(file.hash, { base: argv.cidBase }) ]
 
           if (!quiet && file.path.length > 0) log.push(file.path)
 
diff --git a/src/cli/commands/block/put.js b/src/cli/commands/block/put.js
index c94cde08cf..a87204b46e 100644
--- a/src/cli/commands/block/put.js
+++ b/src/cli/commands/block/put.js
@@ -13,7 +13,7 @@ function addBlock (data, opts) {
     if (err) {
       throw err
     }
-    print(cidToString(block.cid, opts.cidBase))
+    print(cidToString(block.cid, { base: opts.cidBase }))
   })
 }
 
diff --git a/src/cli/commands/block/stat.js b/src/cli/commands/block/stat.js
index c9e84cfa5f..9c9bdb5e21 100644
--- a/src/cli/commands/block/stat.js
+++ b/src/cli/commands/block/stat.js
@@ -23,7 +23,7 @@ module.exports = {
         throw err
       }
 
-      print('Key: ' + cidToString(stats.key, cidBase))
+      print('Key: ' + cidToString(stats.key, { base: cidBase }))
       print('Size: ' + stats.size)
     })
   }
diff --git a/src/cli/commands/ls.js b/src/cli/commands/ls.js
index 1dea656fb2..66667326bd 100644
--- a/src/cli/commands/ls.js
+++ b/src/cli/commands/ls.js
@@ -40,7 +40,7 @@ module.exports = {
         throw err
       }
 
-      links = links.map(file => Object.assign(file, { hash: cidToString(file.hash, cidBase) }))
+      links = links.map(file => Object.assign(file, { hash: cidToString(file.hash, { base: cidBase }) }))
 
       if (headers) {
         links = [{ hash: 'Hash', size: 'Size', name: 'Name' }].concat(links)
diff --git a/src/cli/commands/pin/add.js b/src/cli/commands/pin/add.js
index 38eaf9ee5f..8d7ec6ccdc 100644
--- a/src/cli/commands/pin/add.js
+++ b/src/cli/commands/pin/add.js
@@ -29,7 +29,7 @@ module.exports = {
     ipfs.pin.add(ipfsPath, { recursive }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        print(`pinned ${cidToString(res.hash, cidBase)} ${type}ly`)
+        print(`pinned ${cidToString(res.hash, { base: cidBase })} ${type}ly`)
       })
     })
   }
diff --git a/src/cli/commands/pin/ls.js b/src/cli/commands/pin/ls.js
index 83487567d9..68792dc9d8 100644
--- a/src/cli/commands/pin/ls.js
+++ b/src/cli/commands/pin/ls.js
@@ -37,7 +37,7 @@ module.exports = {
     ipfs.pin.ls(paths, { type }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        let line = cidToString(res.hash, cidBase)
+        let line = cidToString(res.hash, { base: cidBase })
         if (!quiet) {
           line += ` ${res.type}`
         }
diff --git a/src/cli/commands/pin/rm.js b/src/cli/commands/pin/rm.js
index e7a10bb272..d99f16ebc9 100644
--- a/src/cli/commands/pin/rm.js
+++ b/src/cli/commands/pin/rm.js
@@ -27,7 +27,7 @@ module.exports = {
     ipfs.pin.rm(ipfsPath, { recursive }, (err, results) => {
       if (err) { throw err }
       results.forEach((res) => {
-        print(`unpinned ${cidToString(res.hash, cidBase)}`)
+        print(`unpinned ${cidToString(res.hash, { base: cidBase })}`)
       })
     })
   }
diff --git a/src/core/components/resolve.js b/src/core/components/resolve.js
index 14034427bc..bd23a33b20 100644
--- a/src/core/components/resolve.js
+++ b/src/core/components/resolve.js
@@ -29,7 +29,7 @@ module.exports = (self) => {
     const cid = new CID(split[2])
 
     if (split.length === 3) {
-      return setImmediate(() => cb(null, `/ipfs/${cidToString(cid, opts.cidBase)}`))
+      return setImmediate(() => cb(null, `/ipfs/${cidToString(cid, { base: opts.cidBase })}`))
     }
 
     const path = split.slice(3).join('/')
@@ -37,7 +37,7 @@ module.exports = (self) => {
     resolve(cid, path, (err, cid) => {
       if (err) return cb(err)
       if (!cid) return cb(new Error('found non-link at given path'))
-      cb(null, `/ipfs/${cidToString(cid, opts.cidBase)}`)
+      cb(null, `/ipfs/${cidToString(cid, { base: opts.cidBase })}`)
     })
   })
 
diff --git a/src/http/api/resources/block.js b/src/http/api/resources/block.js
index 6167e203f8..929e1a40ab 100644
--- a/src/http/api/resources/block.js
+++ b/src/http/api/resources/block.js
@@ -119,7 +119,7 @@ exports.put = {
       }
 
       return reply({
-        Key: cidToString(block.cid, request.query['cid-base']),
+        Key: cidToString(block.cid, { base: request.query['cid-base'] }),
         Size: block.data.length
       })
     })
@@ -172,7 +172,7 @@ exports.stat = {
       }
 
       return reply({
-        Key: cidToString(stats.key, request.query['cid-base']),
+        Key: cidToString(stats.key, { base: request.query['cid-base'] }),
         Size: stats.size
       })
     })
diff --git a/src/http/api/resources/files-regular.js b/src/http/api/resources/files-regular.js
index 612c06aa7e..d0944e250e 100644
--- a/src/http/api/resources/files-regular.js
+++ b/src/http/api/resources/files-regular.js
@@ -280,7 +280,7 @@ exports.add = {
       pull.map((file) => {
         return {
           Name: file.path, // addPullStream already turned this into a hash if it wanted to
-          Hash: cidToString(file.hash, request.query['cid-base']),
+          Hash: cidToString(file.hash, { base: request.query['cid-base'] }),
           Size: file.size
         }
       }),
@@ -331,7 +331,7 @@ exports.ls = {
           Hash: key,
           Links: files.map((file) => ({
             Name: file.name,
-            Hash: cidToString(file.hash, cidBase),
+            Hash: cidToString(file.hash, { base: cidBase }),
             Size: file.size,
             Type: toTypeCode(file.type),
             Depth: file.depth
diff --git a/src/http/api/resources/object.js b/src/http/api/resources/object.js
index 63f2d09b47..ee4125285a 100644
--- a/src/http/api/resources/object.js
+++ b/src/http/api/resources/object.js
@@ -61,13 +61,13 @@ exports.new = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       }
@@ -113,13 +113,13 @@ exports.get = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       }
@@ -238,13 +238,13 @@ exports.put = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       }
@@ -278,7 +278,7 @@ exports.stat = {
         }).code(500)
       }
 
-      stats.Hash = cidToString(stats.Hash, request.query['cid-base'])
+      stats.Hash = cidToString(stats.Hash, { base: request.query['cid-base'], upgrade: false })
 
       return reply(stats)
     })
@@ -338,12 +338,12 @@ exports.links = {
       const nodeJSON = results.node.toJSON()
 
       return reply({
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       })
@@ -423,13 +423,13 @@ exports.patchAppendData = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       }
@@ -471,12 +471,12 @@ exports.patchSetData = {
       const nodeJSON = results.node.toJSON()
 
       return reply({
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       })
@@ -551,13 +551,13 @@ exports.patchAddLink = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       }
@@ -624,13 +624,13 @@ exports.patchRmLink = {
 
       const answer = {
         Data: nodeJSON.data,
-        Hash: cidToString(results.cid, request.query['cid-base']),
+        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
         Size: nodeJSON.size,
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
             Size: l.size,
-            Hash: cidToString(l.cid, request.query['cid-base'])
+            Hash: cidToString(l.cid, { base: request.query['cid-base'], upgrade: false })
           }
         })
       }
diff --git a/src/http/api/resources/pin.js b/src/http/api/resources/pin.js
index cf99d28c41..4aea71de58 100644
--- a/src/http/api/resources/pin.js
+++ b/src/http/api/resources/pin.js
@@ -58,7 +58,7 @@ exports.ls = {
 
       return reply({
         Keys: mapValues(
-          keyBy(result, obj => cidToString(obj.hash, request.query['cid-base'])),
+          keyBy(result, obj => cidToString(obj.hash, { base: request.query['cid-base'] })),
           obj => ({ Type: obj.type })
         )
       })
@@ -89,7 +89,7 @@ exports.add = {
       }
 
       return reply({
-        Pins: result.map(obj => cidToString(obj.hash, request.query['cid-base']))
+        Pins: result.map(obj => cidToString(obj.hash, { base: request.query['cid-base'] }))
       })
     })
   }
@@ -118,7 +118,7 @@ exports.rm = {
       }
 
       return reply({
-        Pins: result.map(obj => cidToString(obj.hash, request.query['cid-base']))
+        Pins: result.map(obj => cidToString(obj.hash, { base: request.query['cid-base'] }))
       })
     })
   }

From 33d508a0e4ed21768785e5cabd11163620e599c3 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 14 Dec 2018 12:21:40 +0000
Subject: [PATCH 33/41] fix: bitswap CLI tests

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/cli/bitswap.js | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/test/cli/bitswap.js b/test/cli/bitswap.js
index 9e8279e204..757dda97a7 100644
--- a/test/cli/bitswap.js
+++ b/test/cli/bitswap.js
@@ -10,14 +10,16 @@ const waitFor = require('../utils/wait-for')
 describe('bitswap', () => runOn((thing) => {
   let ipfs
   let peerId
-  const key = 'QmUBdnXXPyoDFXj3Hj39dNJ5VkN3QFRskXxcGaYFBB8CNR'
+  const key0 = 'QmUBdnXXPyoDFXj3Hj39dNJ5VkN3QFRskXxcGaYFBB8CNR'
+  const key1 = 'zb2rhafnd6kEUujnoMkozHnWXY7XpWttyVDWKXfChqA42VTDU'
 
   before(() => {
     ipfs = thing.ipfs
   })
 
   before(() => {
-    ipfs('block get ' + key).catch(() => {})
+    ipfs('block get ' + key0).catch(() => {})
+    ipfs('block get ' + key1).catch(() => {})
   })
 
   before(function (done) {
@@ -35,12 +37,12 @@ describe('bitswap', () => runOn((thing) => {
 
     const test = (cb) => {
       ipfs('bitswap wantlist')
-        .then(out => cb(null, out.includes(key)))
+        .then(out => cb(null, out.includes(key0) && out.includes(key1)))
         .catch(cb)
     }
 
     waitFor(test, {
-      name: key + ' to be wanted',
+      name: `${key0} and ${key1} to be wanted`,
       timeout: 60 * 1000
     }, done)
   })
@@ -48,14 +50,14 @@ describe('bitswap', () => runOn((thing) => {
   it('wantlist', function () {
     this.timeout(20 * 1000)
     return ipfs('bitswap wantlist').then((out) => {
-      expect(out).to.eql(key + '\n')
+      expect(out).to.eql(key0 + '\n' + key1 + '\n')
     })
   })
 
   it('should get wantlist with CIDs encoded in specified base', function () {
     this.timeout(20 * 1000)
     return ipfs('bitswap wantlist --cid-base=base64').then((out) => {
-      expect(out).to.eql(new CID(key).toV1().toBaseEncodedString('base64') + '\n')
+      expect(out).to.include(new CID(key1).toBaseEncodedString('base64') + '\n')
     })
   })
 
@@ -75,8 +77,9 @@ describe('bitswap', () => runOn((thing) => {
         '  blocks received: 0',
         '  dup blocks received: 0',
         '  dup data received: 0B',
-        '  wantlist [1 keys]',
-        `    ${key}`,
+        '  wantlist [2 keys]',
+        `    ${key0}`,
+        `    ${key1}`,
         // We sometimes pick up partners while the tests run so our assertion ends here
         '  partners'
       ].join('\n'))
@@ -86,13 +89,13 @@ describe('bitswap', () => runOn((thing) => {
   it('should get stats with wantlist CIDs encoded in specified base', function () {
     this.timeout(20 * 1000)
     return ipfs('bitswap stat --cid-base=base64').then((out) => {
-      expect(out).to.include(new CID(key).toV1().toBaseEncodedString('base64'))
+      expect(out).to.include(new CID(key1).toBaseEncodedString('base64'))
     })
   })
 
   it('unwant', function () {
-    return ipfs('bitswap unwant ' + key).then((out) => {
-      expect(out).to.eql(`Key ${key} removed from wantlist\n`)
+    return ipfs('bitswap unwant ' + key0).then((out) => {
+      expect(out).to.eql(`Key ${key0} removed from wantlist\n`)
     })
   })
 }))

From 6da7777909b723ed9e2177b81327428168c13ba0 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 14 Dec 2018 13:30:31 +0000
Subject: [PATCH 34/41] fix: bitswap HTTP tests

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/bitswap.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/test/http-api/inject/bitswap.js b/test/http-api/inject/bitswap.js
index afec15d017..e91f80293e 100644
--- a/test/http-api/inject/bitswap.js
+++ b/test/http-api/inject/bitswap.js
@@ -7,7 +7,8 @@ const waitFor = require('../../utils/wait-for')
 
 module.exports = (http) => {
   describe('/bitswap', () => {
-    const wantedCid = 'QmUBdnXXPyoDFXj3Hj39dNJ5VkN3QFRskXxcGaYFBB8CNR'
+    const wantedCid0 = 'QmUBdnXXPyoDFXj3Hj39dNJ5VkN3QFRskXxcGaYFBB8CNR'
+    const wantedCid1 = 'zb2rhafnd6kEUujnoMkozHnWXY7XpWttyVDWKXfChqA42VTDU'
     let api
 
     before(() => {
@@ -18,10 +19,8 @@ module.exports = (http) => {
       this.timeout(120 * 1000)
 
       // Add a CID to the wantlist
-      api.inject({
-        method: 'GET',
-        url: `/api/v0/block/get?arg=${wantedCid}`
-      })
+      api.inject({ method: 'GET', url: `/api/v0/block/get?arg=${wantedCid0}` })
+      api.inject({ method: 'GET', url: `/api/v0/block/get?arg=${wantedCid1}` })
 
       const test = (cb) => {
         api.inject({
@@ -31,13 +30,14 @@ module.exports = (http) => {
           if (res.statusCode !== 200) {
             return cb(new Error(`unexpected status ${res.statusCode}`))
           }
-          const wanted = Boolean(res.result.Keys.find(k => k['/'] === wantedCid))
-          cb(null, wanted)
+          const isWanted0 = res.result.Keys.some(k => k['/'] === wantedCid0)
+          const isWanted1 = res.result.Keys.some(k => k['/'] === wantedCid1)
+          cb(null, isWanted0 && isWanted1)
         })
       }
 
       waitFor(test, {
-        name: wantedCid + ' to be wanted',
+        name: `${wantedCid0} and ${wantedCid1} to be wanted`,
         timeout: 60 * 1000
       }, done)
     })
@@ -49,13 +49,13 @@ module.exports = (http) => {
       }, (res) => {
         expect(res.statusCode).to.equal(200)
         expect(res.result).to.have.property('Keys')
-        expect(res.result.Keys).to.deep.include({ '/': wantedCid })
+        expect(res.result.Keys).to.deep.include({ '/': wantedCid0 })
         done()
       })
     })
 
     it('/wantlist?cid-base=base64', (done) => {
-      const base64Cid = new CID(wantedCid).toV1().toString('base64')
+      const base64Cid = new CID(wantedCid1).toString('base64')
       api.inject({
         method: 'GET',
         url: '/api/v0/bitswap/wantlist?cid-base=base64'
@@ -97,7 +97,7 @@ module.exports = (http) => {
     })
 
     it('/stat?cid-base=base64', (done) => {
-      const base64Cid = new CID(wantedCid).toV1().toString('base64')
+      const base64Cid = new CID(wantedCid1).toString('base64')
       api.inject({
         method: 'GET',
         url: '/api/v0/bitswap/stat?cid-base=base64'

From 6b5ef94850d45a1e399624dffbb0498c77add34f Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 14 Dec 2018 15:19:57 +0000
Subject: [PATCH 35/41] fix: tests for object API

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json                     |  2 +-
 src/cli/commands/object/get.js   | 47 ++++++++++++---------------
 src/http/api/resources/object.js | 21 ++++++-------
 test/cli/object.js               | 54 +++++++++++++++++++-------------
 4 files changed, 62 insertions(+), 62 deletions(-)

diff --git a/package.json b/package.json
index 6a6915c627..c9aa242c2c 100644
--- a/package.json
+++ b/package.json
@@ -108,7 +108,7 @@
     "ipfs-bitswap": "~0.21.0",
     "ipfs-block": "~0.8.0",
     "ipfs-block-service": "~0.15.1",
-    "ipfs-http-client": "^28.0.1",
+    "ipfs-http-client": "github:ipfs/js-ipfs-http-client#feat/cid-base-option2",
     "ipfs-http-response": "~0.2.1",
     "ipfs-mfs": "~0.8.0",
     "ipfs-multipart": "~0.1.0",
diff --git a/src/cli/commands/object/get.js b/src/cli/commands/object/get.js
index e7927354d4..e48864a1c2 100644
--- a/src/cli/commands/object/get.js
+++ b/src/cli/commands/object/get.js
@@ -2,7 +2,6 @@
 
 const multibase = require('multibase')
 const { print } = require('../../utils')
-const dagPB = require('ipld-dag-pb')
 const { cidToString } = require('../../../utils/cid')
 
 module.exports = {
@@ -28,32 +27,26 @@ module.exports = {
         throw err
       }
 
-      dagPB.util.cid(node, (err, result) => {
-        if (err) {
-          throw err
-        }
-
-        let data = node.data
-
-        if (Buffer.isBuffer(data)) {
-          data = node.data.toString(dataEncoding || undefined)
-        }
-
-        const answer = {
-          Data: data,
-          Hash: cidToString(result, { base: cidBase, upgrade: false }),
-          Size: node.size,
-          Links: node.links.map((l) => {
-            return {
-              Name: l.name,
-              Size: l.size,
-              Hash: cidToString(l.cid, { base: cidBase, upgrade: false })
-            }
-          })
-        }
-
-        print(JSON.stringify(answer))
-      })
+      let data = node.data
+
+      if (Buffer.isBuffer(data)) {
+        data = node.data.toString(dataEncoding || undefined)
+      }
+
+      const answer = {
+        Data: data,
+        Hash: cidToString(key, { base: cidBase, upgrade: false }),
+        Size: node.size,
+        Links: node.links.map((l) => {
+          return {
+            Name: l.name,
+            Size: l.size,
+            Hash: cidToString(l.cid, { base: cidBase, upgrade: false })
+          }
+        })
+      }
+
+      print(JSON.stringify(answer))
     })
   }
 }
diff --git a/src/http/api/resources/object.js b/src/http/api/resources/object.js
index ee4125285a..e3ed14d72f 100644
--- a/src/http/api/resources/object.js
+++ b/src/http/api/resources/object.js
@@ -1,6 +1,6 @@
 'use strict'
 
-const mh = require('multihashes')
+const CID = require('cids')
 const multipart = require('ipfs-multipart')
 const dagPB = require('ipld-dag-pb')
 const DAGLink = dagPB.DAGLink
@@ -23,7 +23,7 @@ exports.parseKey = (request, reply) => {
 
   try {
     return reply({
-      key: mh.fromB58String(request.query.arg)
+      key: new CID(request.query.arg)
     })
   } catch (err) {
     log.error(err)
@@ -323,10 +323,7 @@ exports.links = {
     const key = request.pre.args.key
     const ipfs = request.server.app.ipfs
 
-    waterfall([
-      (cb) => ipfs.object.get(key, cb),
-      (node, cb) => dagPB.util.cid(node, (err, cid) => cb(err, { node, cid }))
-    ], (err, results) => {
+    ipfs.object.get(key, (err, node) => {
       if (err) {
         log.error(err)
         return reply({
@@ -335,10 +332,10 @@ exports.links = {
         }).code(500)
       }
 
-      const nodeJSON = results.node.toJSON()
+      const nodeJSON = node.toJSON()
 
       return reply({
-        Hash: cidToString(results.cid, { base: request.query['cid-base'], upgrade: false }),
+        Hash: cidToString(key, { base: request.query['cid-base'], upgrade: false }),
         Links: nodeJSON.links.map((l) => {
           return {
             Name: l.name,
@@ -379,7 +376,7 @@ exports.parseKeyAndData = (request, reply) => {
       return reply({
         data: file,
         // TODO: support ipfs paths: https://github.com/ipfs/http-api-spec/pull/68/files#diff-2625016b50d68d922257f74801cac29cR3880
-        key: mh.fromB58String(request.query.arg)
+        key: new CID(request.query.arg)
       })
     } catch (err) {
       return reply({
@@ -517,9 +514,9 @@ exports.patchAddLink = {
 
     try {
       return reply({
-        root: mh.fromB58String(request.query.arg[0]),
+        root: new CID(request.query.arg[0]),
         name: request.query.arg[1],
-        ref: mh.fromB58String(request.query.arg[2])
+        ref: new CID(request.query.arg[2])
       })
     } catch (err) {
       log.error(err)
@@ -590,7 +587,7 @@ exports.patchRmLink = {
 
     try {
       return reply({
-        root: mh.fromB58String(request.query.arg[0]),
+        root: new CID(request.query.arg[0]),
         link: request.query.arg[1]
       })
     } catch (err) {
diff --git a/test/cli/object.js b/test/cli/object.js
index de6c5828df..ceb9f24627 100644
--- a/test/cli/object.js
+++ b/test/cli/object.js
@@ -9,6 +9,7 @@ const path = require('path')
 const fs = require('fs')
 const crypto = require('crypto')
 const os = require('os')
+const multibase = require('multibase')
 
 describe('object', () => runOnAndOff((thing) => {
   let ipfs
@@ -33,7 +34,8 @@ describe('object', () => runOnAndOff((thing) => {
     })
   })
 
-  it('should new and print CID encoded in specified base', () => {
+  // TODO: unskip after switch to v1 CIDs by default
+  it.skip('should new and print CID encoded in specified base', () => {
     return ipfs('object new --cid-base=base64').then((out) => {
       expect(out).to.eql(
         'mAXASIOOwxEKY/BwUmvv0yJlvuSQnrkHkZJuTTKSVmRt4UrhV\n'
@@ -41,14 +43,6 @@ describe('object', () => runOnAndOff((thing) => {
     })
   })
 
-  it('should new and print CID encoded in specified base', () => {
-    return ipfs('object new --cid-base=base32').then((out) => {
-      expect(out).to.eql(
-        'bafybeihdwdcefgh4dqkjv67uzcmw7ojee6xedzdetojuzjevtenxquvyku\n'
-      )
-    })
-  })
-
   it('get', () => {
     return ipfs('object get QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n').then((out) => {
       const result = JSON.parse(out)
@@ -86,13 +80,18 @@ describe('object', () => runOnAndOff((thing) => {
   })
 
   it('should get and print CIDs encoded in specified base', () => {
-    return ipfs('object put test/fixtures/test-data/node.json')
-      .then(out => out.replace('added', '').trim())
+    return ipfs('add test/fixtures/planets -r --cid-version=1')
+      .then(out => {
+        const lines = out.trim().split('\n')
+        return lines[lines.length - 1].split(' ')[1]
+      })
       .then(cid => ipfs(`object get ${cid} --cid-base=base64`))
       .then(out => {
         const result = JSON.parse(out)
-        expect(result.Hash).to.equal('mAXASIKbM02Neyt6L1RRLYVEOuNlqDOzTvBboo3cI/u6f/+Vk')
-        expect(result.Links[0].Hash).to.equal('mAXASIIq3psXnRzeHisc4Y8t2c50V1GZt5E5XVr9Vovnpq19E')
+        expect(multibase.isEncoded(result.Hash)).to.deep.equal('base64')
+        result.Links.forEach(l => {
+          expect(multibase.isEncoded(l.Hash)).to.deep.equal('base64')
+        })
       })
   })
 
@@ -104,7 +103,8 @@ describe('object', () => runOnAndOff((thing) => {
     })
   })
 
-  it('should put and print CID encoded in specified base', () => {
+  // TODO: unskip after switch to v1 CIDs by default
+  it.skip('should put and print CID encoded in specified base', () => {
     return ipfs('object put test/fixtures/test-data/node.json --cid-base=base64')
       .then((out) => {
         expect(out).to.eql(
@@ -133,7 +133,7 @@ describe('object', () => runOnAndOff((thing) => {
     })
   })
 
-  it('unadulterated data', function () {
+  it('unaltered data', function () {
     this.timeout(10 * 1000)
 
     // has to be big enough to span several DAGNodes
@@ -163,11 +163,17 @@ describe('object', () => runOnAndOff((thing) => {
   })
 
   it('should get links and print CIDs encoded in specified base', () => {
-    return ipfs('object put test/fixtures/test-data/node.json')
-      .then(out => out.replace('added', '').trim())
+    return ipfs('add test/fixtures/planets -r --cid-version=1')
+      .then(out => {
+        const lines = out.trim().split('\n')
+        return lines[lines.length - 1].split(' ')[1]
+      })
       .then(cid => ipfs(`object links ${cid} --cid-base=base64`))
       .then(out => {
-        expect(out).to.equal('mAXASIIq3psXnRzeHisc4Y8t2c50V1GZt5E5XVr9Vovnpq19E 8 some link\n')
+        out.trim().split('\n').forEach(line => {
+          const cid = line.split(' ')[0]
+          expect(multibase.isEncoded(cid)).to.deep.equal('base64')
+        })
       })
   })
 
@@ -182,7 +188,8 @@ describe('object', () => runOnAndOff((thing) => {
       })
     })
 
-    it('should append-data and print CID encoded in specified base', () => {
+    // TODO: unskip after switch to v1 CIDs by default
+    it.skip('should append-data and print CID encoded in specified base', () => {
       return ipfs('object patch append-data QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n test/fixtures/test-data/badconfig --cid-base=base64').then((out) => {
         expect(out).to.eql(
           'mAXASIP+BZ7jGtaTyLGOs0xYcQvH7K9kVKEbyzXAkwLoZwrRj\n'
@@ -198,7 +205,8 @@ describe('object', () => runOnAndOff((thing) => {
       })
     })
 
-    it('should set-data and print CID encoded in specified base', () => {
+    // TODO: unskip after switch to v1 CIDs by default
+    it.skip('should set-data and print CID encoded in specified base', () => {
       return ipfs('object patch set-data QmfY37rjbPCZRnhvvJuQ46htW3VCAWziVB991P79h6WSv6 test/fixtures/test-data/badconfig --cid-base=base64').then((out) => {
         expect(out).to.eql(
           'mAXASIP+BZ7jGtaTyLGOs0xYcQvH7K9kVKEbyzXAkwLoZwrRj\n'
@@ -214,7 +222,8 @@ describe('object', () => runOnAndOff((thing) => {
       })
     })
 
-    it('should add-link and print CID encoded in specified base', () => {
+    // TODO: unskip after switch to v1 CIDs by default
+    it.skip('should add-link and print CID encoded in specified base', () => {
       return ipfs('object patch add-link QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n foo QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn --cid-base=base64').then((out) => {
         expect(out).to.eql(
           'mAXASIOEVPbXq2xYoEsRZhaPB61btcy1x359osjv4a2L/lgPs\n'
@@ -230,7 +239,8 @@ describe('object', () => runOnAndOff((thing) => {
       })
     })
 
-    it('should rm-link and print CID encoded in specified base', () => {
+    // TODO: unskip after switch to v1 CIDs by default
+    it.skip('should rm-link and print CID encoded in specified base', () => {
       return ipfs('object patch rm-link QmdVHE8fUD6FLNLugtNxqDFyhaCgdob372hs6BYEe75VAK foo --cid-base=base64').then((out) => {
         expect(out).to.eql(
           'mAXASIOOwxEKY/BwUmvv0yJlvuSQnrkHkZJuTTKSVmRt4UrhV\n'

From acd8aa53f4cd28ee58741a3f07545dd4e6e5d57e Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Fri, 14 Dec 2018 15:35:10 +0000
Subject: [PATCH 36/41] docs: add note about CIDv0 base encoding for bitswap
 and object APIs

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 src/cli/commands/object/get.js               | 2 +-
 src/cli/commands/object/links.js             | 2 +-
 src/cli/commands/object/new.js               | 2 +-
 src/cli/commands/object/patch/add-link.js    | 2 +-
 src/cli/commands/object/patch/append-data.js | 2 +-
 src/cli/commands/object/patch/rm-link.js     | 2 +-
 src/cli/commands/object/patch/set-data.js    | 2 +-
 src/cli/commands/object/put.js               | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/cli/commands/object/get.js b/src/cli/commands/object/get.js
index e48864a1c2..456449492c 100644
--- a/src/cli/commands/object/get.js
+++ b/src/cli/commands/object/get.js
@@ -15,7 +15,7 @@ module.exports = {
       default: 'base64'
     },
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
diff --git a/src/cli/commands/object/links.js b/src/cli/commands/object/links.js
index f40ae621a0..768e42150c 100644
--- a/src/cli/commands/object/links.js
+++ b/src/cli/commands/object/links.js
@@ -11,7 +11,7 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
diff --git a/src/cli/commands/object/new.js b/src/cli/commands/object/new.js
index 58da80c723..d48f4c69ee 100644
--- a/src/cli/commands/object/new.js
+++ b/src/cli/commands/object/new.js
@@ -11,7 +11,7 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
diff --git a/src/cli/commands/object/patch/add-link.js b/src/cli/commands/object/patch/add-link.js
index ccbeb2cedb..a1a573a031 100644
--- a/src/cli/commands/object/patch/add-link.js
+++ b/src/cli/commands/object/patch/add-link.js
@@ -13,7 +13,7 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
diff --git a/src/cli/commands/object/patch/append-data.js b/src/cli/commands/object/patch/append-data.js
index 424064aacd..b54f301f62 100644
--- a/src/cli/commands/object/patch/append-data.js
+++ b/src/cli/commands/object/patch/append-data.js
@@ -25,7 +25,7 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
diff --git a/src/cli/commands/object/patch/rm-link.js b/src/cli/commands/object/patch/rm-link.js
index 82dff38379..ca7be4e8a5 100644
--- a/src/cli/commands/object/patch/rm-link.js
+++ b/src/cli/commands/object/patch/rm-link.js
@@ -11,7 +11,7 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
diff --git a/src/cli/commands/object/patch/set-data.js b/src/cli/commands/object/patch/set-data.js
index d201ab2900..7c7209ea57 100644
--- a/src/cli/commands/object/patch/set-data.js
+++ b/src/cli/commands/object/patch/set-data.js
@@ -25,7 +25,7 @@ module.exports = {
 
   builder: {
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }
diff --git a/src/cli/commands/object/put.js b/src/cli/commands/object/put.js
index f0bb0a6f26..c9999bb335 100644
--- a/src/cli/commands/object/put.js
+++ b/src/cli/commands/object/put.js
@@ -27,7 +27,7 @@ module.exports = {
       default: 'json'
     },
     'cid-base': {
-      describe: 'Number base to display CIDs in.',
+      describe: 'Number base to display CIDs in. Note: specifying a CID base for v0 CIDs will have no effect.',
       type: 'string',
       choices: multibase.names
     }

From 23c9370012bdb21489d8ec465443d20b439dfc3a Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Sun, 16 Dec 2018 20:13:55 +0000
Subject: [PATCH 37/41] fix: more reliable bitswap tests!

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/cli/bitswap.js | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/test/cli/bitswap.js b/test/cli/bitswap.js
index 757dda97a7..ddc0d9b626 100644
--- a/test/cli/bitswap.js
+++ b/test/cli/bitswap.js
@@ -50,7 +50,8 @@ describe('bitswap', () => runOn((thing) => {
   it('wantlist', function () {
     this.timeout(20 * 1000)
     return ipfs('bitswap wantlist').then((out) => {
-      expect(out).to.eql(key0 + '\n' + key1 + '\n')
+      expect(out).to.include(key0)
+      expect(out).to.include(key1)
     })
   })
 
@@ -77,12 +78,13 @@ describe('bitswap', () => runOn((thing) => {
         '  blocks received: 0',
         '  dup blocks received: 0',
         '  dup data received: 0B',
-        '  wantlist [2 keys]',
-        `    ${key0}`,
-        `    ${key1}`,
-        // We sometimes pick up partners while the tests run so our assertion ends here
-        '  partners'
+        // We sometimes pick up partners while the tests run and the order of
+        // wanted keys is not defined so our assertion ends here.
+        '  wantlist [2 keys]'
       ].join('\n'))
+
+      expect(out).to.include(key0)
+      expect(out).to.include(key1)
     })
   })
 

From 1d7faf4e39062a5948f7a78d281012650f01e3d5 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Sun, 16 Dec 2018 20:45:56 +0000
Subject: [PATCH 38/41] fix: ls cid base test

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/files.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/http-api/inject/files.js b/test/http-api/inject/files.js
index bae8f48f8f..66c4e8a1f6 100644
--- a/test/http-api/inject/files.js
+++ b/test/http-api/inject/files.js
@@ -145,7 +145,7 @@ module.exports = (http) => {
               url: '/api/v0/ls?cid-base=base64&arg=' + dir.Hash
             }, (res) => {
               expect(res.statusCode).to.equal(200)
-              res.result.Objects.forEach(item => {
+              res.result.Objects[0].Links.forEach(item => {
                 expect(multibase.isEncoded(item.Hash)).to.deep.equal('base64')
               })
               done()

From 7c588644475576d5e82e555a743338a0c74e0c48 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Sun, 16 Dec 2018 22:41:25 +0000
Subject: [PATCH 39/41] chore: update deps

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index c9aa242c2c..9d8b8337f2 100644
--- a/package.json
+++ b/package.json
@@ -108,7 +108,7 @@
     "ipfs-bitswap": "~0.21.0",
     "ipfs-block": "~0.8.0",
     "ipfs-block-service": "~0.15.1",
-    "ipfs-http-client": "github:ipfs/js-ipfs-http-client#feat/cid-base-option2",
+    "ipfs-http-client": "~28.1.0",
     "ipfs-http-response": "~0.2.1",
     "ipfs-mfs": "~0.8.0",
     "ipfs-multipart": "~0.1.0",

From ff430826b06ff68ef5da76c29b4855cc45d7cade Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Sun, 16 Dec 2018 23:01:49 +0000
Subject: [PATCH 40/41] fix: appease linter

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 9d8b8337f2..9875580401 100644
--- a/package.json
+++ b/package.json
@@ -108,7 +108,7 @@
     "ipfs-bitswap": "~0.21.0",
     "ipfs-block": "~0.8.0",
     "ipfs-block-service": "~0.15.1",
-    "ipfs-http-client": "~28.1.0",
+    "ipfs-http-client": "^28.1.0",
     "ipfs-http-response": "~0.2.1",
     "ipfs-mfs": "~0.8.0",
     "ipfs-multipart": "~0.1.0",

From 94f2617d6de3e45bddea183808b8a003a6958824 Mon Sep 17 00:00:00 2001
From: Alan Shaw <alan.shaw@protocol.ai>
Date: Mon, 17 Dec 2018 08:59:08 +0000
Subject: [PATCH 41/41] fix: add skips for tests that cannot pass until CIDv1
 by default

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
---
 test/http-api/inject/object.js | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/test/http-api/inject/object.js b/test/http-api/inject/object.js
index 232ddc1922..8180b4e8bd 100644
--- a/test/http-api/inject/object.js
+++ b/test/http-api/inject/object.js
@@ -35,7 +35,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should create a new object and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should create a new object and return a base64 encoded CID', (done) => {
         api.inject({
           method: 'POST',
           url: '/api/v0/object/new?cid-base=base64'
@@ -94,7 +95,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should get object and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should get object and return a base64 encoded CID', (done) => {
         api.inject({
           method: 'POST',
           url: '/api/v0/object/new'
@@ -199,7 +201,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should put data and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should put data and return a base64 encoded CID', (done) => {
         const form = new FormData()
         form.append('file', JSON.stringify({ Data: 'TEST' + Date.now(), Links: [] }), { filename: 'node.json' })
         const headers = form.getHeaders()
@@ -278,7 +281,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should stat object and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should stat object and return a base64 encoded CID', (done) => {
         api.inject({
           method: 'POST',
           url: '/api/v0/object/new'
@@ -393,7 +397,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should list object links and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should list object links and return a base64 encoded CID', (done) => {
         waterfall([
           (cb) => {
             api.inject({
@@ -560,7 +565,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should append data to object and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should append data to object and return a base64 encoded CID', (done) => {
         api.inject({
           method: 'POST',
           url: '/api/v0/object/new'
@@ -685,7 +691,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should set data for object and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should set data for object and return a base64 encoded CID', (done) => {
         api.inject({
           method: 'POST',
           url: '/api/v0/object/new'
@@ -801,7 +808,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should add a link to an object and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should add a link to an object and return a base64 encoded CID', (done) => {
         api.inject({
           method: 'POST',
           url: '/api/v0/object/new'
@@ -896,7 +904,8 @@ module.exports = (http) => {
         })
       })
 
-      it('should remove a link from an object and return a base64 encoded CID', (done) => {
+      // TODO: unskip after switch to v1 CIDs by default
+      it.skip('should remove a link from an object and return a base64 encoded CID', (done) => {
         const linkName = 'TEST' + Date.now()
 
         waterfall([