Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

webrtc-star/simple peer errors, setRemoteDescription #3231

Closed
tabcat opened this issue Aug 17, 2020 · 3 comments
Closed

webrtc-star/simple peer errors, setRemoteDescription #3231

tabcat opened this issue Aug 17, 2020 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/libp2p Topic libp2p

Comments

@tabcat
Copy link
Contributor

tabcat commented Aug 17, 2020

  • Version:
    commit: "0425c84bbfb6af75e2dbf5db444ced577f728d23"
    interface-ipfs-core: "^0.138.0"
    ipfs-http-client: "^45.0.0"
    repo: 8
    version: "0.48.2"

  • Platform:
    uname -a: Linux xps 5.4.0-42-generic bootstrap #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
    chromium --version: Chromium 84.0.4147.105 snap

  • Subsystem:
    libp2p-webrtc-star
    libp2p-webrtc-peer

shown errors:
logged errors

js-libp2p-webrtc-star/src/index.js
js-libp2p-webrtc-star/src/index.js

libp2p-webrtc-peer/index.js:
libp2p-webrtc-peer/index.js

Severity:

Low - Everything seems to be working fine as far as webrtc-star discovery

Description:

After having https://alpha.sailplane.io open for a while (not sure how long unfortunately, I've had it open overnight idling) it will show ~20k errors logged relating to webrtc-star and simple peer. I've linked screenshots below

Steps to reproduce the error:

I've left the website idle for a while, haven't tracked time but it happens consistently.

@tabcat tabcat added the need/triage Needs initial labeling and prioritization label Aug 17, 2020
@achingbrain achingbrain added kind/bug A bug in existing code (including security flaws) topic/libp2p Topic libp2p and removed need/triage Needs initial labeling and prioritization labels Aug 17, 2020
@achingbrain
Copy link
Member

achingbrain commented Aug 17, 2020

libp2p-webrtc-star should not be overriding the message property of errors, could you please open an issue on https://github.com/libp2p/js-libp2p-webrtc-star ?

@tabcat
Copy link
Contributor Author

tabcat commented Aug 17, 2020

Yes, I will open one now.

@jacobheun
Copy link
Contributor

Closing this in favor of libp2p/js-libp2p-webrtc-star#251

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws) topic/libp2p Topic libp2p
Projects
None yet
Development

No branches or pull requests

3 participants