This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix(gateway): keep pretty URL and return implicit index.html #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes current logic (redirect to index.html) to match what go-ipfs does (return index.html without changing URL) We also ensure directory URLs always end with '/' License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
commented
Jul 4, 2019
| ? await ipfs.name.resolve(path, { recursive: true }) | ||
| : path) | ||
|
|
||
| let directory = false |
There was a problem hiding this comment.
I went with explicit flag to make it easier to review/modify code paths related to directories (with and without index.html)
lidel
commented
Jul 4, 2019
| @@ -153,7 +159,7 @@ module.exports = { | |||
| log.error(err) | |||
| return reject(err) | |||
| } | |||
| resolve({ peekedStream, contentType: detectContentType(path, streamHead) }) | |||
| resolve({ peekedStream, contentType: detectContentType(ipfsPath, streamHead) }) | |||
There was a problem hiding this comment.
ipfsPath instead of path because if we are returning implicit index.html we want to detect HTML content type of the file, not the dir.
alanshaw
approved these changes
Jul 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cosmetic PR enables pretty URLs for directories with
index.htmlIt follows what go-ipfs does: return implicit
index.htmlwithout changing URLTL;DR:
It also makes logs more useful by showing both requested HTTP path and resolved IPFS one: