This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
perf: lower connection manager limits #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned 
jacobheun
reviewed
Mar 13, 2019
| LowWater: 600, | ||
| HighWater: 900 | ||
| LowWater: 200, | ||
| HighWater: 500 |
There was a problem hiding this comment.
We can try this, but I think 500 is going to end up being too high for the browser. I think it's more reasonably going to be in the range of 50-200.
There was a problem hiding this comment.
I'm going to get some testing done for this in the browser and adjust it accordingly, for now just setting it to be the same as Node.js.
There was a problem hiding this comment.
while it is not enabled in the browser, I think it is fine to be the same
|
Merging because the CI failure is unrelated and will be resolved in a subsequent PR: 1) cli
dht
query:
Error: Command failed: /Users/travis/build/ipfs/js-ipfs/src/cli/bin.js dht query Qmbkf4u9FFDM5i5PywnpgLuPQg8tP8qBBWXQTWEswYdxwp
connect ECONNREFUSED 127.0.0.1:52855
at makeError (node_modules/execa/index.js:174:9)
at Promise.all.then.arr (node_modules/execa/index.js:278:16)
at process._tickCallback (internal/process/next_tick.js:68:7) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed that over ~600 peers the node becomes less stable, this lowers the default limits until we can address performance issues in libp2p.