This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: path to cid-tool commands #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the edge case where IPFS is a dependency of a project and the user attempts to use the IPFS CLI, the cid-tool will not be installed at `proj/node_modules/ipfs/node_modules/cid-tool` but will instead be flattened by npm and installed at `proj/node_modules/cid-tool`. i.e. next to `ipfs` in the dependency tree instead of a child of. This PR fixes this situation by using `require.resolve` to get the path to the `cid-tool` instead of assuming where it is installed. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned 
achingbrain
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the edge case where IPFS is a dependency of a project and the user attempts to use the IPFS CLI, the
cid-toolwill not be installed atproj/node_modules/ipfs/node_modules/cid-toolbut will instead be flattened by npm and installed atproj/node_modules/cid-tool. i.e. next toipfsin the dependency tree instead of a child of.This PR fixes this situation by using
require.resolveto get the path to thecid-toolinstead of assuming where it is installed.FYI I found this bug while using the
ipfs cid base32command with a JS IPFS installed withiim. I was getting the error:Which is correct, the
cid-toolwas actually installed at/Users/alan/.iim/dists/js-ipfs@0.34.4/node_modules/cid-tool.