This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: support _dnslink subdomain specified dnslinks #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
changed the title
alanshaw
suggested changes
Jan 24, 2019
alanshaw
suggested changes
Jan 24, 2019
alanshaw
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1842
This includes resolution of
_dnslinksubdomains outward and inward. If the supplied domain is_dnslink.domain.comand resolution fails thendomain.comwill be checked (inward checking). If the supplied domain isdomain.comand the resolution fails then_dnslink.domain.comwill be checked (outward checking).Inward checking is not specified in the dnslink spec, but seems like it may be useful.
Tests
I added a test case for
_dnslink.ipfs.ioto ensure that inward resolution works. It probably makes sense to create a dns entry on theipfs.iodomain like_dnslink.dnslink_test.ipfs.ioso a test can be added forjsipfs dns dnslink_test.ipfs.io.The referenced issue contains commands with an example domain config for testing. I checked the go-ipfs test suite for guidance on testing but didn't find anything.