fix: do not stringify output of object data #1398
Conversation
ghost
assigned 
achingbrain
force-pushed
the
print-raw-data
branch
from
d1ea007
to
355b602
Compare
|
Weird that the tests were passing on Circle but exploding in a fairly dramatic fashion on Jenkins. 🤷♂️ A rebase and it's all looking good. |
|
Does this need a "BREAKING CHANGE" section in the commit message or should this be considered a bug fix? Is not a chore?! |
Indeed. Could be because of the aggressive caching Circle does of the dependencies. |
I don't think so, we're not changing an API or interface so it shouldn't break anything, quite the opposite.
It feels like a chore. Just kidding, would you like me to change the commit message? |
|
|
Without this change:
```sh
$ jsipfs object data `dd if=/dev/urandom bs=307200 count=1 | jsipfs files write --create /some-file && jsipfs files ls -h /some-file` | unixfs
{"type":"file","blockSizes":[72481833443311,10909182287855]}
```
e.g.
```
00000000: 0802 18ef bfbd efbf bd12 20ef bfbd efbf .......... .....
00000010: bd10 20ef bfbd efbf bd02 .. .......
```
With this change:
```sh
$ jsipfs object data `dd if=/dev/urandom bs=307200 count=1 | jsipfs files write --create /some-file && jsipfs files ls -h /some-file` | unixfs
{"type":"file","blockSizes":[262144,45056]}
```
e.g.
```
00000000: 0802 1880 e012 2080 8010 2080 e002 ...... ... ...
```
Stringifying the data changes it's encoding. Been banging my head against this all morning.
achingbrain
force-pushed
the
print-raw-data
branch
from
355b602
to
8010173
Compare
Fair enough, have updated the commit message. |
achingbrain
changed the title
Without this change:
e.g.
With this change:
e.g.
Stringifying the data changes it's encoding. Been banging my head against this all morning.