Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

cli: add IPFS_PATH info to init command help #1274

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Conversation

bvand
Copy link
Contributor

@bvand bvand commented Mar 21, 2018

Connects to #1213.

I tried using .usage() from the yargs package, but it just seems to be a different way of doing normal yargs configuration (no special ability to add a prologue).

License: MIT
Signed-off-by: Brian Vander Schaaf <bvs330@gmail.com>
@bvand bvand mentioned this pull request Mar 21, 2018
@bvand
Copy link
Contributor Author

bvand commented Mar 21, 2018

With my changes:
inithelppostchanges
Without my changes:
inithelpprechanges

Note that it's "bin.js" rather than "jsipfs" because that's the name of the script that's running.

@daviddias daviddias requested a review from vmx March 25, 2018 02:35
@bvand
Copy link
Contributor Author

bvand commented Mar 26, 2018

@diasdavid the tests are all passing locally, and I'm having some trouble figuring out how to trigger rebuilds with the CI tools. Can you point me in the direction of any resources there might be to help me out?

I'm missing permissions for Jenkins - seeing "bvand is missing the Overall/Read permission" after logging in.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It's ready to me merged once Jenkins is green.

@vmx
Copy link
Member

vmx commented Mar 31, 2018

CI is flaky, but this change certainly doesn't introduce new failures.

@diasdavid Can you please merge that one?

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @vmx :)

@daviddias daviddias merged commit e189b72 into ipfs:master Mar 31, 2018
JonKrone pushed a commit to JonKrone/js-ipfs that referenced this pull request Apr 3, 2018
License: MIT
Signed-off-by: Brian Vander Schaaf <bvs330@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants