Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: accept objects in file.add #1257

Merged
merged 3 commits into from
Mar 9, 2018
Merged

fix: accept objects in file.add #1257

merged 3 commits into from
Mar 9, 2018

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Mar 9, 2018

Adding back ability to pass objects to files.add - {path: <string>, data: Buffer.from('hello')}. This regressed in 4b79066

@ghost ghost assigned dryajov Mar 9, 2018
@ghost ghost added the status/in-progress In progress label Mar 9, 2018
@Mr0grog
Copy link
Contributor

Mr0grog commented Mar 9, 2018

Seems like it might be good to add a regression test for that, too.

@dryajov
Copy link
Member Author

dryajov commented Mar 9, 2018

Adding test ipfs-inactive/interface-js-ipfs-core#234

@daviddias
Copy link
Member

Good catch! Can you check why CI isn't green too?

@daviddias
Copy link
Member

daviddias commented Mar 9, 2018

@dryajov tested locally. It fails because js-ipfs-api has the same issue. I'm fixing it.

@ghost ghost assigned daviddias Mar 9, 2018
@daviddias
Copy link
Member

verified locally and in some of the CI runs. hotfix incoming.

@daviddias daviddias merged commit d32dad9 into master Mar 9, 2018
@daviddias daviddias deleted the fix/files-object branch March 9, 2018 11:08
@ghost ghost removed the status/in-progress In progress label Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants