This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: use reduces keysize #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
previously approved these changes
Feb 21, 2018
| @@ -31,7 +31,7 @@ describe('ls', () => runOnAndOff((thing) => { | |||
| // If the daemon is on, ls should search until it hits a timeout | |||
| return Promise.race([ | |||
| ipfs.fail('ls QmYmW4HiZhotsoSqnv2o1oSssvkRM8b9RweBoH7ao5nki2'), | |||
| new Promise((res, rej) => setTimeout(res, 4000)) | |||
| new Promise((resolve, reject) => setTimeout(resolve, 4000)) | |||
There was a problem hiding this comment.
hehe, lint was madly yelling that its unacceptable :)
|
ipfsd-ctl 0.29 released. Let's get the dep updated and see how much time we shave. Right now it is: Circle: Travis: |
|
Success! Seems like we got around ~7 mins off
|
|
Roughly 5 minutes and half. Good, was hopping for something better.
@victorbjelkholm it would be so great to parallelize the CLI, HTTP, Core and Browser tests. |
daviddias
approved these changes
Feb 22, 2018
dryajov
added a commit
that referenced
this pull request
Feb 27, 2018
* feat: use reduces keysize * chore: update deps
dryajov
added a commit
that referenced
this pull request
Feb 28, 2018
* feat: use reduces keysize * chore: update deps
JonKrone
pushed a commit
to JonKrone/js-ipfs
that referenced
this pull request
Mar 3, 2018
* feat: use reduces keysize * chore: update deps
JonKrone
pushed a commit
to JonKrone/js-ipfs
that referenced
this pull request
Mar 3, 2018
* feat: use reduces keysize * chore: update deps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.