fix: progress bar flakiness (#1042)

* fix: fix progress bar flakiness * feat: reuse createAddPullStream to avoid code duplication
ipfs · Oct 20, 2017 · d7732c3 · d7732c3
1 parent 7fc80dc
commit d7732c3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 18 deletions.
diff --git a/src/cli/commands/files/add.js b/src/cli/commands/files/add.js
@@ -203,8 +203,6 @@ module.exports = {
     const ipfs = argv.ipfs
 
     let list = []
-    let currentBytes = 0
-
     waterfall([
       (next) => glob(path.join(inPath, '/**/*'), next),
       (globResult, next) => {
@@ -216,8 +214,7 @@ module.exports = {
         if (argv.progress) {
           const bar = createProgressBar(totalBytes)
           options.progress = function (byteLength) {
-            currentBytes += byteLength
-            bar.tick(byteLength, {progress: byteman(currentBytes, 2, 'MB')})
+            bar.update(byteLength / totalBytes, {progress: byteman(byteLength, 2, 'MB')})
           }
         }
 

diff --git a/src/core/components/files.js b/src/core/components/files.js
@@ -20,6 +20,14 @@ module.exports = function files (self) {
       shardSplitThreshold: self._options.EXPERIMENTAL.sharding ? 1000 : Infinity
     }, options)
 
+    let total = 0
+    let prog = opts.progress || (() => {})
+    const progress = (bytes) => {
+      total += bytes
+      prog(total)
+    }
+
+    opts.progress = progress
     return pull(
       pull.map(normalizeContent),
       pull.flatten(),
@@ -65,18 +73,9 @@ module.exports = function files (self) {
         return callback(new Error('Invalid arguments, data must be an object, Buffer or readable stream'))
       }
 
-      let total = 0
-      let prog = options.progress || (() => {})
-      const progress = (bytes) => {
-        total += bytes
-        prog(total)
-      }
-
-      options.progress = progress
       pull(
-        pull.values(normalizeContent(data)),
-        importer(self._ipldResolver, options),
-        pull.asyncMap(prepareFile.bind(null, self, options)),
+        pull.values([data]),
+        createAddPullStream(options),
         sort((a, b) => {
           if (a.path < b.path) return 1
           if (a.path > b.path) return -1

diff --git a/src/http/api/resources/files.js b/src/http/api/resources/files.js
@@ -209,10 +209,8 @@ exports.add = {
     })
 
     const replyStream = pushable()
-    let total = 0
     const progressHandler = (bytes) => {
-      total += bytes
-      replyStream.push({ Bytes: total })
+      replyStream.push({ Bytes: bytes })
     }
 
     const options = {