feat(http): better error messages

src/http-api/resources/files.js

@@ -17,7 +17,10 @@ exports = module.exports
 // common pre request handler that parses the args and returns `key` which is assigned to `request.pre.args`
 exports.parseKey = (request, reply) => {
   if (!request.query.arg) {
-    return reply("Argument 'key' is required").code(400).takeover()
+    return reply({
+      Message: "Argument 'key' is required",
+      Code: 0
+    }).code(400).takeover()
   }
 
   try {
@@ -127,7 +130,10 @@ exports.get = {
 exports.add = {
   handler: (request, reply) => {
     if (!request.payload) {
-      return reply('Array, Buffer, or String is required.').code(400).takeover()
+      return reply({
+        Message: 'Array, Buffer, or String is required.',
+        code: 0
+      }).code(400).takeover()
     }
 
     const ipfs = request.server.app.ipfs
@@ -155,8 +161,10 @@ exports.add = {
 
     parser.on('end', () => {
       if (!filesParsed) {
-        return reply("File argument 'data' is required.")
-          .code(400).takeover()
+        return reply({
+          Message: "File argument 'data' is required.",
+          code: 0
+        }).code(400).takeover()
       }
       fileAdder.end()
     })
@@ -186,7 +194,7 @@ exports.add = {
           }).code(500)
         }
 
-        reply(files.join(''))
+        reply(files.join('\n'))
           .header('x-chunked-output', '1')
           .header('content-type', 'application/json')
       })

src/http-api/resources/swarm.js

@@ -104,7 +104,7 @@ exports.connect = {
         }).code(500)
       }
 
-      return reply({
+      reply({
         Strings: [`connect ${addr} success`]
       })
     })

test/http-api/inject/test-files.js

@@ -20,7 +20,7 @@ module.exports = (http) => {
           url: '/api/v0/cat'
         }, (res) => {
           expect(res.statusCode).to.equal(400)
-          expect(res.result).to.be.a('string')
+          expect(res.result.Message).to.be.a('string')
           done()
         })
       })