Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Commit

Permalink
fix: name resolve arg parsing (#1958)
Browse files Browse the repository at this point in the history
Boolean args were not being parsed as booleans.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
  • Loading branch information
Alan Shaw authored Mar 21, 2019
1 parent 3b91ea1 commit 924690e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/cli/commands/daemon.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = {
default: false
})
.option('offline', {
type: 'boolean',
desc: 'Run offline. Do not connect to the rest of the network but provide local API.',
default: false
})
Expand Down
4 changes: 3 additions & 1 deletion src/cli/commands/name/resolve.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@ module.exports = {

builder: {
nocache: {
type: 'boolean',
alias: 'n',
describe: 'Do not use cached entries. Default: false.',
default: false
},
recursive: {
type: 'boolean',
alias: 'r',
recursive: 'Resolve until the result is not an IPNS name. Default: false.',
describe: 'Resolve until the result is not an IPNS name. Default: false.',
default: false
}
},
Expand Down
3 changes: 1 addition & 2 deletions test/cli/name.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ describe('name', () => {
})
})

// FIXME: currently failing, resolve before 0.35 release!
it.skip('should go recursively until finding an ipfs hash', function () {
it('should go recursively until finding an ipfs hash', function () {
this.timeout(90 * 1000)

return ipfs(`name publish ${cidAdded}`)
Expand Down

0 comments on commit 924690e

Please sign in to comment.