fix: close root datastore #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocks, keys and datastore are being closed in repo.close() but root is not.
7 tasks
jacobheun
reviewed
Nov 14, 2019
|
current tests are weird everything works on the same repo, i can't just stop instances any tips where to write the test ? |
alanshaw
approved these changes
Nov 19, 2019
|
This came from ctl refactor, i was trying to clean the disposable browser nodes and kept getting an error. Then i found that cleaning in the browser is completely different from node, one needs to delete 4 idb's and i could delete 3 of them but not the |
alanshaw
approved these changes
Nov 19, 2019
|
@hugomrdias can you fix the linting issue with CI? |
jacobheun
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocks, keys and datastore are being closed in repo.close() but root is not.