Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memlock throws error when lock exists #200

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Memlock throws error when lock exists #200

merged 1 commit into from
Aug 7, 2019

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented Jun 27, 2019

Memlock throws error when lock exists
Fix for memlock to throw an error when trying to acquire already
existing lock.

License: MIT
Signed-off-by: Adam Uhlir uhlir.a@gmail.com

@AuHau
Copy link
Member Author

AuHau commented Aug 6, 2019

Related to #194

@AuHau AuHau requested a review from jacobheun August 6, 2019 15:09
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! @AuHau can you rebase when you get a chance, there are some conflicts now due to the config key error merge.

Memlock throws error when lock exists
Fix for memlock to throw an error when trying to acquire already
existing lock.

License: MIT
Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>
@AuHau
Copy link
Member Author

AuHau commented Aug 7, 2019

@jacobheun conflict resolved.

@AuHau
Copy link
Member Author

AuHau commented Aug 7, 2019

Since you have approved it already, I took the liberty to merge it, so I could work on the refactor of the errors as it would create another merge conflict afterward. Hope it is alright!

@AuHau AuHau merged commit 79fb031 into ipfs:master Aug 7, 2019
@AuHau AuHau deleted the fix/memlock_handling_existing_locks branch August 7, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants