This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: ipns over pubsub #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
feat/ipns-over-pubsub
branch
from
963288e
to
a45f748
Compare
7 tasks
alanshaw
suggested changes
Oct 17, 2018
There was a problem hiding this comment.
Looks great @vasco-santos - I've made a few minor comments 🙌
src/name/pubsub/subs.js
Outdated
| const transform = function (res, callback) { | ||
| callback(null, { | ||
| strings: res.Strings | ||
| }) |
There was a problem hiding this comment.
Please can we just return an array here (and detect if go-ipfs returns null and change it to an empty array)
test/interface.spec.js
Outdated
| // name.pubsub.cancel | ||
| { | ||
| name: 'should cancel a subscription correctly returning true', | ||
| reasone: 'go-ipfs is really slow for publishing and resolving ipns records, unless in offline mode' |
There was a problem hiding this comment.
Typo: "reasone" => "reason"
test/name-pubsub.spec.js
Outdated
| done() | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
These are not needed - the interface-ipfs-core tests cover it adequetly.
vasco-santos
force-pushed
the
feat/ipns-over-pubsub
branch
2 times, most recently
from
8227bce
to
7fcde72
Compare
|
@vasco-santos interface-ipfs-core@0.80 released |
vasco-santos
force-pushed
the
feat/ipns-over-pubsub
branch
from
ce3f028
to
44c3c9b
Compare
alanshaw
approved these changes
Oct 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking into consideration the most recent documentation of the API on:
http://ipfs.io/ipfs/QmPKzWaeHumLuiKLb2Ak67s5kxZ1p6YbnjVKYYfF9hTjzn
Needs:
interface-ipfs-core