Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error on Blake3 CID #394

Closed
lidel opened this issue Aug 28, 2023 · 4 comments · Fixed by #395
Closed

error on Blake3 CID #394

lidel opened this issue Aug 28, 2023 · 4 comments · Fixed by #395
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Aug 28, 2023

Add something big with ipfs add --hash blake3 --chunker size-1048576 and try to explore the CID.

Ref. https://explore.ipld.io/#/explore/bafyb4idpl4jjcsxsqa3ju2ey2n7npnpsruhgyqc7gfo3axt76hpavm4p7q

It errors in bot webui and on the website:

2023-08-28_23-54
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Aug 28, 2023
@whizzzkid whizzzkid added exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up need/analysis Needs further analysis before proceeding need/maintainer-input Needs input from the current maintainer(s) and removed need/triage Needs initial labeling and prioritization labels Aug 31, 2023
@whizzzkid
Copy link
Contributor

@lidel I don't think the size is the issue here. it fails for me even for a small file.

Image

Error:

Failed to decode CID Error: unknown multihasher code '30'
    at hash-importer.js:32:13
    at h (regeneratorRuntime.js:44:17)
    at Generator.<anonymous> (regeneratorRuntime.js:125:22)
    at Generator.next (regeneratorRuntime.js:69:21)
    at r (asyncToGenerator.js:3:20)
    at s (asyncToGenerator.js:22:9)
    at asyncToGenerator.js:27:7

@rvagg
Copy link
Member

rvagg commented Aug 31, 2023

Supported hashers are in https://github.com/ipfs/ipld-explorer-components/blob/master/src/lib/hash-importer.ts

Unfortunately we don't have a blake3 hasher in JS as far as I'm aware; yet. Although I did just release multiformats@>10 versions of both the full blake2 (s & b) set and sha3, they could be added.

@lidel
Copy link
Member Author

lidel commented Aug 31, 2023

Blake3 has been allowed in Kubo since ipfs/kubo#8650 (comment).
No super urgent today, but the more people use it, the more often our users we will hit this error.

@rvagg
Copy link
Member

rvagg commented Aug 31, 2023

well lookie lookie https://github.com/web3-storage/blake3-multihash

so that could be added to hash-importers.ts too and it should be 👌

@whizzzkid whizzzkid mentioned this issue Sep 1, 2023
Merged
@rvagg rvagg mentioned this issue Sep 6, 2023
Open
7 tasks
@whizzzkid whizzzkid mentioned this issue Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(hasher): add blake3 ipfs/ipld-explorer-components
3 participants
@lidel @rvagg @whizzzkid