Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui error report] Error: Command failed: powershell.exe -NoProfile -NonInteractive -InputF #2335

Closed
Destroyinator69420 opened this issue Nov 13, 2022 · 4 comments · Fixed by #1856
Labels
area/updates Issues related to manual and automatic updates area/windows Windows effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/windows Windows specific

Comments

@Destroyinator69420
Copy link

👉️ Please describe what you were doing when this error happened.

Specifications

  • OS: win32 10.0.22000
  • IPFS Desktop Version: 0.24.0
  • Electron Version: 19.0.9
  • Chrome Version: 102.0.5005.167

Error

Error: Command failed: powershell.exe -NoProfile -NonInteractive -InputFormat None -Command Get-AuthenticodeSignature -LiteralPath 'C:\Users\Jknap\AppData\Local\ipfs-desktop-updater\pending\temp-IPFS-Desktop-Setup-0.24.1.exe' | ConvertTo-Json -Compress | ForEach-Object { [Convert]::ToBase64String([System.Text.Encoding]::UTF8.GetBytes($_)) }
Get-AuthenticodeSignature : File 
C:\Users\Jknap\AppData\Local\ipfs-desktop-updater\pending\temp-IPFS-Desktop-Setup-0.24.1.exe was not found.
At line:1 char:1
  Get-AuthenticodeSignature -LiteralPath 'C:\Users\Jknap\AppData\Local\ ...
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      CategoryInfo          : ObjectNotFound: (:) [Get-AuthenticodeSignature], FileNotFoundException
      FullyQualifiedErrorId : SignatureCommandsBaseFileNotFound,Microsoft.PowerShell.Commands.GetAuthenticodeSignature 
   Command
 

    at ChildProcess.exithandler (node:child_process:408:12)
    at ChildProcess.emit (node:events:526:28)
    at maybeClose (node:internal/child_process:1092:16)
    at ChildProcess._handle.onexit (node:internal/child_process:302:5)
@Destroyinator69420 Destroyinator69420 added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Nov 13, 2022
@welcome
Copy link

welcome bot commented Nov 13, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@SgtPooki
Copy link
Member

@Destroyinator69420 Thanks for submitting this issue. I'm not sure we have enough information to help you out. Can you please provide more information:

  • what were you doing when the error occurred?
  • what are you trying to accomplish by running it via PowerShell? or was it done by some third-party tool / process?

It looks like https://blog.doyensec.com/2020/02/24/electron-updater-update-signature-bypass.html and signalapp/Signal-Desktop#3059 provide some context into the reason we're running into this issue, but can you provide any more details?

@SgtPooki SgtPooki added area/windows Windows need/author-input Needs input from the original author need/maintainers-input Needs input from the current maintainer(s) area/updates Issues related to manual and automatic updates topic/windows Windows specific and removed need/triage Needs initial labeling and prioritization labels Nov 21, 2022
@beyondkmp
Copy link

We can replace the PowerShell with a native verify signature module to resolve all powershell problems.

electron-userland/electron-builder#7337

@SgtPooki SgtPooki added P1 High: Likely tackled by core team if no one steps up help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors effort/hours Estimated to take one or several hours status/ready Ready to be worked and removed need/author-input Needs input from the original author need/maintainers-input Needs input from the current maintainer(s) labels Oct 13, 2023
@lidel
Copy link
Member

lidel commented Jun 12, 2024

👉 TLDR: Please manually upgrade IPFS Desktop to v0.36 or later (download .exe from "Assets" here).


Introducing custom code we need to maintain does not sound like something that will fix powershell problems. It will create new / different issues over time. In cases like this, we should wait for upstream fix here. Good news is that electron-userland/electron-builder#7127 got fixed (electron-userland/electron-builder#7127 (comment)) and (hopefully) will be fixed by electron-updater update done in #1856.

If anyone experiences this problem again, means it got broken again by upstream (Electron, Windows), and the way to fix it is to manually install the latest release from https://github.com/ipfs/ipfs-desktop/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/updates Issues related to manual and automatic updates area/windows Windows effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/windows Windows specific
Projects
No open projects
Status: Planned / Backlog
Development

Successfully merging a pull request may close this issue.

4 participants