fix: external node in Firefox 85+ #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #955 and refactors the way we detect requests coming from the Companion extension to be independent from the brittle Origin HTTP header. Instead, we now inspet request via lower level WebExtension API. Added tests for both Firefox in Chromium.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Companion in Firefox 85 (and 86 Nightly) and closes #955
Underlying issue
Based on my debugging session with Firefox Nightly stopped leaking unique extension ID via Origin header. Probably to reduce the surface for fingerprinting, which is pretty funny considering that around v72 Chromium moved... in the opposite direction: Chromium was sending anonymous
Origin: nulland now v86 sends extension ID instead 🤷♂️Overall, the behavior of
OriginHTTP header in XHRs coming from within browser extension is not reliable: vendors change this behavior back and forth, often contradicting each other.Fix
Refactored the way we detect requests coming from the Companion extension to be independent of the brittle Origin HTTP header – instead, we now inspect requests via lower level WebExtension API and updated + added new tests for both Firefox in Chromium variants.